Ryan/documenso
1
0
Fork 1
mirror of https://github.com/documenso/documenso.git synced 2025-11-13 08:13:56 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix: dont nullify externalId if not passed to update document settings

Browse Source
This commit is contained in:
Mythie
2024-09-18 10:27:13 +10:00
parent e76f732990
commit 5091112e4b
2 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/api/v1/implementation.ts
View File

@ -302,7 +302,9 @@ export const ApiContractV1Implementation = createNextRoute(ApiContractV1, {
documentId: document.id, documentId: document.id,
userId: user.id, userId: user.id,
teamId: team?.id, teamId: team?.id,
data: body.authOptions, data: {
...body.authOptions,
},
requestMetadata: extractNextApiRequestMetadata(args.req), requestMetadata: extractNextApiRequestMetadata(args.req),
}); });
} }

15
packages/lib/server-only/document/update-document-settings.ts
View File

@ -93,11 +93,14 @@ export const updateDocumentSettings = async ({
} }
} }
const isTitleSame = data.title === document.title; const isTitleSame = data.title === undefined || data.title === document.title;
const isExternalIdSame = data.externalId === document.externalId; const isExternalIdSame = data.externalId === undefined || data.externalId === document.externalId;
const isGlobalAccessSame = documentGlobalAccessAuth === newGlobalAccessAuth; const isGlobalAccessSame =
const isGlobalActionSame = documentGlobalActionAuth === newGlobalActionAuth; documentGlobalAccessAuth === undefined || documentGlobalAccessAuth === newGlobalAccessAuth;
const isDocumentVisibilitySame = data.visibility === document.visibility; const isGlobalActionSame =
documentGlobalActionAuth === undefined || documentGlobalActionAuth === newGlobalActionAuth;
const isDocumentVisibilitySame =
data.visibility === undefined || data.visibility === document.visibility;
const auditLogs: CreateDocumentAuditLogDataResponse[] = []; const auditLogs: CreateDocumentAuditLogDataResponse[] = [];
@ -200,7 +203,7 @@ export const updateDocumentSettings = async ({
}, },
data: { data: {
title: data.title, title: data.title,
externalId: data.externalId || null, externalId: data.externalId,
visibility: data.visibility as DocumentVisibility, visibility: data.visibility as DocumentVisibility,
authOptions, authOptions,
}, },