From 59170c00f109cbb16acbb2e376d45ad1e194b77f Mon Sep 17 00:00:00 2001 From: ephraimduncan Date: Tue, 25 Aug 2026 03:21:35 +0000 Subject: [PATCH] fix(signing): use default for empty signing reason --- packages/lib/constants/app.test.ts | 6 ++++++ packages/lib/constants/app.ts | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/lib/constants/app.test.ts b/packages/lib/constants/app.test.ts index a3a4ac10e..41d1cf5b6 100644 --- a/packages/lib/constants/app.test.ts +++ b/packages/lib/constants/app.test.ts @@ -13,6 +13,12 @@ describe('NEXT_PRIVATE_SIGNING_REASON', () => { expect(NEXT_PRIVATE_SIGNING_REASON()).toBe('Signed by Documenso'); }); + it('uses the default for an empty signing reason', () => { + vi.stubEnv('NEXT_PRIVATE_SIGNING_REASON', ''); + + expect(NEXT_PRIVATE_SIGNING_REASON()).toBe('Signed by Documenso'); + }); + it('uses the configured signing reason verbatim', () => { vi.stubEnv('NEXT_PRIVATE_SIGNING_REASON', 'Signed by Objective'); diff --git a/packages/lib/constants/app.ts b/packages/lib/constants/app.ts index db166266e..b126f4b95 100644 --- a/packages/lib/constants/app.ts +++ b/packages/lib/constants/app.ts @@ -92,7 +92,7 @@ export const IS_AI_FEATURES_CONFIGURED = (): boolean => { export const NEXT_PRIVATE_USE_PLAYWRIGHT_PDF = () => env('NEXT_PRIVATE_USE_PLAYWRIGHT_PDF') === 'true'; export const NEXT_PRIVATE_SIGNING_TIMESTAMP_AUTHORITY = () => env('NEXT_PRIVATE_SIGNING_TIMESTAMP_AUTHORITY'); -export const NEXT_PRIVATE_SIGNING_REASON = () => env('NEXT_PRIVATE_SIGNING_REASON') ?? 'Signed by Documenso'; +export const NEXT_PRIVATE_SIGNING_REASON = () => env('NEXT_PRIVATE_SIGNING_REASON') || 'Signed by Documenso'; /** * Whether this Documenso instance is running in CSC (Cloud Signature Consortium) mode.