refactor(pdf): simplify AcroForm import code

This commit is contained in:
ephraimduncan
2026-05-27 01:02:43 +00:00
parent 88e836ddbc
commit 5e11db2444
5 changed files with 86 additions and 179 deletions
@@ -98,9 +98,8 @@ export const EnvelopeEditorFieldsPage = () => {
const currentEnvelopeItemRevision = currentEnvelopeItem
? `${currentEnvelopeItem.id}:${currentEnvelopeItem.documentDataId}`
: null;
const currentItemHasAcroForm = currentEnvelopeItemRevision
? acroFormHasFieldsByItemRevision[currentEnvelopeItemRevision] === true
: false;
const currentItemHasAcroForm =
currentEnvelopeItemRevision !== null && acroFormHasFieldsByItemRevision[currentEnvelopeItemRevision] === true;
const onAcroFormDetected = useCallback(
(hasFields: boolean) => {
@@ -16,12 +16,7 @@ export type EnvelopePdfViewerProps = {
errorMessage: { title: MessageDescriptor; description: MessageDescriptor } | null;
} & Omit<PDFViewerProps, 'data'>;
export const EnvelopePdfViewer = ({
errorMessage,
className,
onAcroFormDetected,
...props
}: EnvelopePdfViewerProps) => {
export const EnvelopePdfViewer = ({ errorMessage, className, ...props }: EnvelopePdfViewerProps) => {
const { t } = useLingui();
const $el = useRef<HTMLDivElement>(null);
@@ -55,7 +50,6 @@ export const EnvelopePdfViewer = ({
{...props}
className={cn('h-full w-full max-w-[800px]', className)}
data={currentEnvelopeItem.data}
onAcroFormDetected={onAcroFormDetected}
/>
);
};