From 732dc45295afbd9d39329e8b4e0d7603daa5a3ea Mon Sep 17 00:00:00 2001
From: David Nguyen <davidngu28@gmail.com>
Date: Fri, 6 Oct 2023 14:42:41 +1100
Subject: [PATCH] refactor: restructure logic

---
 .../documents/data-table-action-button.tsx    | 10 +++---
 .../documents/data-table-action-dropdown.tsx  | 10 +++---
 .../sign/[token]/complete/share-button.tsx    | 18 +++++------
 .../client-only/hooks/use-copy-share-link.ts  | 31 +++++++++++--------
 4 files changed, 37 insertions(+), 32 deletions(-)

diff --git a/apps/web/src/app/(dashboard)/documents/data-table-action-button.tsx b/apps/web/src/app/(dashboard)/documents/data-table-action-button.tsx
index 692dfeda5..7acd21b4a 100644
--- a/apps/web/src/app/(dashboard)/documents/data-table-action-button.tsx
+++ b/apps/web/src/app/(dashboard)/documents/data-table-action-button.tsx
@@ -20,7 +20,7 @@ export type DataTableActionButtonProps = {
 export const DataTableActionButton = ({ row }: DataTableActionButtonProps) => {
   const { data: session } = useSession();
 
-  const { copyShareLink, isCopyingShareLink } = useCopyShareLink();
+  const { createAndCopyShareLink, isCopyingShareLink } = useCopyShareLink();
 
   if (!session) {
     return null;
@@ -63,12 +63,12 @@ export const DataTableActionButton = ({ row }: DataTableActionButtonProps) => {
       <Button
         className="w-24"
         loading={isCopyingShareLink}
-        onClick={() => {
-          void copyShareLink({
+        onClick={async () =>
+          createAndCopyShareLink({
             token: recipient?.token,
             documentId: row.id,
-          });
-        }}
+          })
+        }
       >
         {!isCopyingShareLink && <Share className="-ml-1 mr-2 h-4 w-4" />}
         Share
diff --git a/apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx b/apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx
index b127eede1..ef5cb0b24 100644
--- a/apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx
+++ b/apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx
@@ -39,7 +39,7 @@ export type DataTableActionDropdownProps = {
 export const DataTableActionDropdown = ({ row }: DataTableActionDropdownProps) => {
   const { data: session } = useSession();
 
-  const { copyShareLink, isCopyingShareLink } = useCopyShareLink();
+  const { createAndCopyShareLink, isCopyingShareLink } = useCopyShareLink();
 
   if (!session) {
     return null;
@@ -140,12 +140,12 @@ export const DataTableActionDropdown = ({ row }: DataTableActionDropdownProps) =
         </DropdownMenuItem>
 
         <DropdownMenuItem
-          onClick={() => {
-            void copyShareLink({
+          onClick={async () =>
+            createAndCopyShareLink({
               token: recipient?.token,
               documentId: row.id,
-            });
-          }}
+            })
+          }
         >
           {isCopyingShareLink ? (
             <Loader className="mr-2 h-4 w-4" />
diff --git a/apps/web/src/app/(signing)/sign/[token]/complete/share-button.tsx b/apps/web/src/app/(signing)/sign/[token]/complete/share-button.tsx
index 84cf975a1..40bb52dc2 100644
--- a/apps/web/src/app/(signing)/sign/[token]/complete/share-button.tsx
+++ b/apps/web/src/app/(signing)/sign/[token]/complete/share-button.tsx
@@ -24,7 +24,7 @@ export type ShareButtonProps = HTMLAttributes<HTMLButtonElement> & {
 };
 
 export const ShareButton = ({ token, documentId }: ShareButtonProps) => {
-  const { copyShareLink, isCopyingShareLink } = useCopyShareLink();
+  const { copyShareLink, createAndCopyShareLink, isCopyingShareLink } = useCopyShareLink();
 
   const [isOpen, setIsOpen] = useState(false);
 
@@ -46,14 +46,14 @@ export const ShareButton = ({ token, documentId }: ShareButtonProps) => {
   };
 
   const onCopyClick = async () => {
-    const copyToClipboardValue = shareLink
-      ? `${window.location.origin}/share/${shareLink.slug}`
-      : {
-          token,
-          documentId,
-        };
-
-    await copyShareLink(copyToClipboardValue);
+    if (shareLink) {
+      await copyShareLink(`${window.location.origin}/share/${shareLink.slug}`);
+    } else {
+      await createAndCopyShareLink({
+        token,
+        documentId,
+      });
+    }
 
     setIsOpen(false);
   };
diff --git a/packages/lib/client-only/hooks/use-copy-share-link.ts b/packages/lib/client-only/hooks/use-copy-share-link.ts
index 8f5e36e05..754b21851 100644
--- a/packages/lib/client-only/hooks/use-copy-share-link.ts
+++ b/packages/lib/client-only/hooks/use-copy-share-link.ts
@@ -12,23 +12,27 @@ export function useCopyShareLink() {
   const { mutateAsync: createOrGetShareLink, isLoading: isCreatingShareLink } =
     trpc.shareLink.createOrGetShareLink.useMutation();
 
+  /**
+   * Copy a newly created, or pre-existing share link to the user's clipboard.
+   *
+   * @param payload The payload to create or get a share link.
+   */
+  const createAndCopyShareLink = async (payload: TCreateOrGetShareLinkMutationSchema) => {
+    const valueToCopy = createOrGetShareLink(payload).then(
+      (result) => `${window.location.origin}/share/${result.slug}`,
+    );
+
+    await copyShareLink(valueToCopy);
+  };
+
   /**
    * Copy a share link to the user's clipboard.
    *
-   * Will create or get a share link if one is not provided.
-   *
-   * @param payload Either the share link itself or the input to create a new share link.
+   * @param shareLink Either the share link itself or a promise that returns a shared link.
    */
-  const copyShareLink = async (payload: TCreateOrGetShareLinkMutationSchema | string) => {
-    const valueToCopy =
-      typeof payload === 'string'
-        ? payload
-        : createOrGetShareLink(payload).then(
-            (result) => `${window.location.origin}/share/${result.slug}`,
-          );
-
+  const copyShareLink = async (shareLink: Promise<string> | string) => {
     try {
-      const isCopySuccess = await copyToClipboard(valueToCopy);
+      const isCopySuccess = await copyToClipboard(shareLink);
       if (!isCopySuccess) {
         throw new Error('Copy to clipboard failed');
       }
@@ -48,7 +52,8 @@ export function useCopyShareLink() {
   };
 
   return {
-    isCopyingShareLink: isCreatingShareLink,
+    createAndCopyShareLink,
     copyShareLink,
+    isCopyingShareLink: isCreatingShareLink,
   };
 }