From 805982f3e85b26b164d933fec37ef6c8101070ef Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Mon, 10 Nov 2025 11:42:57 +1100 Subject: [PATCH] fix: envelope cc issues (#2158) --- .../dialogs/envelope-distribute-dialog.tsx | 2 +- .../document-signing-page-view-v2.tsx | 4 ++-- .../envelope-editor-fields-page-renderer.tsx | 5 +++-- .../envelope-editor-recipient-form.tsx | 2 +- packages/lib/utils/envelope.ts | 13 ++++++++++--- packages/ui/primitives/tooltip.tsx | 2 +- 6 files changed, 18 insertions(+), 10 deletions(-) diff --git a/apps/remix/app/components/dialogs/envelope-distribute-dialog.tsx b/apps/remix/app/components/dialogs/envelope-distribute-dialog.tsx index f9ca72f5e..92529bea2 100644 --- a/apps/remix/app/components/dialogs/envelope-distribute-dialog.tsx +++ b/apps/remix/app/components/dialogs/envelope-distribute-dialog.tsx @@ -336,7 +336,7 @@ export const EnvelopeDistributeDialog = ({ Message{' '} (Optional) - + diff --git a/apps/remix/app/components/general/document-signing/document-signing-page-view-v2.tsx b/apps/remix/app/components/general/document-signing/document-signing-page-view-v2.tsx index 5b0c30102..717da476c 100644 --- a/apps/remix/app/components/general/document-signing/document-signing-page-view-v2.tsx +++ b/apps/remix/app/components/general/document-signing/document-signing-page-view-v2.tsx @@ -184,10 +184,10 @@ export const DocumentSigningPageViewV2 = () => { )} -
+
{/* Footer of left sidebar. */} {!isEmbed && ( -
+
diff --git a/apps/remix/app/components/general/envelope-editor/envelope-editor-recipient-form.tsx b/apps/remix/app/components/general/envelope-editor/envelope-editor-recipient-form.tsx index 375524e68..18e0d077e 100644 --- a/apps/remix/app/components/general/envelope-editor/envelope-editor-recipient-form.tsx +++ b/apps/remix/app/components/general/envelope-editor/envelope-editor-recipient-form.tsx @@ -212,7 +212,7 @@ export const EnvelopeEditorRecipientForm = () => { ); const hasDocumentBeenSent = recipients.some( - (recipient) => recipient.sendStatus === SendStatus.SENT, + (recipient) => recipient.role !== RecipientRole.CC && recipient.sendStatus === SendStatus.SENT, ); const canRecipientBeModified = (recipientId?: number) => { diff --git a/packages/lib/utils/envelope.ts b/packages/lib/utils/envelope.ts index e78df82d2..f686ae2c8 100644 --- a/packages/lib/utils/envelope.ts +++ b/packages/lib/utils/envelope.ts @@ -1,5 +1,11 @@ import type { Envelope, Recipient } from '@prisma/client'; -import { DocumentStatus, EnvelopeType, SendStatus, SigningStatus } from '@prisma/client'; +import { + DocumentStatus, + EnvelopeType, + RecipientRole, + SendStatus, + SigningStatus, +} from '@prisma/client'; import { match } from 'ts-pattern'; import { z } from 'zod'; @@ -156,8 +162,9 @@ export const canEnvelopeItemsBeModified = ( if ( recipients.some( (recipient) => - recipient.signingStatus === SigningStatus.SIGNED || - recipient.sendStatus === SendStatus.SENT, + recipient.role !== RecipientRole.CC && + (recipient.signingStatus === SigningStatus.SIGNED || + recipient.sendStatus === SendStatus.SENT), ) ) { return false; diff --git a/packages/ui/primitives/tooltip.tsx b/packages/ui/primitives/tooltip.tsx index 5daa4dbaa..f68599cd4 100644 --- a/packages/ui/primitives/tooltip.tsx +++ b/packages/ui/primitives/tooltip.tsx @@ -19,7 +19,7 @@ const TooltipContent = React.forwardRef< ref={ref} sideOffset={sideOffset} className={cn( - 'bg-popover text-popover-foreground animate-in fade-in-50 data-[side=bottom]:slide-in-from-top-1 data-[side=left]:slide-in-from-right-1 data-[side=right]:slide-in-from-left-1 data-[side=top]:slide-in-from-bottom-1 z-50 overflow-hidden rounded-md border px-3 py-1.5 text-sm shadow-md', + 'bg-popover z-9999 text-popover-foreground animate-in fade-in-50 data-[side=bottom]:slide-in-from-top-1 data-[side=left]:slide-in-from-right-1 data-[side=right]:slide-in-from-left-1 data-[side=top]:slide-in-from-bottom-1 overflow-hidden rounded-md border px-3 py-1.5 text-sm shadow-md', className, )} {...props}