From 8083e54625c9ac7d0c1fde4c14cb31e7b18719a6 Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Mon, 24 Nov 2025 19:33:56 +1100 Subject: [PATCH] fix: remove redundant step --- .../internal/execute-webhook.handler.ts | 92 +++++++++---------- 1 file changed, 45 insertions(+), 47 deletions(-) diff --git a/packages/lib/jobs/definitions/internal/execute-webhook.handler.ts b/packages/lib/jobs/definitions/internal/execute-webhook.handler.ts index a357ea51f..2e1799d70 100644 --- a/packages/lib/jobs/definitions/internal/execute-webhook.handler.ts +++ b/packages/lib/jobs/definitions/internal/execute-webhook.handler.ts @@ -22,53 +22,51 @@ export const run = async ({ const { webhookUrl: url, secret } = webhook; - await io.runTask('execute-webhook', async () => { - const payloadData = { - event, - payload: data, - createdAt: new Date().toISOString(), - webhookEndpoint: url, - }; + const payloadData = { + event, + payload: data, + createdAt: new Date().toISOString(), + webhookEndpoint: url, + }; - const response = await fetch(url, { - method: 'POST', - body: JSON.stringify(payloadData), - headers: { - 'Content-Type': 'application/json', - 'X-Documenso-Secret': secret ?? '', - }, - }); - - const body = await response.text(); - - let responseBody: Prisma.InputJsonValue | Prisma.JsonNullValueInput = Prisma.JsonNull; - - try { - responseBody = JSON.parse(body); - } catch (err) { - responseBody = body; - } - - await prisma.webhookCall.create({ - data: { - url, - event, - status: response.ok ? WebhookCallStatus.SUCCESS : WebhookCallStatus.FAILED, - requestBody: payloadData as Prisma.InputJsonValue, - responseCode: response.status, - responseBody, - responseHeaders: Object.fromEntries(response.headers.entries()), - webhookId: webhook.id, - }, - }); - - if (!response.ok) { - throw new Error(`Webhook execution failed with status ${response.status}`); - } - - return { - success: response.ok, - status: response.status, - }; + const response = await fetch(url, { + method: 'POST', + body: JSON.stringify(payloadData), + headers: { + 'Content-Type': 'application/json', + 'X-Documenso-Secret': secret ?? '', + }, }); + + const body = await response.text(); + + let responseBody: Prisma.InputJsonValue | Prisma.JsonNullValueInput = Prisma.JsonNull; + + try { + responseBody = JSON.parse(body); + } catch (err) { + responseBody = body; + } + + await prisma.webhookCall.create({ + data: { + url, + event, + status: response.ok ? WebhookCallStatus.SUCCESS : WebhookCallStatus.FAILED, + requestBody: payloadData as Prisma.InputJsonValue, + responseCode: response.status, + responseBody, + responseHeaders: Object.fromEntries(response.headers.entries()), + webhookId: webhook.id, + }, + }); + + if (!response.ok) { + throw new Error(`Webhook execution failed with status ${response.status}`); + } + + return { + success: response.ok, + status: response.status, + }; };