Ryan/documenso
1
0
Fork 1
mirror of https://github.com/documenso/documenso.git synced 2025-11-20 11:41:44 +10:00
Code Issues Packages Projects Releases Wiki Activity

chore: self-review pr

Browse Source
This commit is contained in:
Catalin Pit
2025-02-10 16:47:07 +02:00
parent f325a04cb5
commit 8619eec67a
2 changed files with 9 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
packages/lib/server-only/recipient/set-template-recipients.ts
View File

@ -101,15 +101,10 @@ export const setTemplateRecipients = async ({
}, },
}); });
const removedRecipients = existingRecipients.filter((existingRecipient) => { const removedRecipients = existingRecipients.filter(
// Keep direct template recipients from being removed (existingRecipient) =>
if (template.directLink?.directTemplateRecipientId === existingRecipient.id) { !normalizedRecipients.find((recipient) => recipient.id === existingRecipient.id),
return false; );
}
// Check if this recipient still exists in the normalized recipients
return !normalizedRecipients.some((recipient) => recipient.id === existingRecipient.id);
});
if (template.directLink !== null) { if (template.directLink !== null) {
const updatedDirectRecipient = recipients.find( const updatedDirectRecipient = recipients.find(
@ -134,24 +129,11 @@ export const setTemplateRecipients = async ({
} }
const linkedRecipients = normalizedRecipients.map((recipient) => { const linkedRecipients = normalizedRecipients.map((recipient) => {
// For direct template recipients, match by ID only const existing = existingRecipients.find(
if (template.directLink?.directTemplateRecipientId === recipient.id) { (existingRecipient) => existingRecipient.id === recipient.id,
const existing = existingRecipients.find( );
(existingRecipient) => existingRecipient.id === recipient.id,
);
return { ...recipient, _persisted: existing };
}
// For other recipients, match by ID if it exists return { ...recipient, _persisted: existing };
if (recipient.id) {
const existing = existingRecipients.find(
(existingRecipient) => existingRecipient.id === recipient.id,
);
return { ...recipient, _persisted: existing };
}
// For new recipients, create a new entry
return { ...recipient, _persisted: undefined };
}); });
const persistedRecipients = await prisma.$transaction(async (tx) => { const persistedRecipients = await prisma.$transaction(async (tx) => {

1
packages/lib/server-only/template/create-document-from-template.ts
View File

@ -260,6 +260,7 @@ export const createDocumentFromTemplate = async ({
template.recipients.forEach((templateRecipient, index) => { template.recipients.forEach((templateRecipient, index) => {
const documentRecipient = document.recipients[index]; const documentRecipient = document.recipients[index];
if (documentRecipient) { if (documentRecipient) {
recipientMapping.set(templateRecipient.id, documentRecipient.id); recipientMapping.set(templateRecipient.id, documentRecipient.id);
} }