chore: self-review pr

This commit is contained in:
Catalin Pit
2025-02-10 16:47:07 +02:00
parent f325a04cb5
commit 8619eec67a
2 changed files with 9 additions and 26 deletions

View File

@ -101,15 +101,10 @@ export const setTemplateRecipients = async ({
},
});
const removedRecipients = existingRecipients.filter((existingRecipient) => {
// Keep direct template recipients from being removed
if (template.directLink?.directTemplateRecipientId === existingRecipient.id) {
return false;
}
// Check if this recipient still exists in the normalized recipients
return !normalizedRecipients.some((recipient) => recipient.id === existingRecipient.id);
});
const removedRecipients = existingRecipients.filter(
(existingRecipient) =>
!normalizedRecipients.find((recipient) => recipient.id === existingRecipient.id),
);
if (template.directLink !== null) {
const updatedDirectRecipient = recipients.find(
@ -134,24 +129,11 @@ export const setTemplateRecipients = async ({
}
const linkedRecipients = normalizedRecipients.map((recipient) => {
// For direct template recipients, match by ID only
if (template.directLink?.directTemplateRecipientId === recipient.id) {
const existing = existingRecipients.find(
(existingRecipient) => existingRecipient.id === recipient.id,
);
return { ...recipient, _persisted: existing };
}
// For other recipients, match by ID if it exists
if (recipient.id) {
const existing = existingRecipients.find(
(existingRecipient) => existingRecipient.id === recipient.id,
);
return { ...recipient, _persisted: existing };
}
// For new recipients, create a new entry
return { ...recipient, _persisted: undefined };
});
const persistedRecipients = await prisma.$transaction(async (tx) => {

View File

@ -260,6 +260,7 @@ export const createDocumentFromTemplate = async ({
template.recipients.forEach((templateRecipient, index) => {
const documentRecipient = document.recipients[index];
if (documentRecipient) {
recipientMapping.set(templateRecipient.id, documentRecipient.id);
}