Merge pull request #323 from documenso/feat/promise-safety

feat: promise safety

packages/email/transports/mailchannels.ts

@@ -110,9 +110,10 @@ export class MailChannelsTransport implements Transport<SentMessageInfo> {
           });
         }
 
-        res.json().then((data) => {
-          return callback(new Error(`MailChannels error: ${data.message}`), null);
-        });
+        res
+          .json()
+          .then((data) => callback(new Error(`MailChannels error: ${data.message}`), null))
+          .catch((err) => callback(err, null));
       })
       .catch((err) => {
         return callback(err, null);

packages/eslint-config/index.cjs

@@ -19,6 +19,8 @@ module.exports = {
   parser: '@typescript-eslint/parser',
 
   parserOptions: {
+    tsconfigRootDir: __dirname,
+    project: ['../../apps/*/tsconfig.json', '../../packages/*/tsconfig.json'],
     ecmaVersion: 2022,
     ecmaFeatures: {
       jsx: true,
@@ -32,6 +34,18 @@ module.exports = {
     'no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
     '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
 
+    // Safety with promises so we aren't running with scissors
+    'no-promise-executor-return': 'error',
+    'prefer-promise-reject-errors': 'error',
+    'require-atomic-updates': 'error',
+    '@typescript-eslint/no-floating-promises': 'error',
+    '@typescript-eslint/no-misused-promises': [
+      'error',
+      { checksVoidReturn: { attributes: false } },
+    ],
+    '@typescript-eslint/promise-function-async': 'error',
+    '@typescript-eslint/require-await': 'error',
+
     // We never want to use `as` but are required to on occasion to handle
     // shortcomings in third-party and generated types.
     //

packages/eslint-config/tsconfig.json

@@ -0,0 +1,9 @@
+{
+  "extends": "@documenso/tsconfig/base.json",
+  "compilerOptions": {
+    "allowJs": true,
+    "noEmit": true,
+  },
+  "include": ["**/*.cjs", "**/*.js"],
+  "exclude": ["dist", "build", "node_modules"]
+}

packages/lib/next-auth/auth-options.ts

@@ -89,7 +89,7 @@ export const NEXT_AUTH_OPTIONS: AuthOptions = {
       };
     },
 
-    async session({ token, session }) {
+    session({ token, session }) {
       if (token && token.email) {
         return {
           ...session,

packages/lib/next-auth/get-server-session.ts

@@ -1,9 +1,6 @@
 import { GetServerSidePropsContext, NextApiRequest, NextApiResponse } from 'next';
-import { headers } from 'next/headers';
-import { NextRequest } from 'next/server';
 
 import { getServerSession as getNextAuthServerSession } from 'next-auth';
-import { getToken } from 'next-auth/jwt';
 
 import { prisma } from '@documenso/prisma';
 
@@ -30,18 +27,6 @@ export const getServerSession = async ({ req, res }: GetServerSessionOptions) =>
   return user;
 };
 
-export const getServerComponentToken = async () => {
-  const requestHeaders = Object.fromEntries(headers().entries());
-
-  const req = new NextRequest('http://example.com', {
-    headers: requestHeaders,
-  });
-
-  const token = await getToken({
-    req,
-  });
-};
-
 export const getServerComponentSession = async () => {
   const session = await getNextAuthServerSession(NEXT_AUTH_OPTIONS);
 

packages/lib/server-only/document/complete-document-with-token.ts

@@ -87,6 +87,6 @@ export const completeDocumentWithToken = async ({
 
   if (documents.count > 0) {
     console.log('sealing document');
-    sealDocument({ documentId: document.id });
+    await sealDocument({ documentId: document.id });
   }
 };

packages/tailwind-config/tsconfig.json

@@ -0,0 +1,9 @@
+{
+  "extends": "@documenso/tsconfig/base.json",
+  "compilerOptions": {
+    "allowJs": true,
+    "noEmit": true,
+  },
+  "include": ["**/*.cjs", "**/*.js"],
+  "exclude": ["dist", "build", "node_modules"]
+}

packages/trpc/server/trpc.ts

@@ -10,7 +10,7 @@ const t = initTRPC.context<TrpcContext>().create({
 /**
  * Middlewares
  */
-export const authenticatedMiddleware = t.middleware(({ ctx, next }) => {
+export const authenticatedMiddleware = t.middleware(async ({ ctx, next }) => {
   if (!ctx.session) {
     throw new TRPCError({
       code: 'UNAUTHORIZED',
@@ -18,7 +18,7 @@ export const authenticatedMiddleware = t.middleware(({ ctx, next }) => {
     });
   }
 
-  return next({
+  return await next({
     ctx: {
       ...ctx,
 

packages/tsconfig/tsconfig.json

@@ -0,0 +1,8 @@
+{
+  "extends": "./base.json",
+  "compilerOptions": {
+    "noEmit": true,
+  },
+  "include": ["**/*.ts", "**/*.tsx", "**/*.d.ts", "**/*.json"],
+  "exclude": ["dist", "build", "node_modules"]
+}

packages/ui/primitives/document-dropzone.tsx

@@ -86,7 +86,7 @@ export const DocumentDropzone = ({ className, onDrop, ...props }: DocumentDropzo
     multiple: false,
     onDrop: ([acceptedFile]) => {
       if (acceptedFile && onDrop) {
-        onDrop(acceptedFile);
+        void onDrop(acceptedFile);
       }
     },
   });

packages/ui/primitives/document-flow/add-fields.tsx

@@ -88,6 +88,8 @@ export const AddFieldsFormPartial = ({
     },
   });
 
+  const onFormSubmit = handleSubmit(onSubmit);
+
   const {
     append,
     remove,
@@ -500,7 +502,7 @@ export const AddFieldsFormPartial = ({
           loading={isSubmitting}
           disabled={isSubmitting}
           onGoBackClick={documentFlow.onBackStep}
-          onGoNextClick={() => handleSubmit(onSubmit)()}
+          onGoNextClick={() => void onFormSubmit()}
         />
       </DocumentFlowFormContainerFooter>
     </>

packages/ui/primitives/document-flow/add-signers.tsx

@@ -68,6 +68,8 @@ export const AddSignersFormPartial = ({
     },
   });
 
+  const onFormSubmit = handleSubmit(onSubmit);
+
   const {
     append: appendSigner,
     fields: signers,
@@ -214,7 +216,7 @@ export const AddSignersFormPartial = ({
           loading={isSubmitting}
           disabled={isSubmitting}
           onGoBackClick={documentFlow.onBackStep}
-          onGoNextClick={() => handleSubmit(onSubmit)()}
+          onGoNextClick={() => void onFormSubmit()}
         />
       </DocumentFlowFormContainerFooter>
     </>

packages/ui/primitives/document-flow/add-subject.tsx

@@ -47,6 +47,8 @@ export const AddSubjectFormPartial = ({
     },
   });
 
+  const onFormSubmit = handleSubmit(onSubmit);
+
   return (
     <>
       <DocumentFlowFormContainerContent>
@@ -130,7 +132,7 @@ export const AddSubjectFormPartial = ({
           disabled={isSubmitting}
           goNextLabel={document.status === DocumentStatus.DRAFT ? 'Send' : 'Update'}
           onGoBackClick={documentFlow.onBackStep}
-          onGoNextClick={() => handleSubmit(onSubmit)()}
+          onGoNextClick={() => void onFormSubmit()}
         />
       </DocumentFlowFormContainerFooter>
     </>

packages/ui/primitives/pdf-viewer.tsx

@@ -66,7 +66,7 @@ export const PDFViewer = ({ className, document, onPageClick, ...props }: PDFVie
     const pageY = event.clientY - top;
 
     if (onPageClick) {
-      onPageClick({
+      void onPageClick({
         pageNumber,
         numPages,
         originalEvent: event,

packages/ui/primitives/signature-pad/canvas.ts

@@ -302,8 +302,8 @@ export class Canvas {
   /**
    * Retrieves the signature as an image blob.
    */
-  public toBlob(type?: string, quality?: number): Promise<Blob> {
-    return new Promise((resolve, reject) => {
+  public async toBlob(type?: string, quality?: number): Promise<Blob> {
+    const promise = new Promise<Blob>((resolve, reject) => {
       this.$canvas.toBlob(
         (blob) => {
           if (!blob) {
@@ -317,5 +317,7 @@ export class Canvas {
         quality,
       );
     });
+
+    return await promise;
   }
 }