fix: add regression test

packages/trpc/server/envelope-router/attachment/create-attachment.ts

@@ -13,7 +13,7 @@ export const createAttachmentRoute = authenticatedProcedure
       path: '/envelope/attachment/create',
       summary: 'Create attachment',
       description: 'Create a new attachment for an envelope',
-      tags: ['Envelope'],
+      tags: ['Envelope Attachment'],
     },
   })
   .input(ZCreateAttachmentRequestSchema)

packages/trpc/server/envelope-router/attachment/delete-attachment.ts

@@ -13,7 +13,7 @@ export const deleteAttachmentRoute = authenticatedProcedure
       path: '/envelope/attachment/delete',
       summary: 'Delete attachment',
       description: 'Delete an attachment from an envelope',
-      tags: ['Envelope'],
+      tags: ['Envelope Attachment'],
     },
   })
   .input(ZDeleteAttachmentRequestSchema)

packages/trpc/server/envelope-router/attachment/find-attachments.ts

@@ -2,20 +2,20 @@ import { AppError, AppErrorCode } from '@documenso/lib/errors/app-error';
 import { findAttachmentsByEnvelopeId } from '@documenso/lib/server-only/envelope-attachment/find-attachments-by-envelope-id';
 import { findAttachmentsByToken } from '@documenso/lib/server-only/envelope-attachment/find-attachments-by-token';
 
-import { procedure } from '../../trpc';
+import { maybeAuthenticatedProcedure } from '../../trpc';
 import {
   ZFindAttachmentsRequestSchema,
   ZFindAttachmentsResponseSchema,
 } from './find-attachments.types';
 
-export const findAttachmentsRoute = procedure
+export const findAttachmentsRoute = maybeAuthenticatedProcedure
   .meta({
     openapi: {
       method: 'GET',
       path: '/envelope/attachment',
       summary: 'Find attachments',
       description: 'Find all attachments for an envelope',
-      tags: ['Envelope'],
+      tags: ['Envelope Attachment'],
     },
   })
   .input(ZFindAttachmentsRequestSchema)

packages/trpc/server/envelope-router/attachment/update-attachment.ts

@@ -13,7 +13,7 @@ export const updateAttachmentRoute = authenticatedProcedure
       path: '/envelope/attachment/update',
       summary: 'Update attachment',
       description: 'Update an existing attachment',
-      tags: ['Envelope'],
+      tags: ['Envelope Attachment'],
     },
   })
   .input(ZUpdateAttachmentRequestSchema)

packages/trpc/server/envelope-router/create-envelope-items.ts

@@ -14,15 +14,15 @@ import {
 
 export const createEnvelopeItemsRoute = authenticatedProcedure
   // Todo: Envelopes - Pending direct uploads
-  // .meta({
-  //   openapi: {
-  //     method: 'POST',
-  //     path: '/envelope/item/create-many',
-  //     summary: 'Create envelope items',
-  //     description: 'Create multiple envelope items for an envelope',
-  //     tags: ['Envelope Item'],
-  //   },
-  // })
+  .meta({
+    openapi: {
+      method: 'POST',
+      path: '/envelope/item/create-many',
+      summary: 'Create envelope items',
+      description: 'Create multiple envelope items for an envelope',
+      tags: ['Envelope Item'],
+    },
+  })
   .input(ZCreateEnvelopeItemsRequestSchema)
   .output(ZCreateEnvelopeItemsResponseSchema)
   .mutation(async ({ input, ctx }) => {

packages/trpc/server/envelope-router/envelope-fields/create-envelope-fields.types.ts

@@ -2,8 +2,8 @@ import { z } from 'zod';
 
 import {
   ZClampedFieldHeightSchema,
-  ZClampedFieldPageXSchema,
-  ZClampedFieldPageYSchema,
+  ZClampedFieldPositionXSchema,
+  ZClampedFieldPositionYSchema,
   ZClampedFieldWidthSchema,
   ZFieldPageNumberSchema,
   ZFieldSchema,
@@ -19,9 +19,9 @@ const ZCreateFieldSchema = ZFieldAndMetaSchema.and(
       .describe(
         'The ID of the envelope item to put the field on. If not provided, field will be placed on the first item.',
       ),
-    pageNumber: ZFieldPageNumberSchema,
-    pageX: ZClampedFieldPageXSchema,
-    pageY: ZClampedFieldPageYSchema,
+    page: ZFieldPageNumberSchema,
+    positionX: ZClampedFieldPositionXSchema,
+    positionY: ZClampedFieldPositionYSchema,
     width: ZClampedFieldWidthSchema,
     height: ZClampedFieldHeightSchema,
   }),

packages/trpc/server/envelope-router/envelope-fields/update-envelope-fields.types.ts

@@ -2,8 +2,8 @@ import { z } from 'zod';
 
 import {
   ZClampedFieldHeightSchema,
-  ZClampedFieldPageXSchema,
-  ZClampedFieldPageYSchema,
+  ZClampedFieldPositionXSchema,
+  ZClampedFieldPositionYSchema,
   ZClampedFieldWidthSchema,
   ZFieldPageNumberSchema,
   ZFieldSchema,
@@ -19,9 +19,9 @@ const ZUpdateFieldSchema = ZFieldAndMetaSchema.and(
       .describe(
         'The ID of the envelope item to put the field on. If not provided, field will be placed on the first item.',
       ),
-    pageNumber: ZFieldPageNumberSchema.optional(),
-    pageX: ZClampedFieldPageXSchema.optional(),
-    pageY: ZClampedFieldPageYSchema.optional(),
+    page: ZFieldPageNumberSchema.optional(),
+    positionX: ZClampedFieldPositionXSchema.optional(),
+    positionY: ZClampedFieldPositionYSchema.optional(),
     width: ZClampedFieldWidthSchema.optional(),
     height: ZClampedFieldHeightSchema.optional(),
   }),

packages/trpc/server/envelope-router/router.ts

@@ -27,14 +27,18 @@ import { signEnvelopeFieldRoute } from './sign-envelope-field';
 import { updateEnvelopeRoute } from './update-envelope';
 import { updateEnvelopeItemsRoute } from './update-envelope-items';
 
+/**
+ * Note: The order of the routes is important for public API routes.
+ *
+ * Example: GET /envelope/attachment must appear before GET /envelope/:id
+ */
 export const envelopeRouter = router({
-  get: getEnvelopeRoute,
-  create: createEnvelopeRoute,
-  update: updateEnvelopeRoute,
-  delete: deleteEnvelopeRoute,
-  duplicate: duplicateEnvelopeRoute,
-  distribute: distributeEnvelopeRoute,
-  redistribute: redistributeEnvelopeRoute,
+  attachment: {
+    find: findAttachmentsRoute,
+    create: createAttachmentRoute,
+    update: updateAttachmentRoute,
+    delete: deleteAttachmentRoute,
+  },
   item: {
     getMany: getEnvelopeItemsRoute,
     getManyByToken: getEnvelopeItemsByTokenRoute,
@@ -57,10 +61,11 @@ export const envelopeRouter = router({
     set: setEnvelopeFieldsRoute,
     sign: signEnvelopeFieldRoute,
   },
-  attachment: {
-    find: findAttachmentsRoute,
-    create: createAttachmentRoute,
-    update: updateAttachmentRoute,
-    delete: deleteAttachmentRoute,
-  },
+  get: getEnvelopeRoute,
+  create: createEnvelopeRoute,
+  update: updateEnvelopeRoute,
+  delete: deleteEnvelopeRoute,
+  duplicate: duplicateEnvelopeRoute,
+  distribute: distributeEnvelopeRoute,
+  redistribute: redistributeEnvelopeRoute,
 });

packages/trpc/server/envelope-router/set-envelope-fields.types.ts

@@ -3,8 +3,8 @@ import { z } from 'zod';
 
 import {
   ZClampedFieldHeightSchema,
-  ZClampedFieldPageXSchema,
-  ZClampedFieldPageYSchema,
+  ZClampedFieldPositionXSchema,
+  ZClampedFieldPositionYSchema,
   ZClampedFieldWidthSchema,
 } from '@documenso/lib/types/field';
 import { ZFieldMetaSchema } from '@documenso/lib/types/field-meta';
@@ -26,8 +26,8 @@ export const ZSetEnvelopeFieldsRequestSchema = z.object({
         .number()
         .min(1)
         .describe('The page number of the field on the envelope. Starts from 1.'),
-      positionX: ZClampedFieldPageXSchema,
-      positionY: ZClampedFieldPageYSchema,
+      positionX: ZClampedFieldPositionXSchema,
+      positionY: ZClampedFieldPositionYSchema,
       width: ZClampedFieldWidthSchema,
       height: ZClampedFieldHeightSchema,
       fieldMeta: ZFieldMetaSchema,