Ryan/documenso
1
0
Fork 1
mirror of https://github.com/documenso/documenso.git synced 2026-08-26 00:02:43 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix(templates): use defaults for zero pagination values

Browse Source
This commit is contained in:
ephraimduncan
2026-08-25 03:40:58 +00:00
parent 98c5db7d0d
commit a1e7ca0ce3
2 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/remix/app/routes/_authenticated+/t.$teamUrl+/templates._index.tsx
+6 -4
View File
@@ -41,6 +41,8 @@ export default function TemplatesPage() {
const [findTemplateSearchParams] = useQueryStates(templatesSearchParams, { const [findTemplateSearchParams] = useQueryStates(templatesSearchParams, {
history: 'push', history: 'push',
}); });
const page = findTemplateSearchParams.page || undefined;
const perPage = findTemplateSearchParams.perPage || undefined;
const isOrgView = findTemplateSearchParams.view === 'organisation'; const isOrgView = findTemplateSearchParams.view === 'organisation';
const showOrgFilter = organisation.type !== OrganisationType.PERSONAL; const showOrgFilter = organisation.type !== OrganisationType.PERSONAL;
@@ -62,8 +64,8 @@ export default function TemplatesPage() {
const teamTemplatesQuery = trpc.template.findTemplates.useQuery( const teamTemplatesQuery = trpc.template.findTemplates.useQuery(
{ {
page: findTemplateSearchParams.page ?? undefined, page,
perPage: findTemplateSearchParams.perPage ?? undefined, perPage,
folderId, folderId,
}, },
{ {
@@ -73,8 +75,8 @@ export default function TemplatesPage() {
const orgTemplatesQuery = trpc.template.findOrganisationTemplates.useQuery( const orgTemplatesQuery = trpc.template.findOrganisationTemplates.useQuery(
{ {
page: findTemplateSearchParams.page ?? undefined, page,
perPage: findTemplateSearchParams.perPage ?? undefined, perPage,
}, },
{ {
enabled: isOrgView, enabled: isOrgView,
packages/app-tests/e2e/templates/organisation-templates.spec.ts
+12
View File
@@ -149,6 +149,18 @@ test.describe('Organisation Templates - Listing', () => {
await expect(page.getByText(orgTemplate.title)).toBeVisible(); await expect(page.getByText(orgTemplate.title)).toBeVisible();
}); });
test('should use default pagination when URL values are zero', async ({ page }) => {
const { memberB, teamB, orgTemplate } = await seedOrgTemplateScenario();
await apiSignin({
page,
email: memberB.email,
redirectPath: `/t/${teamB.url}/templates?view=organisation&page=0&perPage=0`,
});
await expect(page.getByText(orgTemplate.title)).toBeVisible();
});
test('should not show private templates from other teams under the organisation view', async ({ page }) => { test('should not show private templates from other teams under the organisation view', async ({ page }) => {
const { ownerA, teamA, memberB, teamB } = await seedOrgTemplateScenario(); const { ownerA, teamA, memberB, teamB } = await seedOrgTemplateScenario();