feat: convert AI field placement to server-side processing

This commit is contained in:
Ephraim Atta-Duncan
2025-11-04 14:02:11 +00:00
parent cdfd373958
commit ac4b3737d6
6 changed files with 294 additions and 177 deletions

View File

@ -11,11 +11,7 @@ import { match } from 'ts-pattern';
import { useCurrentEnvelopeEditor } from '@documenso/lib/client-only/providers/envelope-editor-provider'; import { useCurrentEnvelopeEditor } from '@documenso/lib/client-only/providers/envelope-editor-provider';
import { useCurrentEnvelopeRender } from '@documenso/lib/client-only/providers/envelope-render-provider'; import { useCurrentEnvelopeRender } from '@documenso/lib/client-only/providers/envelope-render-provider';
import { import { getPageCanvasRefs } from '@documenso/lib/client-only/utils/page-canvas-registry';
compositePageToBlob,
getPageCanvasRefs,
getRegisteredPageNumbers,
} from '@documenso/lib/client-only/utils/page-canvas-registry';
import type { TDetectedFormField } from '@documenso/lib/types/ai'; import type { TDetectedFormField } from '@documenso/lib/types/ai';
import type { import type {
TCheckboxFieldMeta, TCheckboxFieldMeta,
@ -141,61 +137,49 @@ const enforceMinimumFieldDimensions = (params: {
}; };
const processAllPagesWithAI = async (params: { const processAllPagesWithAI = async (params: {
pageNumbers: number[]; documentDataId: string;
onProgress: (current: number, total: number) => void; onProgress: (current: number, total: number) => void;
}): Promise<{ }): Promise<{
fieldsPerPage: Map<number, TDetectedFormField[]>; fieldsPerPage: Map<number, TDetectedFormField[]>;
errors: Map<number, Error>; errors: Map<number, Error>;
}> => { }> => {
const { pageNumbers, onProgress } = params; const { documentDataId, onProgress } = params;
const fieldsPerPage = new Map<number, TDetectedFormField[]>(); const fieldsPerPage = new Map<number, TDetectedFormField[]>();
const errors = new Map<number, Error>(); const errors = new Map<number, Error>();
const results = await Promise.allSettled(
pageNumbers.map(async (pageNumber) => {
try { try {
const blob = await compositePageToBlob(pageNumber); // Make single API call to process all pages server-side
onProgress(0, 1);
if (!blob) {
throw new Error(`Failed to capture page ${pageNumber}`);
}
const formData = new FormData();
formData.append('image', blob, `page-${pageNumber}.png`);
const response = await fetch('/api/ai/detect-form-fields', { const response = await fetch('/api/ai/detect-form-fields', {
method: 'POST', method: 'POST',
body: formData, headers: {
'Content-Type': 'application/json',
},
body: JSON.stringify({ documentId: documentDataId }),
credentials: 'include', credentials: 'include',
}); });
if (!response.ok) { if (!response.ok) {
throw new Error(`AI detection failed for page ${pageNumber}: ${response.statusText}`); const errorText = await response.text();
throw new Error(`AI detection failed: ${response.statusText} - ${errorText}`);
} }
const detectedFields: TDetectedFormField[] = await response.json(); const detectedFields: TDetectedFormField[] = await response.json();
return { pageNumber, detectedFields }; // Group fields by page number
for (const field of detectedFields) {
if (!fieldsPerPage.has(field.pageNumber)) {
fieldsPerPage.set(field.pageNumber, []);
}
fieldsPerPage.get(field.pageNumber)!.push(field);
}
onProgress(1, 1);
} catch (error) { } catch (error) {
throw { pageNumber, error }; // If request fails, treat it as error for all pages
errors.set(0, error instanceof Error ? error : new Error(String(error)));
} }
}),
);
let completedCount = 0;
results.forEach((result) => {
completedCount++;
onProgress(completedCount, pageNumbers.length);
if (result.status === 'fulfilled') {
const { pageNumber, detectedFields } = result.value;
fieldsPerPage.set(pageNumber, detectedFields);
} else {
const { pageNumber, error } = result.reason;
errors.set(pageNumber, error instanceof Error ? error : new Error(String(error)));
}
});
return { fieldsPerPage, errors }; return { fieldsPerPage, errors };
}; };
@ -373,19 +357,17 @@ export const EnvelopeEditorFieldsPage = () => {
return; return;
} }
const pageNumbers = getRegisteredPageNumbers(); if (!currentEnvelopeItem.documentDataId) {
if (pageNumbers.length === 0) {
toast({ toast({
title: t`Error`, title: t`Error`,
description: t`No pages found. Please ensure the document is fully loaded.`, description: t`Document data not found. Please try reloading the page.`,
variant: 'destructive', variant: 'destructive',
}); });
return; return;
} }
const { fieldsPerPage, errors } = await processAllPagesWithAI({ const { fieldsPerPage, errors } = await processAllPagesWithAI({
pageNumbers, documentDataId: currentEnvelopeItem.documentDataId,
onProgress: (current, total) => { onProgress: (current, total) => {
setProcessingProgress({ current, total }); setProcessingProgress({ current, total });
}, },
@ -444,7 +426,7 @@ export const EnvelopeEditorFieldsPage = () => {
if (totalAdded > 0) { if (totalAdded > 0) {
let description = t`Added ${totalAdded} fields`; let description = t`Added ${totalAdded} fields`;
if (pageNumbers.length > 1) { if (fieldsPerPage.size > 1) {
description = t`Added ${totalAdded} fields across ${successfulPages} pages`; description = t`Added ${totalAdded} fields across ${successfulPages} pages`;
} }
if (failedPages > 0) { if (failedPages > 0) {

View File

@ -1,13 +1,41 @@
// sort-imports-ignore
// ---- PATCH pdfjs-dist's canvas require BEFORE importing it ----
import { createRequire } from 'module';
import { fileURLToPath } from 'url';
import { Canvas, Image } from 'skia-canvas';
const require = createRequire(import.meta.url || fileURLToPath(new URL('.', import.meta.url)));
const Module = require('module');
const originalRequire = Module.prototype.require;
Module.prototype.require = function (path: string) {
if (path === 'canvas') {
return {
createCanvas: (width: number, height: number) => new Canvas(width, height),
Image, // needed by pdfjs-dist
};
}
// eslint-disable-next-line prefer-rest-params, @typescript-eslint/consistent-type-assertions
return originalRequire.apply(this, arguments as unknown as [string]);
};
// Use dynamic require to bypass Vite SSR transformation
// eslint-disable-next-line @typescript-eslint/no-var-requires
const pdfjsLib = require('pdfjs-dist/legacy/build/pdf.js');
import { generateObject } from 'ai'; import { generateObject } from 'ai';
import { mkdir, writeFile } from 'fs/promises'; import { mkdir, writeFile } from 'fs/promises';
import { Hono } from 'hono'; import { Hono } from 'hono';
import { join } from 'path'; import { join } from 'path';
import sharp from 'sharp'; import sharp from 'sharp';
import { Canvas, Image } from 'skia-canvas';
import { getSession } from '@documenso/auth/server/lib/utils/get-session'; import { getSession } from '@documenso/auth/server/lib/utils/get-session';
import { AppError, AppErrorCode } from '@documenso/lib/errors/app-error'; import { AppError, AppErrorCode } from '@documenso/lib/errors/app-error';
import { getTeamById } from '@documenso/lib/server-only/team/get-team';
import { getFileServerSide } from '@documenso/lib/universal/upload/get-file.server';
import { env } from '@documenso/lib/utils/env'; import { env } from '@documenso/lib/utils/env';
import { prisma } from '@documenso/prisma';
import type { HonoEnv } from '../router'; import type { HonoEnv } from '../router';
import { import {
@ -16,12 +44,46 @@ import {
ZDetectedFormFieldSchema, ZDetectedFormFieldSchema,
} from './ai.types'; } from './ai.types';
/** const renderPdfToImage = async (pdfBytes: Uint8Array) => {
* Resize and compress image for better Gemini API accuracy. const loadingTask = pdfjsLib.getDocument({ data: pdfBytes });
* Resizes to max width of 1000px (maintaining aspect ratio) and compresses to JPEG at 70% quality. const pdf = await loadingTask.promise;
* This preprocessing improves bounding box detection accuracy.
*/ try {
async function resizeAndCompressImage(imageBuffer: Buffer): Promise<Buffer> { const scale = 4;
const pages = await Promise.all(
Array.from({ length: pdf.numPages }, async (_, index) => {
const pageNumber = index + 1;
const page = await pdf.getPage(pageNumber);
try {
const viewport = page.getViewport({ scale });
const virtualCanvas = new Canvas(viewport.width, viewport.height);
const context = virtualCanvas.getContext('2d');
context.imageSmoothingEnabled = false;
await page.render({ canvasContext: context, viewport }).promise;
return {
image: await virtualCanvas.toBuffer('png'),
pageNumber,
width: Math.floor(viewport.width),
height: Math.floor(viewport.height),
};
} finally {
page.cleanup();
}
}),
);
return pages;
} finally {
await pdf.destroy();
}
};
const resizeAndCompressImage = async (imageBuffer: Buffer): Promise<Buffer> => {
const metadata = await sharp(imageBuffer).metadata(); const metadata = await sharp(imageBuffer).metadata();
const originalWidth = metadata.width || 0; const originalWidth = metadata.width || 0;
@ -33,7 +95,7 @@ async function resizeAndCompressImage(imageBuffer: Buffer): Promise<Buffer> {
} }
return await sharp(imageBuffer).jpeg({ quality: 70 }).toBuffer(); return await sharp(imageBuffer).jpeg({ quality: 70 }).toBuffer();
} };
const detectObjectsPrompt = `You are analyzing a form document image to detect fillable fields for the Documenso document signing platform. const detectObjectsPrompt = `You are analyzing a form document image to detect fillable fields for the Documenso document signing platform.
@ -115,7 +177,10 @@ When detecting thin horizontal lines for SIGNATURE, INITIALS, NAME, EMAIL, DATE,
- Expanded field: [ymin=420, xmin=200, ymax=500, xmax=600] (creates 80-unit tall field) - Expanded field: [ymin=420, xmin=200, ymax=500, xmax=600] (creates 80-unit tall field)
- This gives comfortable signing space while respecting the form layout`; - This gives comfortable signing space while respecting the form layout`;
const runFormFieldDetection = async (imageBuffer: Buffer): Promise<TDetectFormFieldsResponse> => { const runFormFieldDetection = async (
imageBuffer: Buffer,
pageNumber: number,
): Promise<TDetectFormFieldsResponse> => {
const compressedImageBuffer = await resizeAndCompressImage(imageBuffer); const compressedImageBuffer = await resizeAndCompressImage(imageBuffer);
const base64Image = compressedImageBuffer.toString('base64'); const base64Image = compressedImageBuffer.toString('base64');
@ -140,79 +205,147 @@ const runFormFieldDetection = async (imageBuffer: Buffer): Promise<TDetectFormFi
], ],
}); });
return result.object; return result.object.map((field) => ({
...field,
pageNumber,
}));
}; };
export const aiRoute = new Hono<HonoEnv>().post('/detect-form-fields', async (c) => { export const aiRoute = new Hono<HonoEnv>().post('/detect-form-fields', async (c) => {
try { try {
await getSession(c.req.raw); const { user } = await getSession(c.req.raw);
const parsedBody = await c.req.parseBody(); const body = await c.req.json();
const rawImage = parsedBody.image; const parsed = ZDetectFormFieldsRequestSchema.safeParse(body);
const imageCandidate = Array.isArray(rawImage) ? rawImage[0] : rawImage;
const parsed = ZDetectFormFieldsRequestSchema.safeParse({ image: imageCandidate });
if (!parsed.success) { if (!parsed.success) {
throw new AppError(AppErrorCode.INVALID_REQUEST, { throw new AppError(AppErrorCode.INVALID_REQUEST, {
message: 'Image file is required', message: 'Document ID is required',
userMessage: 'Please upload a valid image file.', userMessage: 'Please provide a valid document ID.',
}); });
} }
const imageBuffer = Buffer.from(await parsed.data.image.arrayBuffer()); const { documentId } = parsed.data;
const metadata = await sharp(imageBuffer).metadata();
const imageWidth = metadata.width;
const imageHeight = metadata.height;
if (!imageWidth || !imageHeight) { const documentData = await prisma.documentData.findUnique({
throw new AppError(AppErrorCode.INVALID_REQUEST, { where: { id: documentId },
message: 'Unable to extract image dimensions', include: {
userMessage: 'The image file appears to be invalid or corrupted.', envelopeItem: {
include: {
envelope: {
select: {
userId: true,
teamId: true,
},
},
},
},
},
});
if (!documentData || !documentData.envelopeItem) {
throw new AppError(AppErrorCode.NOT_FOUND, {
message: `Document data not found: ${documentId}`,
userMessage: 'The requested document does not exist.',
}); });
} }
const detectedFields = await runFormFieldDetection(imageBuffer); const envelope = documentData.envelopeItem.envelope;
const isDirectOwner = envelope.userId === user.id;
let hasTeamAccess = false;
if (envelope.teamId) {
try {
await getTeamById({ teamId: envelope.teamId, userId: user.id });
hasTeamAccess = true;
} catch (error) {
hasTeamAccess = false;
}
}
if (!isDirectOwner && !hasTeamAccess) {
throw new AppError(AppErrorCode.UNAUTHORIZED, {
message: `User ${user.id} does not have access to document ${documentId}`,
userMessage: 'You do not have permission to access this document.',
});
}
const pdfBytes = await getFileServerSide({
type: documentData.type,
data: documentData.initialData || documentData.data,
});
const renderedPages = await renderPdfToImage(pdfBytes);
const results = await Promise.allSettled(
renderedPages.map(async (page) => {
return await runFormFieldDetection(page.image, page.pageNumber);
}),
);
const detectedFields: TDetectFormFieldsResponse = [];
for (const [index, result] of results.entries()) {
if (result.status === 'fulfilled') {
detectedFields.push(...result.value);
} else {
const pageNumber = renderedPages[index]?.pageNumber ?? index + 1;
console.error(`Failed to detect fields on page ${pageNumber}:`, result.reason);
}
}
if (env('NEXT_PUBLIC_AI_DEBUG_PREVIEW') === 'true') { if (env('NEXT_PUBLIC_AI_DEBUG_PREVIEW') === 'true') {
const debugDir = join(process.cwd(), '..', '..', 'packages', 'assets', 'ai-previews');
await mkdir(debugDir, { recursive: true });
const now = new Date();
const timestamp = now
.toISOString()
.replace(/[-:]/g, '')
.replace(/\..+/, '')
.replace('T', '_');
for (const page of renderedPages) {
const padding = { left: 80, top: 20, right: 20, bottom: 40 }; const padding = { left: 80, top: 20, right: 20, bottom: 40 };
const canvas = new Canvas( const canvas = new Canvas(
imageWidth + padding.left + padding.right, page.width + padding.left + padding.right,
imageHeight + padding.top + padding.bottom, page.height + padding.top + padding.bottom,
); );
const ctx = canvas.getContext('2d'); const ctx = canvas.getContext('2d');
const img = new Image(); const img = new Image();
img.src = imageBuffer; img.src = page.image;
ctx.drawImage(img, padding.left, padding.top); ctx.drawImage(img, padding.left, padding.top);
ctx.strokeStyle = 'rgba(255, 0, 0, 0.5)'; ctx.strokeStyle = 'rgba(255, 0, 0, 0.5)';
ctx.lineWidth = 1; ctx.lineWidth = 1;
for (let i = 0; i <= 1000; i += 100) { for (let i = 0; i <= 1000; i += 100) {
const x = padding.left + (i / 1000) * imageWidth; const x = padding.left + (i / 1000) * page.width;
ctx.beginPath(); ctx.beginPath();
ctx.moveTo(x, padding.top); ctx.moveTo(x, padding.top);
ctx.lineTo(x, imageHeight + padding.top); ctx.lineTo(x, page.height + padding.top);
ctx.stroke(); ctx.stroke();
} }
for (let i = 0; i <= 1000; i += 100) { for (let i = 0; i <= 1000; i += 100) {
const y = padding.top + (i / 1000) * imageHeight; const y = padding.top + (i / 1000) * page.height;
ctx.beginPath(); ctx.beginPath();
ctx.moveTo(padding.left, y); ctx.moveTo(padding.left, y);
ctx.lineTo(imageWidth + padding.left, y); ctx.lineTo(page.width + padding.left, y);
ctx.stroke(); ctx.stroke();
} }
const colors = ['#FF0000', '#00FF00', '#0000FF', '#FFFF00', '#FF00FF', '#00FFFF']; const colors = ['#FF0000', '#00FF00', '#0000FF', '#FFFF00', '#FF00FF', '#00FFFF'];
detectedFields.forEach((field, index) => { const pageFields = detectedFields.filter((f) => f.pageNumber === page.pageNumber);
pageFields.forEach((field, index) => {
const [ymin, xmin, ymax, xmax] = field.boundingBox.map((coord) => coord / 1000); const [ymin, xmin, ymax, xmax] = field.boundingBox.map((coord) => coord / 1000);
const x = xmin * imageWidth + padding.left; const x = xmin * page.width + padding.left;
const y = ymin * imageHeight + padding.top; const y = ymin * page.height + padding.top;
const width = (xmax - xmin) * imageWidth; const width = (xmax - xmin) * page.width;
const height = (ymax - ymin) * imageHeight; const height = (ymax - ymin) * page.height;
ctx.strokeStyle = colors[index % colors.length]; ctx.strokeStyle = colors[index % colors.length];
ctx.lineWidth = 5; ctx.lineWidth = 5;
@ -229,13 +362,13 @@ export const aiRoute = new Hono<HonoEnv>().post('/detect-form-fields', async (c)
ctx.beginPath(); ctx.beginPath();
ctx.moveTo(padding.left, padding.top); ctx.moveTo(padding.left, padding.top);
ctx.lineTo(padding.left, imageHeight + padding.top); ctx.lineTo(padding.left, page.height + padding.top);
ctx.stroke(); ctx.stroke();
ctx.textAlign = 'right'; ctx.textAlign = 'right';
ctx.textBaseline = 'middle'; ctx.textBaseline = 'middle';
for (let i = 0; i <= 1000; i += 100) { for (let i = 0; i <= 1000; i += 100) {
const y = padding.top + (i / 1000) * imageHeight; const y = padding.top + (i / 1000) * page.height;
ctx.fillStyle = '#000000'; ctx.fillStyle = '#000000';
ctx.fillText(i.toString(), padding.left - 5, y); ctx.fillText(i.toString(), padding.left - 5, y);
@ -246,37 +379,29 @@ export const aiRoute = new Hono<HonoEnv>().post('/detect-form-fields', async (c)
} }
ctx.beginPath(); ctx.beginPath();
ctx.moveTo(padding.left, imageHeight + padding.top); ctx.moveTo(padding.left, page.height + padding.top);
ctx.lineTo(imageWidth + padding.left, imageHeight + padding.top); ctx.lineTo(page.width + padding.left, page.height + padding.top);
ctx.stroke(); ctx.stroke();
ctx.textAlign = 'center'; ctx.textAlign = 'center';
ctx.textBaseline = 'top'; ctx.textBaseline = 'top';
for (let i = 0; i <= 1000; i += 100) { for (let i = 0; i <= 1000; i += 100) {
const x = padding.left + (i / 1000) * imageWidth; const x = padding.left + (i / 1000) * page.width;
ctx.fillStyle = '#000000'; ctx.fillStyle = '#000000';
ctx.fillText(i.toString(), x, imageHeight + padding.top + 5); ctx.fillText(i.toString(), x, page.height + padding.top + 5);
ctx.beginPath(); ctx.beginPath();
ctx.moveTo(x, imageHeight + padding.top); ctx.moveTo(x, page.height + padding.top);
ctx.lineTo(x, imageHeight + padding.top + 5); ctx.lineTo(x, page.height + padding.top + 5);
ctx.stroke(); ctx.stroke();
} }
const now = new Date(); const outputFilename = `detected_form_fields_${timestamp}_page_${page.pageNumber}.png`;
const timestamp = now
.toISOString()
.replace(/[-:]/g, '')
.replace(/\..+/, '')
.replace('T', '_');
const outputFilename = `detected_form_fields_${timestamp}.png`;
const debugDir = join(process.cwd(), '..', '..', 'packages', 'assets', 'ai-previews');
const outputPath = join(debugDir, outputFilename); const outputPath = join(debugDir, outputFilename);
await mkdir(debugDir, { recursive: true });
const pngBuffer = await canvas.toBuffer('png'); const pngBuffer = await canvas.toBuffer('png');
await writeFile(outputPath, pngBuffer); await writeFile(outputPath, new Uint8Array(pngBuffer));
}
} }
return c.json<TDetectFormFieldsResponse>(detectedFields); return c.json<TDetectFormFieldsResponse>(detectedFields);
@ -285,8 +410,10 @@ export const aiRoute = new Hono<HonoEnv>().post('/detect-form-fields', async (c)
throw error; throw error;
} }
console.error('Failed to detect form fields from PDF:', error);
throw new AppError(AppErrorCode.UNKNOWN_ERROR, { throw new AppError(AppErrorCode.UNKNOWN_ERROR, {
message: 'Failed to detect form fields and generate preview', message: `Failed to detect form fields from PDF: ${error instanceof Error ? error.message : String(error)}`,
userMessage: 'An error occurred while detecting form fields. Please try again.', userMessage: 'An error occurred while detecting form fields. Please try again.',
}); });
} }

View File

@ -32,10 +32,15 @@ export const ZDetectedFormFieldSchema = z.object({
'DROPDOWN', 'DROPDOWN',
]) ])
.describe('Documenso field type inferred from nearby label text or visual characteristics'), .describe('Documenso field type inferred from nearby label text or visual characteristics'),
pageNumber: z
.number()
.int()
.positive()
.describe('1-indexed page number where field was detected'),
}); });
export const ZDetectFormFieldsRequestSchema = z.object({ export const ZDetectFormFieldsRequestSchema = z.object({
image: z.instanceof(Blob, { message: 'Image file is required' }), documentId: z.string().min(1, { message: 'Document ID is required' }),
}); });
export const ZDetectFormFieldsResponseSchema = z.array(ZDetectedFormFieldSchema); export const ZDetectFormFieldsResponseSchema = z.array(ZDetectedFormFieldSchema);

1
package-lock.json generated
View File

@ -36913,6 +36913,7 @@
"micro": "^10.0.1", "micro": "^10.0.1",
"nanoid": "^5.1.5", "nanoid": "^5.1.5",
"oslo": "^0.17.0", "oslo": "^0.17.0",
"pdfjs-dist": "3.11.174",
"pg": "^8.11.3", "pg": "^8.11.3",
"pino": "^9.7.0", "pino": "^9.7.0",
"pino-pretty": "^13.0.0", "pino-pretty": "^13.0.0",

View File

@ -43,6 +43,7 @@
"micro": "^10.0.1", "micro": "^10.0.1",
"nanoid": "^5.1.5", "nanoid": "^5.1.5",
"oslo": "^0.17.0", "oslo": "^0.17.0",
"pdfjs-dist": "3.11.174",
"pg": "^8.11.3", "pg": "^8.11.3",
"pino": "^9.7.0", "pino": "^9.7.0",
"pino-pretty": "^13.0.0", "pino-pretty": "^13.0.0",

View File

@ -11,4 +11,5 @@ export type TDetectedFormField = {
| 'RADIO' | 'RADIO'
| 'CHECKBOX' | 'CHECKBOX'
| 'DROPDOWN'; | 'DROPDOWN';
pageNumber: number;
}; };