fix: update types from code review

This commit is contained in:
Ephraim Atta-Duncan
2023-06-30 23:49:34 +00:00
parent 88d15376e3
commit b50f64d4ad
6 changed files with 19 additions and 14 deletions

View File

@ -7,8 +7,8 @@ import Link from 'next/link';
import { Loader } from 'lucide-react'; import { Loader } from 'lucide-react';
import { useUpdateSearchParams } from '@documenso/lib/client-only/hooks/use-update-search-params'; import { useUpdateSearchParams } from '@documenso/lib/client-only/hooks/use-update-search-params';
import { DocumentWithReciepient } from '@documenso/lib/types/document-with-recipient';
import { FindResultSet } from '@documenso/lib/types/find-result-set'; import { FindResultSet } from '@documenso/lib/types/find-result-set';
import { DocumentWithReciepient } from '@documenso/prisma/types/document-with-recipient';
import { DataTable } from '@documenso/ui/primitives/data-table'; import { DataTable } from '@documenso/ui/primitives/data-table';
import { DataTablePagination } from '@documenso/ui/primitives/data-table-pagination'; import { DataTablePagination } from '@documenso/ui/primitives/data-table-pagination';

View File

@ -1,5 +1,5 @@
import { initials } from '@documenso/lib/client-only/recipient-initials'; import { initials } from '@documenso/lib/client-only/recipient-initials';
import { type } from '@documenso/lib/client-only/recipient-type'; import { getRecipientType } from '@documenso/lib/client-only/recipient-type';
import { Recipient } from '@documenso/prisma/client'; import { Recipient } from '@documenso/prisma/client';
import { import {
Tooltip, Tooltip,
@ -40,7 +40,7 @@ export const StackAvatarsWithTooltip = ({ recipients }: { recipients: Recipient[
<StackAvatar <StackAvatar
first={true} first={true}
key={recipient.id} key={recipient.id}
type={type(recipient)} type={getRecipientType(recipient)}
fallbackText={initials(recipient.name)} fallbackText={initials(recipient.name)}
/> />
<span className="text-sm text-gray-500">{recipient.email}</span> <span className="text-sm text-gray-500">{recipient.email}</span>
@ -57,7 +57,7 @@ export const StackAvatarsWithTooltip = ({ recipients }: { recipients: Recipient[
<StackAvatar <StackAvatar
first={true} first={true}
key={recipient.id} key={recipient.id}
type={type(recipient)} type={getRecipientType(recipient)}
fallbackText={initials(recipient.name)} fallbackText={initials(recipient.name)}
/> />
<span className="text-sm text-gray-500">{recipient.email}</span> <span className="text-sm text-gray-500">{recipient.email}</span>
@ -74,7 +74,7 @@ export const StackAvatarsWithTooltip = ({ recipients }: { recipients: Recipient[
<StackAvatar <StackAvatar
first={true} first={true}
key={recipient.id} key={recipient.id}
type={type(recipient)} type={getRecipientType(recipient)}
fallbackText={initials(recipient.name)} fallbackText={initials(recipient.name)}
/> />
<span className="text-sm text-gray-500">{recipient.email}</span> <span className="text-sm text-gray-500">{recipient.email}</span>

View File

@ -1,7 +1,7 @@
import React from 'react'; import React from 'react';
import { initials } from '@documenso/lib/client-only/recipient-initials'; import { initials } from '@documenso/lib/client-only/recipient-initials';
import { type } from '@documenso/lib/client-only/recipient-type'; import { getRecipientType } from '@documenso/lib/client-only/recipient-type';
import { Recipient } from '@documenso/prisma/client'; import { Recipient } from '@documenso/prisma/client';
import { StackAvatar } from './stack-avatar'; import { StackAvatar } from './stack-avatar';
@ -25,7 +25,7 @@ export function StackAvatars({ recipients }: { recipients: Recipient[] }) {
key={recipient.id} key={recipient.id}
first={first} first={first}
zIndex={String(zIndex - index * 10)} zIndex={String(zIndex - index * 10)}
type={lastItemText && index === 4 ? 'unsigned' : type(recipient)} type={lastItemText && index === 4 ? 'unsigned' : getRecipientType(recipient)}
fallbackText={lastItemText ? lastItemText : initials(recipient.name)} fallbackText={lastItemText ? lastItemText : initials(recipient.name)}
/> />
); );

View File

@ -1,8 +1,13 @@
import { Recipient } from '@documenso/prisma/client'; import { Recipient } from '@documenso/prisma/client';
export const type = (recipient: Recipient) => export const getRecipientType = (recipient: Recipient) => {
recipient.sendStatus === 'SENT' && recipient.signingStatus === 'SIGNED' if (recipient.sendStatus === 'SENT' && recipient.signingStatus === 'SIGNED') {
? 'completed' return 'completed';
: recipient.sendStatus === 'SENT' && recipient.signingStatus === 'NOT_SIGNED' }
? 'waiting'
: 'unsigned'; if (recipient.sendStatus === 'SENT' && recipient.signingStatus === 'NOT_SIGNED') {
return 'waiting';
}
return 'unsigned';
};

View File

@ -1,7 +1,7 @@
import { prisma } from '@documenso/prisma'; import { prisma } from '@documenso/prisma';
import { Document, DocumentStatus, Prisma } from '@documenso/prisma/client'; import { Document, DocumentStatus, Prisma } from '@documenso/prisma/client';
import { DocumentWithReciepient } from '@documenso/prisma/types/document-with-recipient';
import { DocumentWithReciepient } from '../../types/document-with-recipient';
import { FindResultSet } from '../../types/find-result-set'; import { FindResultSet } from '../../types/find-result-set';
export interface FindDocumentsOptions { export interface FindDocumentsOptions {