Ryan/documenso
1
0
Fork 1
mirror of https://github.com/documenso/documenso.git synced 2026-07-26 09:54:51 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix(i18n): mark dropdown and radio placeholder for translation (#2537)

Browse Source
This commit is contained in:
Konrad
2026-03-06 03:05:03 +01:00
committed by GitHub
parent 6faa01d384
commit c63b4ca3cc
4 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/remix/app/components/forms/editor/editor-field-dropdown-form.tsx
+5 -5
View File
@@ -96,7 +96,7 @@ export const EditorFieldDropdownForm = ({
mode: 'onChange', mode: 'onChange',
defaultValues: { defaultValues: {
defaultValue: value.defaultValue, defaultValue: value.defaultValue,
values: value.values || [{ value: 'Option 1' }], values: [{ value: t`Option 1` }],
required: value.required || false, required: value.required || false,
readOnly: value.readOnly || false, readOnly: value.readOnly || false,
fontSize: value.fontSize || DEFAULT_FIELD_FONT_SIZE, fontSize: value.fontSize || DEFAULT_FIELD_FONT_SIZE,
@@ -110,13 +110,13 @@ export const EditorFieldDropdownForm = ({
const addValue = () => { const addValue = () => {
const currentValues = form.getValues('values') || []; const currentValues = form.getValues('values') || [];
let newValue = 'New option'; let newValue = t`New option`;
// Iterate to create a unique value // Iterate to create a unique value
for (let i = 0; i < currentValues.length; i++) { for (let i = 0; i < currentValues.length; i++) {
newValue = `New option ${i + 1}`; newValue = t`New option ${i + 1}`;
if (currentValues.some((item) => item.value === `New option ${i + 1}`)) { if (currentValues.some((item) => item.value === t`New option ${i + 1}`)) {
newValue = `New option ${i + 1}`; newValue = t`New option ${i + 1}`;
} else { } else {
break; break;
} }
apps/remix/app/components/forms/editor/editor-field-radio-form.tsx
+1 -1
View File
@@ -79,7 +79,7 @@ export const EditorFieldRadioForm = ({
mode: 'onChange', mode: 'onChange',
defaultValues: { defaultValues: {
label: value.label || '', label: value.label || '',
values: value.values || [{ id: 1, checked: false, value: 'Default value' }], values: value.values || [{ id: 1, checked: false, value: t`Default value` }],
required: value.required || false, required: value.required || false,
readOnly: value.readOnly || false, readOnly: value.readOnly || false,
direction: value.direction || 'vertical', direction: value.direction || 'vertical',
packages/ui/primitives/document-flow/field-items-advanced-settings/dropdown-field.tsx
+6 -6
View File
@@ -36,14 +36,14 @@ export const DropdownFieldAdvancedSettings = ({
const { _ } = useLingui(); const { _ } = useLingui();
const [showValidation, setShowValidation] = useState(false); const [showValidation, setShowValidation] = useState(false);
const [values, setValues] = useState(fieldState.values ?? [{ value: 'Option 1' }]); const [values, setValues] = useState(fieldState.values ?? [{ value: _(msg`Option 1`) }]);
const [readOnly, setReadOnly] = useState(fieldState.readOnly ?? false); const [readOnly, setReadOnly] = useState(fieldState.readOnly ?? false);
const [required, setRequired] = useState(fieldState.required ?? false); const [required, setRequired] = useState(fieldState.required ?? false);
const [defaultValue, setDefaultValue] = useState(fieldState.defaultValue ?? 'Option 1'); const [defaultValue, setDefaultValue] = useState(fieldState.defaultValue ?? _(msg`Option 1`));
const addValue = () => { const addValue = () => {
setValues([...values, { value: 'New option' }]); setValues([...values, { value: _(msg`New option`) }]);
handleFieldChange('values', [...values, { value: 'New option' }]); handleFieldChange('values', [...values, { value: _(msg`New option`) }]);
}; };
const removeValue = (index: number) => { const removeValue = (index: number) => {
@@ -90,11 +90,11 @@ export const DropdownFieldAdvancedSettings = ({
}, [values]); }, [values]);
useEffect(() => { useEffect(() => {
setValues(fieldState.values ?? [{ value: 'Option 1' }]); setValues(fieldState.values ?? [{ value: _(msg`Option 1`) }]);
}, [fieldState.values]); }, [fieldState.values]);
useEffect(() => { useEffect(() => {
setDefaultValue(fieldState.defaultValue ?? 'Option 1'); setDefaultValue(fieldState.defaultValue ?? _(msg`Option 1`));
}, [fieldState.defaultValue]); }, [fieldState.defaultValue]);
return ( return (
packages/ui/primitives/document-flow/field-items-advanced-settings/radio-field.tsx
+2 -2
View File
@@ -31,7 +31,7 @@ export const RadioFieldAdvancedSettings = ({
const [showValidation, setShowValidation] = useState(false); const [showValidation, setShowValidation] = useState(false);
const [values, setValues] = useState( const [values, setValues] = useState(
fieldState.values ?? [{ id: 1, checked: false, value: 'Default value' }], fieldState.values ?? [{ id: 1, checked: false, value: _(msg`Default value`) }],
); );
const [readOnly, setReadOnly] = useState(fieldState.readOnly ?? false); const [readOnly, setReadOnly] = useState(fieldState.readOnly ?? false);
const [required, setRequired] = useState(fieldState.required ?? false); const [required, setRequired] = useState(fieldState.required ?? false);
@@ -99,7 +99,7 @@ export const RadioFieldAdvancedSettings = ({
}; };
useEffect(() => { useEffect(() => {
setValues(fieldState.values ?? [{ id: 1, checked: false, value: 'Default value' }]); setValues(fieldState.values ?? [{ id: 1, checked: false, value: _(msg`Default value`) }]);
}, [fieldState.values]); }, [fieldState.values]);
useEffect(() => { useEffect(() => {