From daab8461c793868ab3efaeff5c320040a0a3b435 Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Tue, 21 Oct 2025 12:59:40 +1100 Subject: [PATCH] fix: email attachment names (#2085) --- .../lib/server-only/document/send-completed-email.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/lib/server-only/document/send-completed-email.ts b/packages/lib/server-only/document/send-completed-email.ts index bf4efa1d9..3b1f9547d 100644 --- a/packages/lib/server-only/document/send-completed-email.ts +++ b/packages/lib/server-only/document/send-completed-email.ts @@ -81,11 +81,15 @@ export const sendCompletedEmail = async ({ id, requestMetadata }: SendDocumentOp const { user: owner } = envelope; const completedDocumentEmailAttachments = await Promise.all( - envelope.envelopeItems.map(async (document) => { - const file = await getFileServerSide(document.documentData); + envelope.envelopeItems.map(async (envelopeItem) => { + const file = await getFileServerSide(envelopeItem.documentData); + + // Use the envelope title for version 1, and the envelope item title for version 2. + const fileNameToUse = + envelope.internalVersion === 1 ? envelope.title : envelopeItem.title + '.pdf'; return { - fileName: document.title.endsWith('.pdf') ? document.title : document.title + '.pdf', + filename: fileNameToUse.endsWith('.pdf') ? fileNameToUse : fileNameToUse + '.pdf', content: Buffer.from(file), contentType: 'application/pdf', };