From db4d33d0391d0766431c5e28c5ab2fd6333d8c83 Mon Sep 17 00:00:00 2001 From: Ephraim Atta-Duncan Date: Thu, 21 Aug 2025 21:58:14 +0000 Subject: [PATCH] chore: cleanup useEffect --- .../admin-organisation-create-dialog.tsx | 19 +++--- .../dialogs/document-delete-dialog.tsx | 21 +++--- .../document-move-to-folder-dialog.tsx | 23 ++++--- .../dialogs/folder-create-dialog.tsx | 11 +-- .../dialogs/folder-delete-dialog.tsx | 11 ++- .../components/dialogs/folder-move-dialog.tsx | 11 +-- .../dialogs/folder-update-dialog.tsx | 23 +++---- .../dialogs/organisation-create-dialog.tsx | 43 ++++++------ .../dialogs/organisation-delete-dialog.tsx | 15 +++-- .../organisation-email-create-dialog.tsx | 20 +++--- .../organisation-email-delete-dialog.tsx | 8 ++- ...rganisation-email-domain-create-dialog.tsx | 26 ++++--- .../organisation-email-update-dialog.tsx | 27 ++++---- .../organisation-group-create-dialog.tsx | 19 +++--- .../organisation-member-invite-dialog.tsx | 25 ++++--- .../organisation-member-update-dialog.tsx | 41 +++++------- .../dialogs/passkey-create-dialog.tsx | 19 +++--- .../components/dialogs/team-create-dialog.tsx | 37 +++++----- .../components/dialogs/team-delete-dialog.tsx | 13 ++-- .../dialogs/team-email-add-dialog.tsx | 17 +++-- .../dialogs/team-email-update-dialog.tsx | 17 +++-- .../dialogs/team-group-create-dialog.tsx | 20 ++++-- .../dialogs/team-group-update-dialog.tsx | 23 +++---- .../dialogs/team-member-create-dialog.tsx | 17 ++--- .../dialogs/team-member-update-dialog.tsx | 37 +++++----- .../dialogs/template-direct-link-dialog.tsx | 20 +++--- .../template-move-to-folder-dialog.tsx | 23 ++++--- .../dialogs/template-use-dialog.tsx | 13 ++-- .../dialogs/token-delete-dialog.tsx | 16 ++--- .../dialogs/webhook-delete-dialog.tsx | 13 ++-- .../embed/embed-document-waiting-for-turn.tsx | 14 +--- .../2fa/enable-authenticator-app-dialog.tsx | 19 +++--- apps/remix/app/components/forms/signin.tsx | 25 +++---- apps/remix/app/components/forms/signup.tsx | 25 +++---- .../document-signing-auto-sign.tsx | 21 +++--- .../document-signing-text-field.tsx | 35 +++++----- .../general/document/document-search.tsx | 15 ++--- .../general/verify-email-banner.tsx | 48 ++++++------- .../o.$orgUrl.settings.members.tsx | 33 +++++---- .../o.$orgUrl.settings.teams.tsx | 27 +++++--- .../_dynamic_personal_routes+/_layout.tsx | 9 +-- .../t.$teamUrl+/documents._index.tsx | 35 +++++----- .../t.$teamUrl+/settings.members.tsx | 35 ++++++---- .../t.$teamUrl+/settings.public-profile.tsx | 8 +-- .../_unauthenticated+/verify-email.$token.tsx | 67 ++++++++++++------- .../client-only/hooks/use-element-bounds.ts | 30 ++++----- .../hooks/use-element-scale-size.ts | 14 ++-- .../hooks/use-field-page-coords.ts | 36 +++++----- .../lib/client-only/hooks/use-is-mounted.ts | 22 +++--- packages/ui/components/client-only.tsx | 30 ++++++--- .../primitives/document-flow/add-fields.tsx | 42 ++++-------- .../field-item-advanced-settings.tsx | 34 ++++++---- .../signature-pad/signature-pad-draw.tsx | 6 +- .../signature-pad/signature-pad-upload.tsx | 7 +- .../template-flow/add-template-settings.tsx | 15 +---- 55 files changed, 637 insertions(+), 643 deletions(-) diff --git a/apps/remix/app/components/dialogs/admin-organisation-create-dialog.tsx b/apps/remix/app/components/dialogs/admin-organisation-create-dialog.tsx index 840a4bb5d..0813207ee 100644 --- a/apps/remix/app/components/dialogs/admin-organisation-create-dialog.tsx +++ b/apps/remix/app/components/dialogs/admin-organisation-create-dialog.tsx @@ -1,4 +1,4 @@ -import { useEffect, useState } from 'react'; +import { useState } from 'react'; import { zodResolver } from '@hookform/resolvers/zod'; import { useLingui } from '@lingui/react/macro'; @@ -96,16 +96,17 @@ export const AdminOrganisationCreateDialog = ({ } }; - useEffect(() => { - form.reset(); - }, [open, form]); + const handleOpenChange = (value: boolean) => { + if (!value) { + form.reset(); + } + if (!form.formState.isSubmitting) { + setOpen(value); + } + }; return ( - !form.formState.isSubmitting && setOpen(value)} - > + e.stopPropagation()} asChild={true}> {trigger ?? (