Ryan/documenso
1
0
Fork 1
mirror of https://github.com/documenso/documenso.git synced 2025-11-25 22:21:31 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix: optimize webhook routing (#2236)

Browse Source
This commit is contained in:
David Nguyen
2025-11-25 11:43:23 +11:00
committed by GitHub
parent 5df3932958
commit e364b08b6a
4 changed files with 60 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
apps/remix/app/routes/api+/webhook.trigger.ts
View File

@ -1,3 +1,4 @@
// Todo: [Webhooks] delete file after deployment.
import { handlerTriggerWebhooks } from '@documenso/lib/server-only/webhooks/trigger/handler'; import { handlerTriggerWebhooks } from '@documenso/lib/server-only/webhooks/trigger/handler';
import type { Route } from './+types/webhook.trigger'; import type { Route } from './+types/webhook.trigger';

2
packages/lib/jobs/definitions/internal/execute-webhook.handler.ts
View File

@ -22,7 +22,6 @@ export const run = async ({
const { webhookUrl: url, secret } = webhook; const { webhookUrl: url, secret } = webhook;
await io.runTask('execute-webhook', async () => {
const payloadData = { const payloadData = {
event, event,
payload: data, payload: data,
@ -70,5 +69,4 @@ export const run = async ({
success: response.ok, success: response.ok,
status: response.status, status: response.status,
}; };
});
}; };

1
packages/lib/server-only/webhooks/trigger/handler.ts
View File

@ -13,6 +13,7 @@ export type HandlerTriggerWebhooksResponse =
error: string; error: string;
}; };
// Todo: [Webhooks] delete after deployment.
export const handlerTriggerWebhooks = async (req: Request) => { export const handlerTriggerWebhooks = async (req: Request) => {
const signature = req.headers.get('x-webhook-signature'); const signature = req.headers.get('x-webhook-signature');

34
packages/lib/server-only/webhooks/trigger/trigger-webhook.ts
View File

@ -1,7 +1,6 @@
import type { WebhookTriggerEvents } from '@prisma/client'; import type { WebhookTriggerEvents } from '@prisma/client';
import { NEXT_PRIVATE_INTERNAL_WEBAPP_URL } from '../../../constants/app'; import { jobs } from '../../../jobs/client';
import { sign } from '../../crypto/sign';
import { getAllWebhooksByEventTrigger } from '../get-all-webhooks-by-event-trigger'; import { getAllWebhooksByEventTrigger } from '../get-all-webhooks-by-event-trigger';
export type TriggerWebhookOptions = { export type TriggerWebhookOptions = {
@ -13,35 +12,26 @@ export type TriggerWebhookOptions = {
export const triggerWebhook = async ({ event, data, userId, teamId }: TriggerWebhookOptions) => { export const triggerWebhook = async ({ event, data, userId, teamId }: TriggerWebhookOptions) => {
try { try {
const body = {
event,
data,
userId,
teamId,
};
const registeredWebhooks = await getAllWebhooksByEventTrigger({ event, userId, teamId }); const registeredWebhooks = await getAllWebhooksByEventTrigger({ event, userId, teamId });
if (registeredWebhooks.length === 0) { if (registeredWebhooks.length === 0) {
return; return;
} }
const signature = sign(body); await Promise.allSettled(
registeredWebhooks.map(async (webhook) => {
await Promise.race([ await jobs.triggerJob({
fetch(`${NEXT_PRIVATE_INTERNAL_WEBAPP_URL()}/api/webhook/trigger`, { name: 'internal.execute-webhook',
method: 'POST', payload: {
headers: { event,
'content-type': 'application/json', webhookId: webhook.id,
'x-webhook-signature': signature, data,
}, },
body: JSON.stringify(body), });
}), }),
new Promise((_, reject) => { );
setTimeout(() => reject(new Error('Request timeout')), 500);
}),
]).catch(() => null);
} catch (err) { } catch (err) {
console.error(err);
throw new Error(`Failed to trigger webhook`); throw new Error(`Failed to trigger webhook`);
} }
}; };