From 01caa949d9b7f9ba0118a84c1bc46895cbe72daa Mon Sep 17 00:00:00 2001 From: Adithya Krishna Date: Tue, 19 Dec 2023 22:20:50 +0530 Subject: [PATCH 1/4] feat: show document title for delete dialog Signed-off-by: Adithya Krishna --- .../app/(dashboard)/documents/data-table-action-dropdown.tsx | 1 + .../src/app/(dashboard)/documents/delete-document-dialog.tsx | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx b/apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx index 9c3532f88..ee5552f8c 100644 --- a/apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx +++ b/apps/web/src/app/(dashboard)/documents/data-table-action-dropdown.tsx @@ -164,6 +164,7 @@ export const DataTableActionDropdown = ({ row }: DataTableActionDropdownProps) = diff --git a/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx b/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx index 5b4a84286..8de13bffe 100644 --- a/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx +++ b/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx @@ -21,6 +21,7 @@ type DeleteDraftDocumentDialogProps = { open: boolean; onOpenChange: (_open: boolean) => void; status: DocumentStatus; + documentTitle: string; }; export const DeleteDocumentDialog = ({ @@ -28,6 +29,7 @@ export const DeleteDocumentDialog = ({ open, onOpenChange, status, + documentTitle, }: DeleteDraftDocumentDialogProps) => { const router = useRouter(); @@ -42,7 +44,7 @@ export const DeleteDocumentDialog = ({ toast({ title: 'Document deleted', - description: 'Your document has been successfully deleted.', + description: `Your document '${documentTitle} has been successfully deleted.`, duration: 5000, }); From 1af909835dc373e1405d03a939be91848a15e2b8 Mon Sep 17 00:00:00 2001 From: Adithya Krishna Date: Tue, 19 Dec 2023 22:25:23 +0530 Subject: [PATCH 2/4] chore: updated title to double quotes Signed-off-by: Adithya Krishna --- .../src/app/(dashboard)/documents/delete-document-dialog.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx b/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx index 8de13bffe..11560aa21 100644 --- a/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx +++ b/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx @@ -44,7 +44,7 @@ export const DeleteDocumentDialog = ({ toast({ title: 'Document deleted', - description: `Your document '${documentTitle} has been successfully deleted.`, + description: `Your document "${documentTitle}" has been successfully deleted.`, duration: 5000, }); From 84a0c3981008794d4f7791a7951c636436e62975 Mon Sep 17 00:00:00 2001 From: Adithya Krishna Date: Wed, 20 Dec 2023 10:36:06 +0530 Subject: [PATCH 3/4] chore: made requested changes Signed-off-by: Adithya Krishna --- .../documents/delete-document-dialog.tsx | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx b/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx index 11560aa21..7b82f93bc 100644 --- a/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx +++ b/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx @@ -41,10 +41,16 @@ export const DeleteDocumentDialog = ({ const { mutateAsync: deleteDocument, isLoading } = trpcReact.document.deleteDocument.useMutation({ onSuccess: () => { router.refresh(); + const deletedFileToastDescription = ( +

+ Your document {documentTitle} has been + successfully deleted. +

+ ); toast({ title: 'Document deleted', - description: `Your document "${documentTitle}" has been successfully deleted.`, + description: deletedFileToastDescription, duration: 5000, }); @@ -74,7 +80,10 @@ export const DeleteDocumentDialog = ({ !isLoading && onOpenChange(value)}> - Do you want to delete this document? + + Do you want to delete the {documentTitle}{' '} + document? + Please note that this action is irreversible. Once confirmed, your document will be @@ -83,7 +92,7 @@ export const DeleteDocumentDialog = ({ {status !== DocumentStatus.DRAFT && ( -
+
Date: Fri, 22 Dec 2023 03:43:12 +0000 Subject: [PATCH 4/4] chore: update copy --- .../documents/delete-document-dialog.tsx | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx b/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx index 7b82f93bc..3914d65de 100644 --- a/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx +++ b/apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx @@ -41,16 +41,10 @@ export const DeleteDocumentDialog = ({ const { mutateAsync: deleteDocument, isLoading } = trpcReact.document.deleteDocument.useMutation({ onSuccess: () => { router.refresh(); - const deletedFileToastDescription = ( -

- Your document {documentTitle} has been - successfully deleted. -

- ); toast({ title: 'Document deleted', - description: deletedFileToastDescription, + description: `"${documentTitle}" has been successfully deleted`, duration: 5000, }); @@ -80,10 +74,7 @@ export const DeleteDocumentDialog = ({ !isLoading && onOpenChange(value)}> - - Do you want to delete the {documentTitle}{' '} - document? - + Are you sure you want to delete "{documentTitle}"? Please note that this action is irreversible. Once confirmed, your document will be