mirror of
https://github.com/documenso/documenso.git
synced 2025-11-15 01:01:49 +10:00
Compare commits
10 Commits
a08a77e98b
...
feat/unlin
| Author | SHA1 | Date | |
|---|---|---|---|
| bf6f09194d | |||
| 0bbd9aa9a1 | |||
| 5e8c3d5d92 | |||
| c97c2551db | |||
| 1863d990c8 | |||
| 38483bb88c | |||
| 9cbbdfb127 | |||
| fb6e2753df | |||
| a89c781b31 | |||
| 8b131e42c7 |
692
CODE_STYLE.md
692
CODE_STYLE.md
@ -1,692 +0,0 @@
|
|||||||
# Documenso Code Style Guide
|
|
||||||
|
|
||||||
This document captures the code style, patterns, and conventions used in the Documenso codebase. It covers both enforceable rules and subjective "taste" elements that make our code consistent and maintainable.
|
|
||||||
|
|
||||||
## Table of Contents
|
|
||||||
|
|
||||||
1. [General Principles](#general-principles)
|
|
||||||
2. [TypeScript Conventions](#typescript-conventions)
|
|
||||||
3. [Imports & Dependencies](#imports--dependencies)
|
|
||||||
4. [Functions & Methods](#functions--methods)
|
|
||||||
5. [React & Components](#react--components)
|
|
||||||
6. [Error Handling](#error-handling)
|
|
||||||
7. [Async/Await Patterns](#asyncawait-patterns)
|
|
||||||
8. [Whitespace & Formatting](#whitespace--formatting)
|
|
||||||
9. [Naming Conventions](#naming-conventions)
|
|
||||||
10. [Pattern Matching](#pattern-matching)
|
|
||||||
11. [Database & Prisma](#database--prisma)
|
|
||||||
12. [TRPC Patterns](#trpc-patterns)
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## General Principles
|
|
||||||
|
|
||||||
- **Functional over Object-Oriented**: Prefer functional programming patterns over classes
|
|
||||||
- **Explicit over Implicit**: Be explicit about types, return values, and error cases
|
|
||||||
- **Early Returns**: Use guard clauses and early returns to reduce nesting
|
|
||||||
- **Immutability**: Favor `const` over `let`; avoid mutation where possible
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## TypeScript Conventions
|
|
||||||
|
|
||||||
### Type Definitions
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Prefer `type` over `interface`
|
|
||||||
type CreateDocumentOptions = {
|
|
||||||
templateId: number;
|
|
||||||
userId: number;
|
|
||||||
recipients: Recipient[];
|
|
||||||
};
|
|
||||||
|
|
||||||
// ❌ Avoid interfaces unless absolutely necessary
|
|
||||||
interface CreateDocumentOptions {
|
|
||||||
templateId: number;
|
|
||||||
}
|
|
||||||
```
|
|
||||||
|
|
||||||
### Type Imports
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Use `type` keyword for type-only imports
|
|
||||||
import type { Document, Recipient } from '@prisma/client';
|
|
||||||
import { DocumentStatus } from '@prisma/client';
|
|
||||||
|
|
||||||
// Types in function signatures
|
|
||||||
export const findDocuments = async ({ userId, teamId }: FindDocumentsOptions) => {
|
|
||||||
// ...
|
|
||||||
};
|
|
||||||
```
|
|
||||||
|
|
||||||
### Inline Types for Function Parameters
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Extract inline types to named types
|
|
||||||
type FinalRecipient = Pick<Recipient, 'name' | 'email' | 'role' | 'authOptions'> & {
|
|
||||||
templateRecipientId: number;
|
|
||||||
fields: Field[];
|
|
||||||
};
|
|
||||||
|
|
||||||
const finalRecipients: FinalRecipient[] = [];
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Imports & Dependencies
|
|
||||||
|
|
||||||
### Import Organization
|
|
||||||
|
|
||||||
Imports should be organized in the following order with blank lines between groups:
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// 1. React imports
|
|
||||||
import { useCallback, useEffect, useMemo } from 'react';
|
|
||||||
|
|
||||||
// 2. Third-party library imports (alphabetically)
|
|
||||||
import { zodResolver } from '@hookform/resolvers/zod';
|
|
||||||
import { Trans } from '@lingui/react/macro';
|
|
||||||
import type { Document, Recipient } from '@prisma/client';
|
|
||||||
import { DocumentStatus, RecipientRole } from '@prisma/client';
|
|
||||||
import { match } from 'ts-pattern';
|
|
||||||
|
|
||||||
// 3. Internal package imports (from @documenso/*)
|
|
||||||
import { AppError } from '@documenso/lib/errors/app-error';
|
|
||||||
import { prisma } from '@documenso/prisma';
|
|
||||||
import { Button } from '@documenso/ui/primitives/button';
|
|
||||||
|
|
||||||
// 4. Relative imports
|
|
||||||
import { getTeamById } from '../team/get-team';
|
|
||||||
import type { FindResultResponse } from './types';
|
|
||||||
```
|
|
||||||
|
|
||||||
### Destructuring Imports
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Destructure specific exports
|
|
||||||
// ✅ Use type imports for types
|
|
||||||
import type { Document } from '@prisma/client';
|
|
||||||
|
|
||||||
import { Button } from '@documenso/ui/primitives/button';
|
|
||||||
import { Input } from '@documenso/ui/primitives/input';
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Functions & Methods
|
|
||||||
|
|
||||||
### Arrow Functions
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Always use arrow functions for functions
|
|
||||||
export const createDocument = async ({
|
|
||||||
userId,
|
|
||||||
title,
|
|
||||||
}: CreateDocumentOptions) => {
|
|
||||||
// ...
|
|
||||||
};
|
|
||||||
|
|
||||||
// ✅ Callbacks and handlers
|
|
||||||
const onSubmit = useCallback(async () => {
|
|
||||||
// ...
|
|
||||||
}, [dependencies]);
|
|
||||||
|
|
||||||
// ❌ Avoid regular function declarations
|
|
||||||
function createDocument() {
|
|
||||||
// ...
|
|
||||||
}
|
|
||||||
```
|
|
||||||
|
|
||||||
### Function Parameters
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Use destructured object parameters for multiple params
|
|
||||||
export const findDocuments = async ({
|
|
||||||
userId,
|
|
||||||
teamId,
|
|
||||||
status = ExtendedDocumentStatus.ALL,
|
|
||||||
page = 1,
|
|
||||||
perPage = 10,
|
|
||||||
}: FindDocumentsOptions) => {
|
|
||||||
// ...
|
|
||||||
};
|
|
||||||
|
|
||||||
// ✅ Destructure on separate line when needed
|
|
||||||
const onFormSubmit = form.handleSubmit(onSubmit);
|
|
||||||
|
|
||||||
// ✅ Deconstruct nested properties explicitly
|
|
||||||
const { user } = ctx;
|
|
||||||
const { templateId } = input;
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## React & Components
|
|
||||||
|
|
||||||
### Component Definition
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Use const with arrow function
|
|
||||||
export const AddSignersFormPartial = ({
|
|
||||||
documentFlow,
|
|
||||||
recipients,
|
|
||||||
fields,
|
|
||||||
onSubmit,
|
|
||||||
}: AddSignersFormProps) => {
|
|
||||||
// ...
|
|
||||||
};
|
|
||||||
|
|
||||||
// ❌ Never use classes
|
|
||||||
class MyComponent extends React.Component {
|
|
||||||
// ...
|
|
||||||
}
|
|
||||||
```
|
|
||||||
|
|
||||||
### Hooks
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Group related hooks together with blank line separation
|
|
||||||
const { _ } = useLingui();
|
|
||||||
const { toast } = useToast();
|
|
||||||
|
|
||||||
const { currentStep, totalSteps, previousStep } = useStep();
|
|
||||||
|
|
||||||
const form = useForm<TFormSchema>({
|
|
||||||
resolver: zodResolver(ZFormSchema),
|
|
||||||
defaultValues: {
|
|
||||||
// ...
|
|
||||||
},
|
|
||||||
});
|
|
||||||
```
|
|
||||||
|
|
||||||
### Event Handlers
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Use arrow functions with descriptive names
|
|
||||||
const onFormSubmit = async () => {
|
|
||||||
await form.trigger();
|
|
||||||
// ...
|
|
||||||
};
|
|
||||||
|
|
||||||
const onFieldCopy = useCallback(
|
|
||||||
(event?: KeyboardEvent | null) => {
|
|
||||||
event?.preventDefault();
|
|
||||||
// ...
|
|
||||||
},
|
|
||||||
[dependencies],
|
|
||||||
);
|
|
||||||
|
|
||||||
// ✅ Inline handlers for simple operations
|
|
||||||
<Button onClick={() => setOpen(false)}>Close</Button>
|
|
||||||
```
|
|
||||||
|
|
||||||
### State Management
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Descriptive state names with auxiliary verbs
|
|
||||||
const [isLoading, setIsLoading] = useState(false);
|
|
||||||
const [hasError, setHasError] = useState(false);
|
|
||||||
const [showAdvancedSettings, setShowAdvancedSettings] = useState(false);
|
|
||||||
|
|
||||||
// ✅ Complex state in single useState when related
|
|
||||||
const [coords, setCoords] = useState({
|
|
||||||
x: 0,
|
|
||||||
y: 0,
|
|
||||||
});
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Error Handling
|
|
||||||
|
|
||||||
### Try-Catch Blocks
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Use try-catch for operations that might fail
|
|
||||||
try {
|
|
||||||
const document = await getDocumentById({
|
|
||||||
documentId: Number(documentId),
|
|
||||||
userId: user.id,
|
|
||||||
});
|
|
||||||
|
|
||||||
return {
|
|
||||||
status: 200,
|
|
||||||
body: document,
|
|
||||||
};
|
|
||||||
} catch (err) {
|
|
||||||
return {
|
|
||||||
status: 404,
|
|
||||||
body: {
|
|
||||||
message: 'Document not found',
|
|
||||||
},
|
|
||||||
};
|
|
||||||
}
|
|
||||||
```
|
|
||||||
|
|
||||||
### Throwing Errors
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Use AppError for application errors
|
|
||||||
throw new AppError(AppErrorCode.NOT_FOUND, {
|
|
||||||
message: 'Template not found',
|
|
||||||
});
|
|
||||||
|
|
||||||
// ✅ Use descriptive error messages
|
|
||||||
if (!template) {
|
|
||||||
throw new AppError(AppErrorCode.NOT_FOUND, {
|
|
||||||
message: `Template with ID ${templateId} not found`,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
```
|
|
||||||
|
|
||||||
### Error Parsing on Frontend
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Parse errors on the frontend
|
|
||||||
try {
|
|
||||||
await updateOrganisation({ organisationId, data });
|
|
||||||
} catch (err) {
|
|
||||||
const error = AppError.parseError(err);
|
|
||||||
console.error(error);
|
|
||||||
|
|
||||||
toast({
|
|
||||||
title: t`An error occurred`,
|
|
||||||
description: error.message,
|
|
||||||
variant: 'destructive',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Async/Await Patterns
|
|
||||||
|
|
||||||
### Async Function Definitions
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Mark async functions clearly
|
|
||||||
export const createDocument = async ({
|
|
||||||
userId,
|
|
||||||
title,
|
|
||||||
}: Options): Promise<Document> => {
|
|
||||||
// ...
|
|
||||||
};
|
|
||||||
|
|
||||||
// ✅ Use await for promises
|
|
||||||
const document = await prisma.document.create({ data });
|
|
||||||
|
|
||||||
// ✅ Use Promise.all for parallel operations
|
|
||||||
const [document, recipients] = await Promise.all([
|
|
||||||
getDocumentById({ documentId }),
|
|
||||||
getRecipientsForDocument({ documentId }),
|
|
||||||
]);
|
|
||||||
```
|
|
||||||
|
|
||||||
### Void for Fire-and-Forget
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Use void for intentionally unwaited promises
|
|
||||||
void handleAutoSave();
|
|
||||||
|
|
||||||
// ✅ Or in event handlers
|
|
||||||
onClick={() => void onFormSubmit()}
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Whitespace & Formatting
|
|
||||||
|
|
||||||
### Blank Lines Between Concepts
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Blank line after imports
|
|
||||||
import { prisma } from '@documenso/prisma';
|
|
||||||
|
|
||||||
export const findDocuments = async () => {
|
|
||||||
// ...
|
|
||||||
};
|
|
||||||
|
|
||||||
// ✅ Blank line between logical sections
|
|
||||||
const user = await prisma.user.findFirst({ where: { id: userId } });
|
|
||||||
|
|
||||||
let team = null;
|
|
||||||
|
|
||||||
if (teamId !== undefined) {
|
|
||||||
team = await getTeamById({ userId, teamId });
|
|
||||||
}
|
|
||||||
|
|
||||||
// ✅ Blank line before return statements
|
|
||||||
const result = await someOperation();
|
|
||||||
|
|
||||||
return result;
|
|
||||||
```
|
|
||||||
|
|
||||||
### Function/Method Spacing
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ No blank lines between chained methods in same operation
|
|
||||||
const documents = await prisma.document
|
|
||||||
.findMany({ where: { userId } })
|
|
||||||
.then((docs) => docs.map(maskTokens));
|
|
||||||
|
|
||||||
// ✅ Blank line between different operations
|
|
||||||
const document = await createDocument({ userId });
|
|
||||||
|
|
||||||
await sendDocument({ documentId: document.id });
|
|
||||||
|
|
||||||
return document;
|
|
||||||
```
|
|
||||||
|
|
||||||
### Object and Array Formatting
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Multi-line when complex
|
|
||||||
const options = {
|
|
||||||
userId,
|
|
||||||
teamId,
|
|
||||||
status: ExtendedDocumentStatus.ALL,
|
|
||||||
page: 1,
|
|
||||||
};
|
|
||||||
|
|
||||||
// ✅ Single line when simple
|
|
||||||
const coords = { x: 0, y: 0 };
|
|
||||||
|
|
||||||
// ✅ Array items on separate lines when objects
|
|
||||||
const recipients = [
|
|
||||||
{
|
|
||||||
name: 'John',
|
|
||||||
email: 'john@example.com',
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: 'Jane',
|
|
||||||
email: 'jane@example.com',
|
|
||||||
},
|
|
||||||
];
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Naming Conventions
|
|
||||||
|
|
||||||
### Variables
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ camelCase for variables and functions
|
|
||||||
const documentId = 123;
|
|
||||||
const onSubmit = () => {};
|
|
||||||
|
|
||||||
// ✅ Descriptive names with auxiliary verbs for booleans
|
|
||||||
const isLoading = false;
|
|
||||||
const hasError = false;
|
|
||||||
const canEdit = true;
|
|
||||||
const shouldRender = true;
|
|
||||||
|
|
||||||
// ✅ Prefix with $ for DOM elements
|
|
||||||
const $page = document.querySelector('.page');
|
|
||||||
const $inputRef = useRef<HTMLInputElement>(null);
|
|
||||||
```
|
|
||||||
|
|
||||||
### Types and Schemas
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ PascalCase for types
|
|
||||||
type CreateDocumentOptions = {
|
|
||||||
userId: number;
|
|
||||||
};
|
|
||||||
|
|
||||||
// ✅ Prefix Zod schemas with Z
|
|
||||||
const ZCreateDocumentSchema = z.object({
|
|
||||||
title: z.string(),
|
|
||||||
});
|
|
||||||
|
|
||||||
// ✅ Prefix type from Zod schema with T
|
|
||||||
type TCreateDocumentSchema = z.infer<typeof ZCreateDocumentSchema>;
|
|
||||||
```
|
|
||||||
|
|
||||||
### Constants
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ UPPER_SNAKE_CASE for true constants
|
|
||||||
const DEFAULT_DOCUMENT_DATE_FORMAT = 'dd/MM/yyyy';
|
|
||||||
const MAX_FILE_SIZE = 1024 * 1024 * 5;
|
|
||||||
|
|
||||||
// ✅ camelCase for const variables that aren't "constants"
|
|
||||||
const userId = await getUserId();
|
|
||||||
```
|
|
||||||
|
|
||||||
### Functions
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Verb-based names for functions
|
|
||||||
const createDocument = async () => {};
|
|
||||||
const findDocuments = async () => {};
|
|
||||||
const updateDocument = async () => {};
|
|
||||||
const deleteDocument = async () => {};
|
|
||||||
|
|
||||||
// ✅ On prefix for event handlers
|
|
||||||
const onSubmit = () => {};
|
|
||||||
const onClick = () => {};
|
|
||||||
const onFieldCopy = () => {}; // 'on' is also acceptable
|
|
||||||
```
|
|
||||||
|
|
||||||
### Clarity Over Brevity
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Prefer descriptive names over abbreviations
|
|
||||||
const superLongMethodThatIsCorrect = () => {};
|
|
||||||
const recipientAuthenticationOptions = {};
|
|
||||||
const documentMetadata = {};
|
|
||||||
|
|
||||||
// ❌ Avoid abbreviations that sacrifice clarity
|
|
||||||
const supLongMethThatIsCorrect = () => {};
|
|
||||||
const recipAuthOpts = {};
|
|
||||||
const docMeta = {};
|
|
||||||
|
|
||||||
// ✅ Common abbreviations that are widely understood are acceptable
|
|
||||||
const userId = 123;
|
|
||||||
const htmlElement = document.querySelector('div');
|
|
||||||
const apiResponse = await fetch('/api');
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Pattern Matching
|
|
||||||
|
|
||||||
### Using ts-pattern
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
import { match } from 'ts-pattern';
|
|
||||||
|
|
||||||
// ✅ Use match for complex conditionals
|
|
||||||
const result = match(status)
|
|
||||||
.with(ExtendedDocumentStatus.DRAFT, () => ({
|
|
||||||
status: 'draft',
|
|
||||||
}))
|
|
||||||
.with(ExtendedDocumentStatus.PENDING, () => ({
|
|
||||||
status: 'pending',
|
|
||||||
}))
|
|
||||||
.with(ExtendedDocumentStatus.COMPLETED, () => ({
|
|
||||||
status: 'completed',
|
|
||||||
}))
|
|
||||||
.exhaustive();
|
|
||||||
|
|
||||||
// ✅ Use .otherwise() for default case when not exhaustive
|
|
||||||
const value = match(type)
|
|
||||||
.with('text', () => 'Text field')
|
|
||||||
.with('number', () => 'Number field')
|
|
||||||
.otherwise(() => 'Unknown field');
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Database & Prisma
|
|
||||||
|
|
||||||
### Query Structure
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Destructure commonly used fields
|
|
||||||
const { id, email, name } = user;
|
|
||||||
|
|
||||||
// ✅ Use select to limit returned fields
|
|
||||||
const user = await prisma.user.findFirst({
|
|
||||||
where: { id: userId },
|
|
||||||
select: {
|
|
||||||
id: true,
|
|
||||||
email: true,
|
|
||||||
name: true,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
// ✅ Use include for relations
|
|
||||||
const document = await prisma.document.findFirst({
|
|
||||||
where: { id: documentId },
|
|
||||||
include: {
|
|
||||||
recipients: true,
|
|
||||||
fields: true,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
```
|
|
||||||
|
|
||||||
### Transactions
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Use transactions for related operations
|
|
||||||
return await prisma.$transaction(async (tx) => {
|
|
||||||
const document = await tx.document.create({ data });
|
|
||||||
|
|
||||||
await tx.field.createMany({ data: fieldsData });
|
|
||||||
|
|
||||||
await tx.documentAuditLog.create({ data: auditData });
|
|
||||||
|
|
||||||
return document;
|
|
||||||
});
|
|
||||||
```
|
|
||||||
|
|
||||||
### Where Clauses
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Build complex where clauses separately
|
|
||||||
const whereClause: Prisma.DocumentWhereInput = {
|
|
||||||
AND: [
|
|
||||||
{ userId: user.id },
|
|
||||||
{ deletedAt: null },
|
|
||||||
{ status: { in: [DocumentStatus.DRAFT, DocumentStatus.PENDING] } },
|
|
||||||
],
|
|
||||||
};
|
|
||||||
|
|
||||||
const documents = await prisma.document.findMany({
|
|
||||||
where: whereClause,
|
|
||||||
});
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## TRPC Patterns
|
|
||||||
|
|
||||||
### Router Structure
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Destructure context and input at start
|
|
||||||
.query(async ({ input, ctx }) => {
|
|
||||||
const { teamId } = ctx;
|
|
||||||
const { templateId } = input;
|
|
||||||
|
|
||||||
ctx.logger.info({
|
|
||||||
input: { templateId },
|
|
||||||
});
|
|
||||||
|
|
||||||
return await getTemplateById({
|
|
||||||
id: templateId,
|
|
||||||
userId: ctx.user.id,
|
|
||||||
teamId,
|
|
||||||
});
|
|
||||||
});
|
|
||||||
```
|
|
||||||
|
|
||||||
### Request/Response Schemas
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Name schemas clearly
|
|
||||||
const ZCreateDocumentRequestSchema = z.object({
|
|
||||||
title: z.string(),
|
|
||||||
recipients: z.array(ZRecipientSchema),
|
|
||||||
});
|
|
||||||
|
|
||||||
const ZCreateDocumentResponseSchema = z.object({
|
|
||||||
documentId: z.number(),
|
|
||||||
status: z.string(),
|
|
||||||
});
|
|
||||||
```
|
|
||||||
|
|
||||||
### Error Handling in TRPC
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Catch and transform errors appropriately
|
|
||||||
try {
|
|
||||||
const result = await createDocument({ userId, data });
|
|
||||||
|
|
||||||
return result;
|
|
||||||
} catch (err) {
|
|
||||||
return AppError.toRestAPIError(err);
|
|
||||||
}
|
|
||||||
|
|
||||||
// ✅ Or throw AppError directly
|
|
||||||
if (!template) {
|
|
||||||
throw new AppError(AppErrorCode.NOT_FOUND, {
|
|
||||||
message: 'Template not found',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Additional Patterns
|
|
||||||
|
|
||||||
### Optional Chaining
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Use optional chaining for potentially undefined values
|
|
||||||
const email = user?.email;
|
|
||||||
const recipientToken = recipient?.token ?? '';
|
|
||||||
|
|
||||||
// ✅ Use nullish coalescing for defaults
|
|
||||||
const pageSize = perPage ?? 10;
|
|
||||||
const status = documentStatus ?? DocumentStatus.DRAFT;
|
|
||||||
```
|
|
||||||
|
|
||||||
### Array Operations
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Use functional array methods
|
|
||||||
const activeRecipients = recipients.filter((r) => r.signingStatus === 'SIGNED');
|
|
||||||
const recipientEmails = recipients.map((r) => r.email);
|
|
||||||
const hasSignedRecipients = recipients.some((r) => r.signingStatus === 'SIGNED');
|
|
||||||
|
|
||||||
// ✅ Use find instead of filter + [0]
|
|
||||||
const recipient = recipients.find((r) => r.id === recipientId);
|
|
||||||
```
|
|
||||||
|
|
||||||
### Conditional Rendering
|
|
||||||
|
|
||||||
```typescript
|
|
||||||
// ✅ Use && for conditional rendering
|
|
||||||
{isLoading && <Loader />}
|
|
||||||
|
|
||||||
// ✅ Use ternary for either/or
|
|
||||||
{isLoading ? <Loader /> : <Content />}
|
|
||||||
|
|
||||||
// ✅ Extract complex conditions to variables
|
|
||||||
const shouldShowAdvanced = isAdmin && hasPermission && !isDisabled;
|
|
||||||
{shouldShowAdvanced && <AdvancedSettings />}
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## When in Doubt
|
|
||||||
|
|
||||||
- **Consistency**: Follow the patterns you see in similar files
|
|
||||||
- **Readability**: Favor code that's easy to read over clever one-liners
|
|
||||||
- **Explicitness**: Be explicit rather than implicit
|
|
||||||
- **Whitespace**: Use blank lines to separate logical sections
|
|
||||||
- **Early Returns**: Use guard clauses to reduce nesting
|
|
||||||
- **Functional**: Prefer functional patterns over imperative ones
|
|
||||||
@ -1,218 +0,0 @@
|
|||||||
import { useEffect, useState } from 'react';
|
|
||||||
|
|
||||||
import { zodResolver } from '@hookform/resolvers/zod';
|
|
||||||
import { useLingui } from '@lingui/react/macro';
|
|
||||||
import { Trans } from '@lingui/react/macro';
|
|
||||||
import { OrganisationMemberRole } from '@prisma/client';
|
|
||||||
import type * as DialogPrimitive from '@radix-ui/react-dialog';
|
|
||||||
import { useForm } from 'react-hook-form';
|
|
||||||
import { useNavigate } from 'react-router';
|
|
||||||
import { match } from 'ts-pattern';
|
|
||||||
import { z } from 'zod';
|
|
||||||
|
|
||||||
import { getHighestOrganisationRoleInGroup } from '@documenso/lib/utils/organisations';
|
|
||||||
import { trpc } from '@documenso/trpc/react';
|
|
||||||
import type { TGetAdminOrganisationResponse } from '@documenso/trpc/server/admin-router/get-admin-organisation.types';
|
|
||||||
import { Button } from '@documenso/ui/primitives/button';
|
|
||||||
import {
|
|
||||||
Dialog,
|
|
||||||
DialogContent,
|
|
||||||
DialogDescription,
|
|
||||||
DialogFooter,
|
|
||||||
DialogHeader,
|
|
||||||
DialogTitle,
|
|
||||||
DialogTrigger,
|
|
||||||
} from '@documenso/ui/primitives/dialog';
|
|
||||||
import {
|
|
||||||
Form,
|
|
||||||
FormControl,
|
|
||||||
FormField,
|
|
||||||
FormItem,
|
|
||||||
FormLabel,
|
|
||||||
FormMessage,
|
|
||||||
} from '@documenso/ui/primitives/form/form';
|
|
||||||
import {
|
|
||||||
Select,
|
|
||||||
SelectContent,
|
|
||||||
SelectItem,
|
|
||||||
SelectTrigger,
|
|
||||||
SelectValue,
|
|
||||||
} from '@documenso/ui/primitives/select';
|
|
||||||
import { useToast } from '@documenso/ui/primitives/use-toast';
|
|
||||||
|
|
||||||
export type AdminOrganisationMemberUpdateDialogProps = {
|
|
||||||
trigger?: React.ReactNode;
|
|
||||||
organisationId: string;
|
|
||||||
organisationMember: TGetAdminOrganisationResponse['members'][number];
|
|
||||||
isOwner: boolean;
|
|
||||||
} & Omit<DialogPrimitive.DialogProps, 'children'>;
|
|
||||||
|
|
||||||
const ZUpdateOrganisationMemberFormSchema = z.object({
|
|
||||||
role: z.enum(['OWNER', 'ADMIN', 'MANAGER', 'MEMBER']),
|
|
||||||
});
|
|
||||||
|
|
||||||
type ZUpdateOrganisationMemberSchema = z.infer<typeof ZUpdateOrganisationMemberFormSchema>;
|
|
||||||
|
|
||||||
export const AdminOrganisationMemberUpdateDialog = ({
|
|
||||||
trigger,
|
|
||||||
organisationId,
|
|
||||||
organisationMember,
|
|
||||||
isOwner,
|
|
||||||
...props
|
|
||||||
}: AdminOrganisationMemberUpdateDialogProps) => {
|
|
||||||
const [open, setOpen] = useState(false);
|
|
||||||
|
|
||||||
const { t } = useLingui();
|
|
||||||
const { toast } = useToast();
|
|
||||||
const navigate = useNavigate();
|
|
||||||
|
|
||||||
// Determine the current role value for the form
|
|
||||||
const currentRoleValue = isOwner
|
|
||||||
? 'OWNER'
|
|
||||||
: getHighestOrganisationRoleInGroup(
|
|
||||||
organisationMember.organisationGroupMembers.map((ogm) => ogm.group),
|
|
||||||
);
|
|
||||||
const organisationMemberName = organisationMember.user.name ?? organisationMember.user.email;
|
|
||||||
|
|
||||||
const form = useForm<ZUpdateOrganisationMemberSchema>({
|
|
||||||
resolver: zodResolver(ZUpdateOrganisationMemberFormSchema),
|
|
||||||
defaultValues: {
|
|
||||||
role: currentRoleValue,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
const { mutateAsync: updateOrganisationMemberRole } =
|
|
||||||
trpc.admin.organisationMember.updateRole.useMutation();
|
|
||||||
|
|
||||||
const onFormSubmit = async ({ role }: ZUpdateOrganisationMemberSchema) => {
|
|
||||||
try {
|
|
||||||
await updateOrganisationMemberRole({
|
|
||||||
organisationId,
|
|
||||||
userId: organisationMember.userId,
|
|
||||||
role,
|
|
||||||
});
|
|
||||||
|
|
||||||
const roleLabel = match(role)
|
|
||||||
.with('OWNER', () => t`Owner`)
|
|
||||||
.with(OrganisationMemberRole.ADMIN, () => t`Admin`)
|
|
||||||
.with(OrganisationMemberRole.MANAGER, () => t`Manager`)
|
|
||||||
.with(OrganisationMemberRole.MEMBER, () => t`Member`)
|
|
||||||
.exhaustive();
|
|
||||||
|
|
||||||
toast({
|
|
||||||
title: t`Success`,
|
|
||||||
description:
|
|
||||||
role === 'OWNER'
|
|
||||||
? t`Ownership transferred to ${organisationMemberName}.`
|
|
||||||
: t`Updated ${organisationMemberName} to ${roleLabel}.`,
|
|
||||||
duration: 5000,
|
|
||||||
});
|
|
||||||
|
|
||||||
setOpen(false);
|
|
||||||
|
|
||||||
// Refresh the page to show updated data
|
|
||||||
await navigate(0);
|
|
||||||
} catch (err) {
|
|
||||||
console.error(err);
|
|
||||||
|
|
||||||
toast({
|
|
||||||
title: t`An unknown error occurred`,
|
|
||||||
description: t`We encountered an unknown error while attempting to update this organisation member. Please try again later.`,
|
|
||||||
variant: 'destructive',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
};
|
|
||||||
|
|
||||||
useEffect(() => {
|
|
||||||
if (!open) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
form.reset({
|
|
||||||
role: currentRoleValue,
|
|
||||||
});
|
|
||||||
// eslint-disable-next-line react-hooks/exhaustive-deps
|
|
||||||
}, [open, currentRoleValue, form]);
|
|
||||||
|
|
||||||
return (
|
|
||||||
<Dialog
|
|
||||||
{...props}
|
|
||||||
open={open}
|
|
||||||
onOpenChange={(value) => !form.formState.isSubmitting && setOpen(value)}
|
|
||||||
>
|
|
||||||
<DialogTrigger onClick={(e) => e.stopPropagation()} asChild>
|
|
||||||
{trigger ?? (
|
|
||||||
<Button variant="secondary">
|
|
||||||
<Trans>Update role</Trans>
|
|
||||||
</Button>
|
|
||||||
)}
|
|
||||||
</DialogTrigger>
|
|
||||||
|
|
||||||
<DialogContent position="center">
|
|
||||||
<DialogHeader>
|
|
||||||
<DialogTitle>
|
|
||||||
<Trans>Update organisation member</Trans>
|
|
||||||
</DialogTitle>
|
|
||||||
|
|
||||||
<DialogDescription className="mt-4">
|
|
||||||
<Trans>
|
|
||||||
You are currently updating{' '}
|
|
||||||
<span className="font-bold">{organisationMemberName}.</span>
|
|
||||||
</Trans>
|
|
||||||
</DialogDescription>
|
|
||||||
</DialogHeader>
|
|
||||||
|
|
||||||
<Form {...form}>
|
|
||||||
<form onSubmit={form.handleSubmit(onFormSubmit)}>
|
|
||||||
<fieldset className="flex h-full flex-col" disabled={form.formState.isSubmitting}>
|
|
||||||
<FormField
|
|
||||||
control={form.control}
|
|
||||||
name="role"
|
|
||||||
render={({ field }) => (
|
|
||||||
<FormItem className="w-full">
|
|
||||||
<FormLabel required>
|
|
||||||
<Trans>Role</Trans>
|
|
||||||
</FormLabel>
|
|
||||||
<FormControl>
|
|
||||||
<Select {...field} onValueChange={field.onChange}>
|
|
||||||
<SelectTrigger className="text-muted-foreground">
|
|
||||||
<SelectValue />
|
|
||||||
</SelectTrigger>
|
|
||||||
|
|
||||||
<SelectContent className="w-full" position="popper">
|
|
||||||
<SelectItem value="OWNER">
|
|
||||||
<Trans>Owner</Trans>
|
|
||||||
</SelectItem>
|
|
||||||
<SelectItem value={OrganisationMemberRole.ADMIN}>
|
|
||||||
<Trans>Admin</Trans>
|
|
||||||
</SelectItem>
|
|
||||||
<SelectItem value={OrganisationMemberRole.MANAGER}>
|
|
||||||
<Trans>Manager</Trans>
|
|
||||||
</SelectItem>
|
|
||||||
<SelectItem value={OrganisationMemberRole.MEMBER}>
|
|
||||||
<Trans>Member</Trans>
|
|
||||||
</SelectItem>
|
|
||||||
</SelectContent>
|
|
||||||
</Select>
|
|
||||||
</FormControl>
|
|
||||||
<FormMessage />
|
|
||||||
</FormItem>
|
|
||||||
)}
|
|
||||||
/>
|
|
||||||
|
|
||||||
<DialogFooter className="mt-4">
|
|
||||||
<Button type="button" variant="secondary" onClick={() => setOpen(false)}>
|
|
||||||
<Trans>Cancel</Trans>
|
|
||||||
</Button>
|
|
||||||
|
|
||||||
<Button type="submit" loading={form.formState.isSubmitting}>
|
|
||||||
<Trans>Update</Trans>
|
|
||||||
</Button>
|
|
||||||
</DialogFooter>
|
|
||||||
</fieldset>
|
|
||||||
</form>
|
|
||||||
</Form>
|
|
||||||
</DialogContent>
|
|
||||||
</Dialog>
|
|
||||||
);
|
|
||||||
};
|
|
||||||
@ -89,10 +89,7 @@ export const DirectTemplatePageView = ({
|
|||||||
setStep('sign');
|
setStep('sign');
|
||||||
};
|
};
|
||||||
|
|
||||||
const onSignDirectTemplateSubmit = async (
|
const onSignDirectTemplateSubmit = async (fields: DirectTemplateLocalField[]) => {
|
||||||
fields: DirectTemplateLocalField[],
|
|
||||||
nextSigner?: { name: string; email: string },
|
|
||||||
) => {
|
|
||||||
try {
|
try {
|
||||||
let directTemplateExternalId = searchParams?.get('externalId') || undefined;
|
let directTemplateExternalId = searchParams?.get('externalId') || undefined;
|
||||||
|
|
||||||
@ -101,7 +98,6 @@ export const DirectTemplatePageView = ({
|
|||||||
}
|
}
|
||||||
|
|
||||||
const { token } = await createDocumentFromDirectTemplate({
|
const { token } = await createDocumentFromDirectTemplate({
|
||||||
nextSigner,
|
|
||||||
directTemplateToken,
|
directTemplateToken,
|
||||||
directTemplateExternalId,
|
directTemplateExternalId,
|
||||||
directRecipientName: fullName,
|
directRecipientName: fullName,
|
||||||
|
|||||||
@ -55,13 +55,10 @@ import { DocumentSigningRecipientProvider } from '../document-signing/document-s
|
|||||||
|
|
||||||
export type DirectTemplateSigningFormProps = {
|
export type DirectTemplateSigningFormProps = {
|
||||||
flowStep: DocumentFlowStep;
|
flowStep: DocumentFlowStep;
|
||||||
directRecipient: Pick<Recipient, 'authOptions' | 'email' | 'role' | 'name' | 'token' | 'id'>;
|
directRecipient: Pick<Recipient, 'authOptions' | 'email' | 'role' | 'name' | 'token'>;
|
||||||
directRecipientFields: Field[];
|
directRecipientFields: Field[];
|
||||||
template: Omit<TTemplate, 'user'>;
|
template: Omit<TTemplate, 'user'>;
|
||||||
onSubmit: (
|
onSubmit: (_data: DirectTemplateLocalField[]) => Promise<void>;
|
||||||
_data: DirectTemplateLocalField[],
|
|
||||||
_nextSigner?: { name: string; email: string },
|
|
||||||
) => Promise<void>;
|
|
||||||
};
|
};
|
||||||
|
|
||||||
export type DirectTemplateLocalField = Field & {
|
export type DirectTemplateLocalField = Field & {
|
||||||
@ -152,7 +149,7 @@ export const DirectTemplateSigningForm = ({
|
|||||||
validateFieldsInserted(fieldsRequiringValidation);
|
validateFieldsInserted(fieldsRequiringValidation);
|
||||||
};
|
};
|
||||||
|
|
||||||
const handleSubmit = async (nextSigner?: { name: string; email: string }) => {
|
const handleSubmit = async () => {
|
||||||
setValidateUninsertedFields(true);
|
setValidateUninsertedFields(true);
|
||||||
|
|
||||||
const isFieldsValid = validateFieldsInserted(fieldsRequiringValidation);
|
const isFieldsValid = validateFieldsInserted(fieldsRequiringValidation);
|
||||||
@ -164,7 +161,7 @@ export const DirectTemplateSigningForm = ({
|
|||||||
setIsSubmitting(true);
|
setIsSubmitting(true);
|
||||||
|
|
||||||
try {
|
try {
|
||||||
await onSubmit(localFields, nextSigner);
|
await onSubmit(localFields);
|
||||||
} catch {
|
} catch {
|
||||||
setIsSubmitting(false);
|
setIsSubmitting(false);
|
||||||
}
|
}
|
||||||
@ -221,30 +218,6 @@ export const DirectTemplateSigningForm = ({
|
|||||||
setLocalFields(updatedFields);
|
setLocalFields(updatedFields);
|
||||||
}, []);
|
}, []);
|
||||||
|
|
||||||
const nextRecipient = useMemo(() => {
|
|
||||||
if (
|
|
||||||
!template.templateMeta?.signingOrder ||
|
|
||||||
template.templateMeta.signingOrder !== 'SEQUENTIAL' ||
|
|
||||||
!template.templateMeta.allowDictateNextSigner
|
|
||||||
) {
|
|
||||||
return undefined;
|
|
||||||
}
|
|
||||||
|
|
||||||
const sortedRecipients = template.recipients.sort((a, b) => {
|
|
||||||
// Sort by signingOrder first (nulls last), then by id
|
|
||||||
if (a.signingOrder === null && b.signingOrder === null) return a.id - b.id;
|
|
||||||
if (a.signingOrder === null) return 1;
|
|
||||||
if (b.signingOrder === null) return -1;
|
|
||||||
if (a.signingOrder === b.signingOrder) return a.id - b.id;
|
|
||||||
return a.signingOrder - b.signingOrder;
|
|
||||||
});
|
|
||||||
|
|
||||||
const currentIndex = sortedRecipients.findIndex((r) => r.id === directRecipient.id);
|
|
||||||
return currentIndex !== -1 && currentIndex < sortedRecipients.length - 1
|
|
||||||
? sortedRecipients[currentIndex + 1]
|
|
||||||
: undefined;
|
|
||||||
}, [template.templateMeta?.signingOrder, template.recipients, directRecipient.id]);
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<DocumentSigningRecipientProvider recipient={directRecipient}>
|
<DocumentSigningRecipientProvider recipient={directRecipient}>
|
||||||
<DocumentFlowFormContainerHeader title={flowStep.title} description={flowStep.description} />
|
<DocumentFlowFormContainerHeader title={flowStep.title} description={flowStep.description} />
|
||||||
@ -444,15 +417,11 @@ export const DirectTemplateSigningForm = ({
|
|||||||
|
|
||||||
<DocumentSigningCompleteDialog
|
<DocumentSigningCompleteDialog
|
||||||
isSubmitting={isSubmitting}
|
isSubmitting={isSubmitting}
|
||||||
onSignatureComplete={async (nextSigner) => handleSubmit(nextSigner)}
|
onSignatureComplete={async () => handleSubmit()}
|
||||||
documentTitle={template.title}
|
documentTitle={template.title}
|
||||||
fields={localFields}
|
fields={localFields}
|
||||||
fieldsValidated={fieldsValidated}
|
fieldsValidated={fieldsValidated}
|
||||||
recipient={directRecipient}
|
recipient={directRecipient}
|
||||||
allowDictateNextSigner={nextRecipient && template.templateMeta?.allowDictateNextSigner}
|
|
||||||
defaultNextSigner={
|
|
||||||
nextRecipient ? { name: nextRecipient.name, email: nextRecipient.email } : undefined
|
|
||||||
}
|
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
</DocumentFlowFormContainerFooter>
|
</DocumentFlowFormContainerFooter>
|
||||||
|
|||||||
@ -9,7 +9,7 @@ import { Button } from '@documenso/ui/primitives/button';
|
|||||||
import { useToast } from '@documenso/ui/primitives/use-toast';
|
import { useToast } from '@documenso/ui/primitives/use-toast';
|
||||||
|
|
||||||
export type DocumentSigningAuthPageViewProps = {
|
export type DocumentSigningAuthPageViewProps = {
|
||||||
email?: string;
|
email: string;
|
||||||
emailHasAccount?: boolean;
|
emailHasAccount?: boolean;
|
||||||
};
|
};
|
||||||
|
|
||||||
@ -22,18 +22,12 @@ export const DocumentSigningAuthPageView = ({
|
|||||||
|
|
||||||
const [isSigningOut, setIsSigningOut] = useState(false);
|
const [isSigningOut, setIsSigningOut] = useState(false);
|
||||||
|
|
||||||
const handleChangeAccount = async (email?: string) => {
|
const handleChangeAccount = async (email: string) => {
|
||||||
try {
|
try {
|
||||||
setIsSigningOut(true);
|
setIsSigningOut(true);
|
||||||
|
|
||||||
let redirectPath = '/signin';
|
|
||||||
|
|
||||||
if (email) {
|
|
||||||
redirectPath = emailHasAccount ? `/signin#email=${email}` : `/signup#email=${email}`;
|
|
||||||
}
|
|
||||||
|
|
||||||
await authClient.signOut({
|
await authClient.signOut({
|
||||||
redirectPath,
|
redirectPath: emailHasAccount ? `/signin#email=${email}` : `/signup#email=${email}`,
|
||||||
});
|
});
|
||||||
} catch {
|
} catch {
|
||||||
toast({
|
toast({
|
||||||
@ -55,13 +49,9 @@ export const DocumentSigningAuthPageView = ({
|
|||||||
</h1>
|
</h1>
|
||||||
|
|
||||||
<p className="text-muted-foreground mt-2 text-sm">
|
<p className="text-muted-foreground mt-2 text-sm">
|
||||||
{email ? (
|
<Trans>
|
||||||
<Trans>
|
You need to be logged in as <strong>{email}</strong> to view this page.
|
||||||
You need to be logged in as <strong>{email}</strong> to view this page.
|
</Trans>
|
||||||
</Trans>
|
|
||||||
) : (
|
|
||||||
<Trans>You need to be logged in to view this page.</Trans>
|
|
||||||
)}
|
|
||||||
</p>
|
</p>
|
||||||
|
|
||||||
<Button
|
<Button
|
||||||
|
|||||||
@ -24,10 +24,7 @@ type PasskeyData = {
|
|||||||
isError: boolean;
|
isError: boolean;
|
||||||
};
|
};
|
||||||
|
|
||||||
type SigningAuthRecipient = Pick<
|
type SigningAuthRecipient = Pick<Recipient, 'authOptions' | 'email' | 'role' | 'name' | 'token'>;
|
||||||
Recipient,
|
|
||||||
'authOptions' | 'email' | 'role' | 'name' | 'token' | 'id'
|
|
||||||
>;
|
|
||||||
|
|
||||||
export type DocumentSigningAuthContextValue = {
|
export type DocumentSigningAuthContextValue = {
|
||||||
executeActionAuthProcedure: (_value: ExecuteActionAuthProcedureOptions) => Promise<void>;
|
executeActionAuthProcedure: (_value: ExecuteActionAuthProcedureOptions) => Promise<void>;
|
||||||
|
|||||||
@ -304,6 +304,7 @@ export const DocumentSigningCompleteDialog = ({
|
|||||||
<form onSubmit={form.handleSubmit(onFormSubmit)}>
|
<form onSubmit={form.handleSubmit(onFormSubmit)}>
|
||||||
{allowDictateNextSigner && defaultNextSigner && (
|
{allowDictateNextSigner && defaultNextSigner && (
|
||||||
<div className="mb-4 flex flex-col gap-4">
|
<div className="mb-4 flex flex-col gap-4">
|
||||||
|
{/* Todo: Envelopes - Should we say "The next recipient to sign this document will be"? */}
|
||||||
<div className="flex flex-col gap-4 md:flex-row">
|
<div className="flex flex-col gap-4 md:flex-row">
|
||||||
<FormField
|
<FormField
|
||||||
control={form.control}
|
control={form.control}
|
||||||
|
|||||||
@ -285,6 +285,8 @@ export const EnvelopeSigningProvider = ({
|
|||||||
}, [envelope.documentMeta?.signingOrder, envelope.recipients, recipient.id]);
|
}, [envelope.documentMeta?.signingOrder, envelope.recipients, recipient.id]);
|
||||||
|
|
||||||
const signField = async (fieldId: number, fieldValue: TSignEnvelopeFieldValue) => {
|
const signField = async (fieldId: number, fieldValue: TSignEnvelopeFieldValue) => {
|
||||||
|
console.log('insertField', fieldId, fieldValue);
|
||||||
|
|
||||||
// Set the field locally for direct templates.
|
// Set the field locally for direct templates.
|
||||||
if (isDirectTemplate) {
|
if (isDirectTemplate) {
|
||||||
handleDirectTemplateFieldInsertion(fieldId, fieldValue);
|
handleDirectTemplateFieldInsertion(fieldId, fieldValue);
|
||||||
|
|||||||
@ -127,7 +127,6 @@ export const EnvelopeSignerCompleteDialog = () => {
|
|||||||
isBase64,
|
isBase64,
|
||||||
};
|
};
|
||||||
}),
|
}),
|
||||||
nextSigner,
|
|
||||||
});
|
});
|
||||||
|
|
||||||
const redirectUrl = envelope.documentMeta.redirectUrl;
|
const redirectUrl = envelope.documentMeta.redirectUrl;
|
||||||
|
|||||||
@ -34,7 +34,6 @@ import { Input } from '@documenso/ui/primitives/input';
|
|||||||
import { Tooltip, TooltipContent, TooltipTrigger } from '@documenso/ui/primitives/tooltip';
|
import { Tooltip, TooltipContent, TooltipTrigger } from '@documenso/ui/primitives/tooltip';
|
||||||
import { useToast } from '@documenso/ui/primitives/use-toast';
|
import { useToast } from '@documenso/ui/primitives/use-toast';
|
||||||
|
|
||||||
import { AdminOrganisationMemberUpdateDialog } from '~/components/dialogs/admin-organisation-member-update-dialog';
|
|
||||||
import { GenericErrorLayout } from '~/components/general/generic-error-layout';
|
import { GenericErrorLayout } from '~/components/general/generic-error-layout';
|
||||||
import { SettingsHeader } from '~/components/general/settings-header';
|
import { SettingsHeader } from '~/components/general/settings-header';
|
||||||
|
|
||||||
@ -72,6 +71,23 @@ export default function OrganisationGroupSettingsPage({ params }: Route.Componen
|
|||||||
},
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const { mutateAsync: promoteToOwner, isPending: isPromotingToOwner } =
|
||||||
|
trpc.admin.organisationMember.promoteToOwner.useMutation({
|
||||||
|
onSuccess: () => {
|
||||||
|
toast({
|
||||||
|
title: t`Success`,
|
||||||
|
description: t`Member promoted to owner successfully`,
|
||||||
|
});
|
||||||
|
},
|
||||||
|
onError: () => {
|
||||||
|
toast({
|
||||||
|
title: t`Error`,
|
||||||
|
description: t`We couldn't promote the member to owner. Please try again.`,
|
||||||
|
variant: 'destructive',
|
||||||
|
});
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
const teamsColumns = useMemo(() => {
|
const teamsColumns = useMemo(() => {
|
||||||
return [
|
return [
|
||||||
{
|
{
|
||||||
@ -104,24 +120,23 @@ export default function OrganisationGroupSettingsPage({ params }: Route.Componen
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
header: t`Actions`,
|
header: t`Actions`,
|
||||||
cell: ({ row }) => {
|
cell: ({ row }) => (
|
||||||
const isOwner = row.original.userId === organisation?.ownerUserId;
|
<div className="flex justify-end space-x-2">
|
||||||
|
<Button
|
||||||
return (
|
variant="outline"
|
||||||
<div className="flex justify-end space-x-2">
|
disabled={row.original.userId === organisation?.ownerUserId}
|
||||||
<AdminOrganisationMemberUpdateDialog
|
loading={isPromotingToOwner}
|
||||||
trigger={
|
onClick={async () =>
|
||||||
<Button variant="outline">
|
promoteToOwner({
|
||||||
<Trans>Update role</Trans>
|
organisationId,
|
||||||
</Button>
|
userId: row.original.userId,
|
||||||
}
|
})
|
||||||
organisationId={organisationId}
|
}
|
||||||
organisationMember={row.original}
|
>
|
||||||
isOwner={isOwner}
|
<Trans>Promote to owner</Trans>
|
||||||
/>
|
</Button>
|
||||||
</div>
|
</div>
|
||||||
);
|
),
|
||||||
},
|
|
||||||
},
|
},
|
||||||
] satisfies DataTableColumnDef<TGetAdminOrganisationResponse['members'][number]>[];
|
] satisfies DataTableColumnDef<TGetAdminOrganisationResponse['members'][number]>[];
|
||||||
}, [organisation]);
|
}, [organisation]);
|
||||||
|
|||||||
@ -8,6 +8,7 @@ import { EnvelopeRenderProvider } from '@documenso/lib/client-only/providers/env
|
|||||||
import { useOptionalSession } from '@documenso/lib/client-only/providers/session';
|
import { useOptionalSession } from '@documenso/lib/client-only/providers/session';
|
||||||
import { AppError, AppErrorCode } from '@documenso/lib/errors/app-error';
|
import { AppError, AppErrorCode } from '@documenso/lib/errors/app-error';
|
||||||
import { getEnvelopeForDirectTemplateSigning } from '@documenso/lib/server-only/envelope/get-envelope-for-direct-template-signing';
|
import { getEnvelopeForDirectTemplateSigning } from '@documenso/lib/server-only/envelope/get-envelope-for-direct-template-signing';
|
||||||
|
import { getEnvelopeRequiredAccessData } from '@documenso/lib/server-only/envelope/get-envelope-required-access-data';
|
||||||
import { getTemplateByDirectLinkToken } from '@documenso/lib/server-only/template/get-template-by-direct-link-token';
|
import { getTemplateByDirectLinkToken } from '@documenso/lib/server-only/template/get-template-by-direct-link-token';
|
||||||
import { DocumentAccessAuth } from '@documenso/lib/types/document-auth';
|
import { DocumentAccessAuth } from '@documenso/lib/types/document-auth';
|
||||||
import { extractDocumentAuthMethods } from '@documenso/lib/utils/document-auth';
|
import { extractDocumentAuthMethods } from '@documenso/lib/utils/document-auth';
|
||||||
@ -97,12 +98,15 @@ const handleV2Loader = async ({ params, request }: Route.LoaderArgs) => {
|
|||||||
envelopeForSigning,
|
envelopeForSigning,
|
||||||
} as const;
|
} as const;
|
||||||
})
|
})
|
||||||
.catch((e) => {
|
.catch(async (e) => {
|
||||||
const error = AppError.parseError(e);
|
const error = AppError.parseError(e);
|
||||||
|
|
||||||
if (error.code === AppErrorCode.UNAUTHORIZED) {
|
if (error.code === AppErrorCode.UNAUTHORIZED) {
|
||||||
|
const requiredAccessData = await getEnvelopeRequiredAccessData({ token });
|
||||||
|
|
||||||
return {
|
return {
|
||||||
isDocumentAccessValid: false,
|
isDocumentAccessValid: false,
|
||||||
|
...requiredAccessData,
|
||||||
} as const;
|
} as const;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -222,21 +226,20 @@ const DirectSigningPageV2 = ({ data }: { data: Awaited<ReturnType<typeof handleV
|
|||||||
const user = sessionData?.user;
|
const user = sessionData?.user;
|
||||||
|
|
||||||
if (!data.isDocumentAccessValid) {
|
if (!data.isDocumentAccessValid) {
|
||||||
return <DocumentSigningAuthPageView email={''} emailHasAccount={true} />;
|
return (
|
||||||
|
<DocumentSigningAuthPageView
|
||||||
|
email={data.recipientEmail}
|
||||||
|
emailHasAccount={!!data.recipientHasAccount}
|
||||||
|
/>
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
const { envelope, recipient } = data.envelopeForSigning;
|
const { envelope, recipient } = data.envelopeForSigning;
|
||||||
|
|
||||||
const { derivedRecipientAccessAuth } = extractDocumentAuthMethods({
|
|
||||||
documentAuth: envelope.authOptions,
|
|
||||||
});
|
|
||||||
|
|
||||||
const isEmailForced = derivedRecipientAccessAuth.includes(DocumentAccessAuth.ACCOUNT);
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<EnvelopeSigningProvider
|
<EnvelopeSigningProvider
|
||||||
envelopeData={data.envelopeForSigning}
|
envelopeData={data.envelopeForSigning}
|
||||||
email={isEmailForced ? user?.email || '' : ''} // Doing this allows us to let users change the email if they want to for non-auth templates.
|
email={''} // Doing this allows us to let users change the email if they want to.
|
||||||
fullName={user?.name}
|
fullName={user?.name}
|
||||||
signature={user?.signature}
|
signature={user?.signature}
|
||||||
>
|
>
|
||||||
|
|||||||
13
package-lock.json
generated
13
package-lock.json
generated
@ -19,7 +19,6 @@
|
|||||||
"inngest-cli": "^0.29.1",
|
"inngest-cli": "^0.29.1",
|
||||||
"luxon": "^3.5.0",
|
"luxon": "^3.5.0",
|
||||||
"mupdf": "^1.0.0",
|
"mupdf": "^1.0.0",
|
||||||
"pdf2json": "^4.0.0",
|
|
||||||
"react": "^18",
|
"react": "^18",
|
||||||
"typescript": "5.6.2",
|
"typescript": "5.6.2",
|
||||||
"zod": "3.24.1"
|
"zod": "3.24.1"
|
||||||
@ -27199,18 +27198,6 @@
|
|||||||
"dev": true,
|
"dev": true,
|
||||||
"license": "MIT"
|
"license": "MIT"
|
||||||
},
|
},
|
||||||
"node_modules/pdf2json": {
|
|
||||||
"version": "4.0.0",
|
|
||||||
"resolved": "https://registry.npmjs.org/pdf2json/-/pdf2json-4.0.0.tgz",
|
|
||||||
"integrity": "sha512-WkezNsLK8sGpuFC7+PPP0DsXROwdoOxmXPBTtUWWkCwCi/Vi97MRC52Ly6FWIJjOKIywpm/L2oaUgSrmtU+7ZQ==",
|
|
||||||
"license": "Apache-2.0",
|
|
||||||
"bin": {
|
|
||||||
"pdf2json": "bin/pdf2json.js"
|
|
||||||
},
|
|
||||||
"engines": {
|
|
||||||
"node": ">=20.18.0"
|
|
||||||
}
|
|
||||||
},
|
|
||||||
"node_modules/pdfjs-dist": {
|
"node_modules/pdfjs-dist": {
|
||||||
"version": "3.11.174",
|
"version": "3.11.174",
|
||||||
"resolved": "https://registry.npmjs.org/pdfjs-dist/-/pdfjs-dist-3.11.174.tgz",
|
"resolved": "https://registry.npmjs.org/pdfjs-dist/-/pdfjs-dist-3.11.174.tgz",
|
||||||
|
|||||||
@ -74,7 +74,6 @@
|
|||||||
"inngest-cli": "^0.29.1",
|
"inngest-cli": "^0.29.1",
|
||||||
"luxon": "^3.5.0",
|
"luxon": "^3.5.0",
|
||||||
"mupdf": "^1.0.0",
|
"mupdf": "^1.0.0",
|
||||||
"pdf2json": "^4.0.0",
|
|
||||||
"react": "^18",
|
"react": "^18",
|
||||||
"typescript": "5.6.2",
|
"typescript": "5.6.2",
|
||||||
"zod": "3.24.1"
|
"zod": "3.24.1"
|
||||||
|
|||||||
@ -68,29 +68,15 @@ test('[ADMIN]: promote member to owner', async ({ page }) => {
|
|||||||
// Test promoting a MEMBER to owner
|
// Test promoting a MEMBER to owner
|
||||||
const memberRow = page.getByRole('row', { name: memberUser.email });
|
const memberRow = page.getByRole('row', { name: memberUser.email });
|
||||||
|
|
||||||
// Find and click the "Update role" button for the member
|
// Find and click the "Promote to owner" button for the member
|
||||||
const updateRoleButton = memberRow.getByRole('button', {
|
const promoteButton = memberRow.getByRole('button', { name: 'Promote to owner' });
|
||||||
name: 'Update role',
|
await expect(promoteButton).toBeVisible();
|
||||||
});
|
await expect(promoteButton).not.toBeDisabled();
|
||||||
await expect(updateRoleButton).toBeVisible();
|
|
||||||
await expect(updateRoleButton).not.toBeDisabled();
|
|
||||||
|
|
||||||
await updateRoleButton.click();
|
await promoteButton.click();
|
||||||
|
|
||||||
// Wait for dialog to open and select Owner role
|
// Verify success toast appears
|
||||||
await expect(page.getByRole('dialog')).toBeVisible();
|
await expect(page.getByText('Member promoted to owner successfully').first()).toBeVisible();
|
||||||
|
|
||||||
// Find and click the select trigger - it's a button with role="combobox"
|
|
||||||
await page.getByRole('dialog').locator('button[role="combobox"]').click();
|
|
||||||
|
|
||||||
// Select "Owner" from the dropdown options
|
|
||||||
await page.getByRole('option', { name: 'Owner' }).click();
|
|
||||||
|
|
||||||
// Click Update button
|
|
||||||
await page.getByRole('dialog').getByRole('button', { name: 'Update' }).click();
|
|
||||||
|
|
||||||
// Wait for dialog to close (indicates success)
|
|
||||||
await expect(page.getByRole('dialog')).not.toBeVisible({ timeout: 10_000 });
|
|
||||||
|
|
||||||
// Reload the page to see the changes
|
// Reload the page to see the changes
|
||||||
await page.reload();
|
await page.reload();
|
||||||
@ -103,18 +89,12 @@ test('[ADMIN]: promote member to owner', async ({ page }) => {
|
|||||||
const previousOwnerRow = page.getByRole('row', { name: ownerUser.email });
|
const previousOwnerRow = page.getByRole('row', { name: ownerUser.email });
|
||||||
await expect(previousOwnerRow.getByRole('status').filter({ hasText: 'Owner' })).not.toBeVisible();
|
await expect(previousOwnerRow.getByRole('status').filter({ hasText: 'Owner' })).not.toBeVisible();
|
||||||
|
|
||||||
// Verify that the Update role button exists for the new owner and shows Owner as current role
|
// Verify that the promote button is now disabled for the new owner
|
||||||
const newOwnerUpdateButton = newOwnerRow.getByRole('button', {
|
const newOwnerPromoteButton = newOwnerRow.getByRole('button', { name: 'Promote to owner' });
|
||||||
name: 'Update role',
|
await expect(newOwnerPromoteButton).toBeDisabled();
|
||||||
});
|
|
||||||
await expect(newOwnerUpdateButton).toBeVisible();
|
|
||||||
|
|
||||||
// Verify clicking it shows the dialog with Owner already selected
|
// Test that we can't promote the current owner (button should be disabled)
|
||||||
await newOwnerUpdateButton.click();
|
await expect(newOwnerPromoteButton).toHaveAttribute('disabled');
|
||||||
await expect(page.getByRole('dialog')).toBeVisible();
|
|
||||||
|
|
||||||
// Close the dialog without making changes
|
|
||||||
await page.getByRole('button', { name: 'Cancel' }).click();
|
|
||||||
});
|
});
|
||||||
|
|
||||||
test('[ADMIN]: promote manager to owner', async ({ page }) => {
|
test('[ADMIN]: promote manager to owner', async ({ page }) => {
|
||||||
@ -150,26 +130,10 @@ test('[ADMIN]: promote manager to owner', async ({ page }) => {
|
|||||||
|
|
||||||
// Promote the manager to owner
|
// Promote the manager to owner
|
||||||
const managerRow = page.getByRole('row', { name: managerUser.email });
|
const managerRow = page.getByRole('row', { name: managerUser.email });
|
||||||
const updateRoleButton = managerRow.getByRole('button', {
|
const promoteButton = managerRow.getByRole('button', { name: 'Promote to owner' });
|
||||||
name: 'Update role',
|
|
||||||
});
|
|
||||||
|
|
||||||
await updateRoleButton.click();
|
await promoteButton.click();
|
||||||
|
await expect(page.getByText('Member promoted to owner successfully').first()).toBeVisible();
|
||||||
// Wait for dialog to open and select Owner role
|
|
||||||
await expect(page.getByRole('dialog')).toBeVisible();
|
|
||||||
|
|
||||||
// Find and click the select trigger - it's a button with role="combobox"
|
|
||||||
await page.getByRole('dialog').locator('button[role="combobox"]').click();
|
|
||||||
|
|
||||||
// Select "Owner" from the dropdown options
|
|
||||||
await page.getByRole('option', { name: 'Owner' }).click();
|
|
||||||
|
|
||||||
// Click Update button
|
|
||||||
await page.getByRole('dialog').getByRole('button', { name: 'Update' }).click();
|
|
||||||
|
|
||||||
// Wait for dialog to close (indicates success)
|
|
||||||
await expect(page.getByRole('dialog')).not.toBeVisible({ timeout: 10_000 });
|
|
||||||
|
|
||||||
// Reload and verify the change
|
// Reload and verify the change
|
||||||
await page.reload();
|
await page.reload();
|
||||||
@ -209,27 +173,14 @@ test('[ADMIN]: promote admin member to owner', async ({ page }) => {
|
|||||||
|
|
||||||
// Promote the admin member to owner
|
// Promote the admin member to owner
|
||||||
const adminMemberRow = page.getByRole('row', { name: adminMemberUser.email });
|
const adminMemberRow = page.getByRole('row', { name: adminMemberUser.email });
|
||||||
const updateRoleButton = adminMemberRow.getByRole('button', {
|
const promoteButton = adminMemberRow.getByRole('button', { name: 'Promote to owner' });
|
||||||
name: 'Update role',
|
|
||||||
|
await promoteButton.click();
|
||||||
|
|
||||||
|
await expect(page.getByText('Member promoted to owner successfully').first()).toBeVisible({
|
||||||
|
timeout: 10_000,
|
||||||
});
|
});
|
||||||
|
|
||||||
await updateRoleButton.click();
|
|
||||||
|
|
||||||
// Wait for dialog to open and select Owner role
|
|
||||||
await expect(page.getByRole('dialog')).toBeVisible();
|
|
||||||
|
|
||||||
// Find and click the select trigger - it's a button with role="combobox"
|
|
||||||
await page.getByRole('dialog').locator('button[role="combobox"]').click();
|
|
||||||
|
|
||||||
// Select "Owner" from the dropdown options
|
|
||||||
await page.getByRole('option', { name: 'Owner' }).click();
|
|
||||||
|
|
||||||
// Click Update button
|
|
||||||
await page.getByRole('dialog').getByRole('button', { name: 'Update' }).click();
|
|
||||||
|
|
||||||
// Wait for dialog to close (indicates success)
|
|
||||||
await expect(page.getByRole('dialog')).not.toBeVisible({ timeout: 10_000 });
|
|
||||||
|
|
||||||
// Reload and verify the change
|
// Reload and verify the change
|
||||||
await page.reload();
|
await page.reload();
|
||||||
await expect(adminMemberRow.getByRole('status').filter({ hasText: 'Owner' })).toBeVisible();
|
await expect(adminMemberRow.getByRole('status').filter({ hasText: 'Owner' })).toBeVisible();
|
||||||
@ -298,25 +249,11 @@ test('[ADMIN]: verify role hierarchy after promotion', async ({ page }) => {
|
|||||||
await expect(memberRow.getByRole('status').filter({ hasText: 'Owner' })).not.toBeVisible();
|
await expect(memberRow.getByRole('status').filter({ hasText: 'Owner' })).not.toBeVisible();
|
||||||
|
|
||||||
// Promote member to owner
|
// Promote member to owner
|
||||||
const updateRoleButton = memberRow.getByRole('button', {
|
const promoteButton = memberRow.getByRole('button', { name: 'Promote to owner' });
|
||||||
name: 'Update role',
|
await promoteButton.click();
|
||||||
|
await expect(page.getByText('Member promoted to owner successfully').first()).toBeVisible({
|
||||||
|
timeout: 10_000,
|
||||||
});
|
});
|
||||||
await updateRoleButton.click();
|
|
||||||
|
|
||||||
// Wait for dialog to open and select Owner role
|
|
||||||
await expect(page.getByRole('dialog')).toBeVisible();
|
|
||||||
|
|
||||||
// Find and click the select trigger - it's a button with role="combobox"
|
|
||||||
await page.getByRole('dialog').locator('button[role="combobox"]').click();
|
|
||||||
|
|
||||||
// Select "Owner" from the dropdown options
|
|
||||||
await page.getByRole('option', { name: 'Owner' }).click();
|
|
||||||
|
|
||||||
// Click Update button
|
|
||||||
await page.getByRole('dialog').getByRole('button', { name: 'Update' }).click();
|
|
||||||
|
|
||||||
// Wait for dialog to close (indicates success)
|
|
||||||
await expect(page.getByRole('dialog')).not.toBeVisible({ timeout: 10_000 });
|
|
||||||
|
|
||||||
// Reload page to see updated state
|
// Reload page to see updated state
|
||||||
await page.reload();
|
await page.reload();
|
||||||
@ -325,11 +262,9 @@ test('[ADMIN]: verify role hierarchy after promotion', async ({ page }) => {
|
|||||||
memberRow = page.getByRole('row', { name: memberUser.email });
|
memberRow = page.getByRole('row', { name: memberUser.email });
|
||||||
await expect(memberRow.getByRole('status').filter({ hasText: 'Owner' })).toBeVisible();
|
await expect(memberRow.getByRole('status').filter({ hasText: 'Owner' })).toBeVisible();
|
||||||
|
|
||||||
// Verify the Update role button exists and shows Owner as current role
|
// Verify the promote button is now disabled for the new owner
|
||||||
const newOwnerUpdateButton = memberRow.getByRole('button', {
|
const newOwnerPromoteButton = memberRow.getByRole('button', { name: 'Promote to owner' });
|
||||||
name: 'Update role',
|
await expect(newOwnerPromoteButton).toBeDisabled();
|
||||||
});
|
|
||||||
await expect(newOwnerUpdateButton).toBeVisible();
|
|
||||||
|
|
||||||
// Sign in as the newly promoted user to verify they have owner permissions
|
// Sign in as the newly promoted user to verify they have owner permissions
|
||||||
await apiSignin({
|
await apiSignin({
|
||||||
@ -401,56 +336,28 @@ test('[ADMIN]: multiple promotions in sequence', async ({ page }) => {
|
|||||||
|
|
||||||
// First promotion: Member 1 becomes owner
|
// First promotion: Member 1 becomes owner
|
||||||
let member1Row = page.getByRole('row', { name: member1User.email });
|
let member1Row = page.getByRole('row', { name: member1User.email });
|
||||||
let updateRoleButton1 = member1Row.getByRole('button', {
|
let promoteButton1 = member1Row.getByRole('button', { name: 'Promote to owner' });
|
||||||
name: 'Update role',
|
await promoteButton1.click();
|
||||||
|
await expect(page.getByText('Member promoted to owner successfully').first()).toBeVisible({
|
||||||
|
timeout: 10_000,
|
||||||
});
|
});
|
||||||
await updateRoleButton1.click();
|
|
||||||
|
|
||||||
// Wait for dialog to open and select Owner role
|
|
||||||
await expect(page.getByRole('dialog')).toBeVisible();
|
|
||||||
|
|
||||||
// Find and click the select trigger - it's a button with role="combobox"
|
|
||||||
await page.getByRole('dialog').locator('button[role="combobox"]').click();
|
|
||||||
|
|
||||||
// Select "Owner" from the dropdown options
|
|
||||||
await page.getByRole('option', { name: 'Owner' }).click();
|
|
||||||
|
|
||||||
// Click Update button
|
|
||||||
await page.getByRole('dialog').getByRole('button', { name: 'Update' }).click();
|
|
||||||
|
|
||||||
// Wait for dialog to close (indicates success)
|
|
||||||
await expect(page.getByRole('dialog')).not.toBeVisible({ timeout: 10_000 });
|
|
||||||
|
|
||||||
await page.reload();
|
await page.reload();
|
||||||
|
|
||||||
// Verify Member 1 is now owner
|
// Verify Member 1 is now owner and button is disabled
|
||||||
member1Row = page.getByRole('row', { name: member1User.email });
|
member1Row = page.getByRole('row', { name: member1User.email });
|
||||||
await expect(member1Row.getByRole('status').filter({ hasText: 'Owner' })).toBeVisible();
|
await expect(member1Row.getByRole('status').filter({ hasText: 'Owner' })).toBeVisible();
|
||||||
updateRoleButton1 = member1Row.getByRole('button', { name: 'Update role' });
|
promoteButton1 = member1Row.getByRole('button', { name: 'Promote to owner' });
|
||||||
await expect(updateRoleButton1).toBeVisible();
|
await expect(promoteButton1).toBeDisabled();
|
||||||
|
|
||||||
// Second promotion: Member 2 becomes the new owner
|
// Second promotion: Member 2 becomes the new owner
|
||||||
const member2Row = page.getByRole('row', { name: member2User.email });
|
const member2Row = page.getByRole('row', { name: member2User.email });
|
||||||
const updateRoleButton2 = member2Row.getByRole('button', {
|
const promoteButton2 = member2Row.getByRole('button', { name: 'Promote to owner' });
|
||||||
name: 'Update role',
|
await expect(promoteButton2).not.toBeDisabled();
|
||||||
|
await promoteButton2.click();
|
||||||
|
await expect(page.getByText('Member promoted to owner successfully').first()).toBeVisible({
|
||||||
|
timeout: 10_000,
|
||||||
});
|
});
|
||||||
await expect(updateRoleButton2).toBeVisible();
|
|
||||||
await updateRoleButton2.click();
|
|
||||||
|
|
||||||
// Wait for dialog to open and select Owner role
|
|
||||||
await expect(page.getByRole('dialog')).toBeVisible();
|
|
||||||
|
|
||||||
// Find and click the select trigger - it's a button with role="combobox"
|
|
||||||
await page.getByRole('dialog').locator('button[role="combobox"]').click();
|
|
||||||
|
|
||||||
// Select "Owner" from the dropdown options
|
|
||||||
await page.getByRole('option', { name: 'Owner' }).click();
|
|
||||||
|
|
||||||
// Click Update button
|
|
||||||
await page.getByRole('dialog').getByRole('button', { name: 'Update' }).click();
|
|
||||||
|
|
||||||
// Wait for dialog to close (indicates success)
|
|
||||||
await expect(page.getByRole('dialog')).not.toBeVisible({ timeout: 10_000 });
|
|
||||||
|
|
||||||
await page.reload();
|
await page.reload();
|
||||||
|
|
||||||
@ -458,11 +365,9 @@ test('[ADMIN]: multiple promotions in sequence', async ({ page }) => {
|
|||||||
await expect(member2Row.getByRole('status').filter({ hasText: 'Owner' })).toBeVisible();
|
await expect(member2Row.getByRole('status').filter({ hasText: 'Owner' })).toBeVisible();
|
||||||
await expect(member1Row.getByRole('status').filter({ hasText: 'Owner' })).not.toBeVisible();
|
await expect(member1Row.getByRole('status').filter({ hasText: 'Owner' })).not.toBeVisible();
|
||||||
|
|
||||||
// Verify Member 1's Update role button is still visible
|
// Verify Member 1's promote button is now enabled again
|
||||||
const newUpdateButton1 = member1Row.getByRole('button', {
|
const newPromoteButton1 = member1Row.getByRole('button', { name: 'Promote to owner' });
|
||||||
name: 'Update role',
|
await expect(newPromoteButton1).not.toBeDisabled();
|
||||||
});
|
|
||||||
await expect(newUpdateButton1).toBeVisible();
|
|
||||||
});
|
});
|
||||||
|
|
||||||
test('[ADMIN]: verify organisation access after ownership change', async ({ page }) => {
|
test('[ADMIN]: verify organisation access after ownership change', async ({ page }) => {
|
||||||
@ -497,25 +402,11 @@ test('[ADMIN]: verify organisation access after ownership change', async ({ page
|
|||||||
});
|
});
|
||||||
|
|
||||||
const memberRow = page.getByRole('row', { name: memberUser.email });
|
const memberRow = page.getByRole('row', { name: memberUser.email });
|
||||||
const updateRoleButton = memberRow.getByRole('button', {
|
const promoteButton = memberRow.getByRole('button', { name: 'Promote to owner' });
|
||||||
name: 'Update role',
|
await promoteButton.click();
|
||||||
|
await expect(page.getByText('Member promoted to owner successfully').first()).toBeVisible({
|
||||||
|
timeout: 10_000,
|
||||||
});
|
});
|
||||||
await updateRoleButton.click();
|
|
||||||
|
|
||||||
// Wait for dialog to open and select Owner role
|
|
||||||
await expect(page.getByRole('dialog')).toBeVisible();
|
|
||||||
|
|
||||||
// Find and click the select trigger - it's a button with role="combobox"
|
|
||||||
await page.getByRole('dialog').locator('button[role="combobox"]').click();
|
|
||||||
|
|
||||||
// Select "Owner" from the dropdown options
|
|
||||||
await page.getByRole('option', { name: 'Owner' }).click();
|
|
||||||
|
|
||||||
// Click Update button
|
|
||||||
await page.getByRole('dialog').getByRole('button', { name: 'Update' }).click();
|
|
||||||
|
|
||||||
// Wait for dialog to close (indicates success)
|
|
||||||
await expect(page.getByRole('dialog')).not.toBeVisible({ timeout: 10_000 });
|
|
||||||
|
|
||||||
// Test that the new owner can access organisation settings
|
// Test that the new owner can access organisation settings
|
||||||
await apiSignin({
|
await apiSignin({
|
||||||
@ -1,98 +0,0 @@
|
|||||||
import { expect, test } from '@playwright/test';
|
|
||||||
import path from 'path';
|
|
||||||
|
|
||||||
import { seedUser } from '@documenso/prisma/seed/users';
|
|
||||||
|
|
||||||
import { apiSignin } from '../fixtures/authentication';
|
|
||||||
|
|
||||||
const PLACEHOLDER_PDF_PATH = path.join(
|
|
||||||
__dirname,
|
|
||||||
'../../../assets/project-proposal-single-recipient.pdf',
|
|
||||||
);
|
|
||||||
test.describe('PDF Placeholders with single recipient', () => {
|
|
||||||
test('[AUTO_PLACING_FIELDS]: should automatically create recipients from PDF placeholders', async ({
|
|
||||||
page,
|
|
||||||
}) => {
|
|
||||||
const { user, team } = await seedUser();
|
|
||||||
|
|
||||||
await apiSignin({
|
|
||||||
page,
|
|
||||||
email: user.email,
|
|
||||||
redirectPath: `/t/${team.url}/documents`,
|
|
||||||
});
|
|
||||||
|
|
||||||
const fileInput = page.locator('input[type="file"]').nth(1);
|
|
||||||
await fileInput.waitFor({ state: 'attached' });
|
|
||||||
await fileInput.setInputFiles(PLACEHOLDER_PDF_PATH);
|
|
||||||
|
|
||||||
await page.waitForTimeout(3000);
|
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Continue' }).click();
|
|
||||||
|
|
||||||
await expect(page.getByRole('heading', { name: 'Add Signers' })).toBeVisible();
|
|
||||||
await expect(page.getByPlaceholder('Email')).toHaveValue('recipient.1@documenso.com');
|
|
||||||
await expect(page.getByPlaceholder('Name')).toHaveValue('Recipient 1');
|
|
||||||
});
|
|
||||||
|
|
||||||
test('[AUTO_PLACING_FIELDS]: should automatically place fields from PDF placeholders', async ({
|
|
||||||
page,
|
|
||||||
}) => {
|
|
||||||
const { user, team } = await seedUser();
|
|
||||||
|
|
||||||
await apiSignin({
|
|
||||||
page,
|
|
||||||
email: user.email,
|
|
||||||
redirectPath: `/t/${team.url}/documents`,
|
|
||||||
});
|
|
||||||
|
|
||||||
const fileInput = page.locator('input[type="file"]').nth(1);
|
|
||||||
await fileInput.waitFor({ state: 'attached' });
|
|
||||||
await fileInput.setInputFiles(PLACEHOLDER_PDF_PATH);
|
|
||||||
|
|
||||||
await page.waitForTimeout(3000);
|
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Continue' }).click();
|
|
||||||
await page.getByRole('button', { name: 'Continue' }).click();
|
|
||||||
|
|
||||||
await expect(page.getByRole('heading', { name: 'Add Fields' })).toBeVisible();
|
|
||||||
|
|
||||||
await expect(page.locator('[data-field-type="SIGNATURE"]')).toBeVisible();
|
|
||||||
await expect(page.locator('[data-field-type="EMAIL"]')).toBeVisible();
|
|
||||||
await expect(page.locator('[data-field-type="NAME"]')).toBeVisible();
|
|
||||||
await expect(page.locator('[data-field-type="TEXT"]')).toBeVisible();
|
|
||||||
});
|
|
||||||
|
|
||||||
test('[AUTO_PLACING_FIELDS]: should automatically configure fields from PDF placeholders', async ({
|
|
||||||
page,
|
|
||||||
}) => {
|
|
||||||
const { user, team } = await seedUser();
|
|
||||||
|
|
||||||
await apiSignin({
|
|
||||||
page,
|
|
||||||
email: user.email,
|
|
||||||
redirectPath: `/t/${team.url}/documents`,
|
|
||||||
});
|
|
||||||
|
|
||||||
const fileInput = page.locator('input[type="file"]').nth(1);
|
|
||||||
await fileInput.waitFor({ state: 'attached' });
|
|
||||||
await fileInput.setInputFiles(PLACEHOLDER_PDF_PATH);
|
|
||||||
|
|
||||||
await page.waitForTimeout(3000);
|
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Continue' }).click();
|
|
||||||
await page.getByRole('button', { name: 'Continue' }).click();
|
|
||||||
|
|
||||||
await page.getByText('Text').nth(1).click();
|
|
||||||
await page.getByRole('button', { name: 'Advanced settings' }).click();
|
|
||||||
|
|
||||||
await expect(page.getByRole('heading', { name: 'Advanced settings' })).toBeVisible();
|
|
||||||
await expect(
|
|
||||||
page
|
|
||||||
.locator('div')
|
|
||||||
.filter({ hasText: /^Required field$/ })
|
|
||||||
.getByRole('switch'),
|
|
||||||
).toBeChecked();
|
|
||||||
|
|
||||||
await expect(page.getByRole('combobox')).toHaveText('Right');
|
|
||||||
});
|
|
||||||
});
|
|
||||||
@ -1,12 +1,9 @@
|
|||||||
import { expect, test } from '@playwright/test';
|
import { expect, test } from '@playwright/test';
|
||||||
import { DocumentSigningOrder, RecipientRole } from '@prisma/client';
|
|
||||||
import { customAlphabet } from 'nanoid';
|
import { customAlphabet } from 'nanoid';
|
||||||
|
|
||||||
import { NEXT_PUBLIC_WEBAPP_URL } from '@documenso/lib/constants/app';
|
import { NEXT_PUBLIC_WEBAPP_URL } from '@documenso/lib/constants/app';
|
||||||
import { createDocumentAuthOptions } from '@documenso/lib/utils/document-auth';
|
import { createDocumentAuthOptions } from '@documenso/lib/utils/document-auth';
|
||||||
import { mapSecondaryIdToTemplateId } from '@documenso/lib/utils/envelope';
|
|
||||||
import { formatDirectTemplatePath } from '@documenso/lib/utils/templates';
|
import { formatDirectTemplatePath } from '@documenso/lib/utils/templates';
|
||||||
import { prisma } from '@documenso/prisma';
|
|
||||||
import { seedTeam } from '@documenso/prisma/seed/teams';
|
import { seedTeam } from '@documenso/prisma/seed/teams';
|
||||||
import { seedDirectTemplate, seedTemplate } from '@documenso/prisma/seed/templates';
|
import { seedDirectTemplate, seedTemplate } from '@documenso/prisma/seed/templates';
|
||||||
import { seedTestEmail, seedUser } from '@documenso/prisma/seed/users';
|
import { seedTestEmail, seedUser } from '@documenso/prisma/seed/users';
|
||||||
@ -124,7 +121,7 @@ test('[DIRECT_TEMPLATES]: delete direct template link', async ({ page }) => {
|
|||||||
await expect(page.getByText('404 not found')).toBeVisible();
|
await expect(page.getByText('404 not found')).toBeVisible();
|
||||||
});
|
});
|
||||||
|
|
||||||
test('[DIRECT_TEMPLATES]: V1 direct template link auth access', async ({ page }) => {
|
test('[DIRECT_TEMPLATES]: direct template link auth access', async ({ page }) => {
|
||||||
const { user, team } = await seedUser();
|
const { user, team } = await seedUser();
|
||||||
|
|
||||||
const directTemplateWithAuth = await seedDirectTemplate({
|
const directTemplateWithAuth = await seedDirectTemplate({
|
||||||
@ -156,53 +153,6 @@ test('[DIRECT_TEMPLATES]: V1 direct template link auth access', async ({ page })
|
|||||||
|
|
||||||
await expect(page.getByRole('heading', { name: 'General' })).toBeVisible();
|
await expect(page.getByRole('heading', { name: 'General' })).toBeVisible();
|
||||||
await expect(page.getByLabel('Email')).toBeDisabled();
|
await expect(page.getByLabel('Email')).toBeDisabled();
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Continue' }).click();
|
|
||||||
await page.getByRole('button', { name: 'Complete' }).click();
|
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Sign' }).click();
|
|
||||||
await page.waitForURL(/\/sign/);
|
|
||||||
await expect(page.getByRole('heading', { name: 'Document Signed' })).toBeVisible();
|
|
||||||
});
|
|
||||||
|
|
||||||
test('[DIRECT_TEMPLATES]: V2 direct template link auth access', async ({ page }) => {
|
|
||||||
const { user, team } = await seedUser();
|
|
||||||
|
|
||||||
const directTemplateWithAuth = await seedDirectTemplate({
|
|
||||||
title: 'Personal direct template link',
|
|
||||||
userId: user.id,
|
|
||||||
teamId: team.id,
|
|
||||||
internalVersion: 2,
|
|
||||||
createTemplateOptions: {
|
|
||||||
authOptions: createDocumentAuthOptions({
|
|
||||||
globalAccessAuth: ['ACCOUNT'],
|
|
||||||
globalActionAuth: [],
|
|
||||||
}),
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
const directTemplatePath = formatDirectTemplatePath(
|
|
||||||
directTemplateWithAuth.directLink?.token || '',
|
|
||||||
);
|
|
||||||
|
|
||||||
await page.goto(directTemplatePath);
|
|
||||||
|
|
||||||
await expect(page.getByText('Authentication required')).toBeVisible();
|
|
||||||
|
|
||||||
await apiSignin({
|
|
||||||
page,
|
|
||||||
email: user.email,
|
|
||||||
});
|
|
||||||
|
|
||||||
await page.goto(directTemplatePath);
|
|
||||||
|
|
||||||
await expect(page.getByRole('heading', { name: 'Personal direct template link' })).toBeVisible();
|
|
||||||
await page.getByRole('button', { name: 'Complete' }).click();
|
|
||||||
await expect(page.getByLabel('Your Email')).not.toBeVisible();
|
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Sign' }).click();
|
|
||||||
await page.waitForURL(/\/sign/);
|
|
||||||
await expect(page.getByRole('heading', { name: 'Document Signed' })).toBeVisible();
|
|
||||||
});
|
});
|
||||||
|
|
||||||
test('[DIRECT_TEMPLATES]: use direct template link with 1 recipient', async ({ page }) => {
|
test('[DIRECT_TEMPLATES]: use direct template link with 1 recipient', async ({ page }) => {
|
||||||
@ -225,9 +175,6 @@ test('[DIRECT_TEMPLATES]: use direct template link with 1 recipient', async ({ p
|
|||||||
await page.getByPlaceholder('recipient@documenso.com').fill(seedTestEmail());
|
await page.getByPlaceholder('recipient@documenso.com').fill(seedTestEmail());
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Continue' }).click();
|
await page.getByRole('button', { name: 'Continue' }).click();
|
||||||
|
|
||||||
await expect(page.getByText('Next Recipient Name')).not.toBeVisible();
|
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Complete' }).click();
|
await page.getByRole('button', { name: 'Complete' }).click();
|
||||||
await page.getByRole('button', { name: 'Sign' }).click();
|
await page.getByRole('button', { name: 'Sign' }).click();
|
||||||
await page.waitForURL(/\/sign/);
|
await page.waitForURL(/\/sign/);
|
||||||
@ -236,173 +183,3 @@ test('[DIRECT_TEMPLATES]: use direct template link with 1 recipient', async ({ p
|
|||||||
// Add a longer waiting period to ensure document status is updated
|
// Add a longer waiting period to ensure document status is updated
|
||||||
await page.waitForTimeout(3000);
|
await page.waitForTimeout(3000);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('[DIRECT_TEMPLATES]: V1 use direct template link with 2 recipients with next signer dictation', async ({
|
|
||||||
page,
|
|
||||||
}) => {
|
|
||||||
const { team, owner, organisation } = await seedTeam({
|
|
||||||
createTeamMembers: 1,
|
|
||||||
});
|
|
||||||
|
|
||||||
// Should be visible to team members.
|
|
||||||
const template = await seedDirectTemplate({
|
|
||||||
title: 'Team direct template link 1',
|
|
||||||
userId: owner.id,
|
|
||||||
teamId: team.id,
|
|
||||||
});
|
|
||||||
|
|
||||||
await prisma.documentMeta.update({
|
|
||||||
where: {
|
|
||||||
id: template.documentMetaId,
|
|
||||||
},
|
|
||||||
data: {
|
|
||||||
allowDictateNextSigner: true,
|
|
||||||
signingOrder: DocumentSigningOrder.SEQUENTIAL,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
const originalName = 'Signer 2';
|
|
||||||
const originalSecondSignerEmail = seedTestEmail();
|
|
||||||
|
|
||||||
// Add another signer
|
|
||||||
await prisma.recipient.create({
|
|
||||||
data: {
|
|
||||||
signingOrder: 2,
|
|
||||||
envelopeId: template.id,
|
|
||||||
email: originalSecondSignerEmail,
|
|
||||||
name: originalName,
|
|
||||||
token: Math.random().toString().slice(2, 7),
|
|
||||||
role: RecipientRole.SIGNER,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
// Check that the direct template link is accessible.
|
|
||||||
await page.goto(formatDirectTemplatePath(template.directLink?.token || ''));
|
|
||||||
await expect(page.getByRole('heading', { name: 'General' })).toBeVisible();
|
|
||||||
|
|
||||||
await page.waitForTimeout(100);
|
|
||||||
await page.getByPlaceholder('recipient@documenso.com').fill(seedTestEmail());
|
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Continue' }).click();
|
|
||||||
await page.getByRole('button', { name: 'Complete' }).click();
|
|
||||||
|
|
||||||
await expect(page.getByText('Next Recipient Name')).toBeVisible();
|
|
||||||
|
|
||||||
const nextRecipientNameInputValue = await page.getByLabel('Next Recipient Name').inputValue();
|
|
||||||
expect(nextRecipientNameInputValue).toBe(originalName);
|
|
||||||
|
|
||||||
const nextRecipientEmailInputValue = await page.getByLabel('Next Recipient Email').inputValue();
|
|
||||||
expect(nextRecipientEmailInputValue).toBe(originalSecondSignerEmail);
|
|
||||||
|
|
||||||
const newName = 'Hello';
|
|
||||||
const newSecondSignerEmail = seedTestEmail();
|
|
||||||
|
|
||||||
await page.getByLabel('Next Recipient Email').fill(newSecondSignerEmail);
|
|
||||||
await page.getByLabel('Next Recipient Name').fill(newName);
|
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Sign' }).click();
|
|
||||||
await page.waitForURL(/\/sign/);
|
|
||||||
await expect(page.getByRole('heading', { name: 'Document Signed' })).toBeVisible();
|
|
||||||
|
|
||||||
const createdEnvelopeRecipients = await prisma.recipient.findMany({
|
|
||||||
where: {
|
|
||||||
envelope: {
|
|
||||||
templateId: mapSecondaryIdToTemplateId(template.secondaryId),
|
|
||||||
},
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
const updatedSecondRecipient = createdEnvelopeRecipients.find(
|
|
||||||
(recipient) => recipient.signingOrder === 2,
|
|
||||||
);
|
|
||||||
|
|
||||||
expect(updatedSecondRecipient?.name).toBe(newName);
|
|
||||||
expect(updatedSecondRecipient?.email).toBe(newSecondSignerEmail);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('[DIRECT_TEMPLATES]: V2 use direct template link with 2 recipients with next signer dictation', async ({
|
|
||||||
page,
|
|
||||||
}) => {
|
|
||||||
const { team, owner, organisation } = await seedTeam({
|
|
||||||
createTeamMembers: 1,
|
|
||||||
});
|
|
||||||
|
|
||||||
// Should be visible to team members.
|
|
||||||
const template = await seedDirectTemplate({
|
|
||||||
title: 'Team direct template link 1',
|
|
||||||
userId: owner.id,
|
|
||||||
teamId: team.id,
|
|
||||||
internalVersion: 2,
|
|
||||||
});
|
|
||||||
|
|
||||||
await prisma.documentMeta.update({
|
|
||||||
where: {
|
|
||||||
id: template.documentMetaId,
|
|
||||||
},
|
|
||||||
data: {
|
|
||||||
allowDictateNextSigner: true,
|
|
||||||
signingOrder: DocumentSigningOrder.SEQUENTIAL,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
const originalName = 'Signer 2';
|
|
||||||
const originalSecondSignerEmail = seedTestEmail();
|
|
||||||
|
|
||||||
// Add another signer
|
|
||||||
await prisma.recipient.create({
|
|
||||||
data: {
|
|
||||||
signingOrder: 2,
|
|
||||||
envelopeId: template.id,
|
|
||||||
email: originalSecondSignerEmail,
|
|
||||||
name: originalName,
|
|
||||||
token: Math.random().toString().slice(2, 7),
|
|
||||||
role: RecipientRole.SIGNER,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
// Check that the direct template link is accessible.
|
|
||||||
await page.goto(formatDirectTemplatePath(template.directLink?.token || ''));
|
|
||||||
await expect(page.getByRole('heading', { name: 'Team direct template link 1' })).toBeVisible();
|
|
||||||
await page.waitForTimeout(100);
|
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Complete' }).click();
|
|
||||||
|
|
||||||
const currentName = 'John Doe';
|
|
||||||
const currentEmail = seedTestEmail();
|
|
||||||
|
|
||||||
await page.getByPlaceholder('Enter Your Name').fill(currentName);
|
|
||||||
await page.getByPlaceholder('Enter Your Email').fill(currentEmail);
|
|
||||||
|
|
||||||
await expect(page.getByText('Next Recipient Name')).toBeVisible();
|
|
||||||
|
|
||||||
const nextRecipientNameInputValue = await page.getByLabel('Next Recipient Name').inputValue();
|
|
||||||
expect(nextRecipientNameInputValue).toBe(originalName);
|
|
||||||
|
|
||||||
const nextRecipientEmailInputValue = await page.getByLabel('Next Recipient Email').inputValue();
|
|
||||||
expect(nextRecipientEmailInputValue).toBe(originalSecondSignerEmail);
|
|
||||||
|
|
||||||
const newName = 'Hello';
|
|
||||||
const newSecondSignerEmail = seedTestEmail();
|
|
||||||
|
|
||||||
await page.getByLabel('Next Recipient Email').fill(newSecondSignerEmail);
|
|
||||||
await page.getByLabel('Next Recipient Name').fill(newName);
|
|
||||||
|
|
||||||
await page.getByRole('button', { name: 'Sign' }).click();
|
|
||||||
await page.waitForURL(/\/sign/);
|
|
||||||
await expect(page.getByRole('heading', { name: 'Document Signed' })).toBeVisible();
|
|
||||||
|
|
||||||
const createdEnvelopeRecipients = await prisma.recipient.findMany({
|
|
||||||
where: {
|
|
||||||
envelope: {
|
|
||||||
templateId: mapSecondaryIdToTemplateId(template.secondaryId),
|
|
||||||
},
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
const updatedSecondRecipient = createdEnvelopeRecipients.find(
|
|
||||||
(recipient) => recipient.signingOrder === 2,
|
|
||||||
);
|
|
||||||
|
|
||||||
expect(updatedSecondRecipient?.name).toBe(newName);
|
|
||||||
expect(updatedSecondRecipient?.email).toBe(newSecondSignerEmail);
|
|
||||||
});
|
|
||||||
|
|||||||
@ -1,5 +1,7 @@
|
|||||||
|
import { EnvelopeType, TeamMemberRole } from '@prisma/client';
|
||||||
import type { Prisma, User } from '@prisma/client';
|
import type { Prisma, User } from '@prisma/client';
|
||||||
import { DocumentVisibility, EnvelopeType, SigningStatus, TeamMemberRole } from '@prisma/client';
|
import { SigningStatus } from '@prisma/client';
|
||||||
|
import { DocumentVisibility } from '@prisma/client';
|
||||||
import { DateTime } from 'luxon';
|
import { DateTime } from 'luxon';
|
||||||
import { match } from 'ts-pattern';
|
import { match } from 'ts-pattern';
|
||||||
|
|
||||||
@ -213,14 +215,13 @@ const getTeamCounts = async (options: GetTeamCountsOption) => {
|
|||||||
],
|
],
|
||||||
};
|
};
|
||||||
|
|
||||||
const rootPageFilter = folderId === undefined ? { folderId: null } : {};
|
|
||||||
|
|
||||||
let ownerCountsWhereInput: Prisma.EnvelopeWhereInput = {
|
let ownerCountsWhereInput: Prisma.EnvelopeWhereInput = {
|
||||||
type: EnvelopeType.DOCUMENT,
|
type: EnvelopeType.DOCUMENT,
|
||||||
userId: userIdWhereClause,
|
userId: userIdWhereClause,
|
||||||
createdAt,
|
createdAt,
|
||||||
teamId,
|
teamId,
|
||||||
deletedAt: null,
|
deletedAt: null,
|
||||||
|
folderId,
|
||||||
};
|
};
|
||||||
|
|
||||||
let notSignedCountsGroupByArgs = null;
|
let notSignedCountsGroupByArgs = null;
|
||||||
@ -264,16 +265,8 @@ const getTeamCounts = async (options: GetTeamCountsOption) => {
|
|||||||
|
|
||||||
ownerCountsWhereInput = {
|
ownerCountsWhereInput = {
|
||||||
...ownerCountsWhereInput,
|
...ownerCountsWhereInput,
|
||||||
AND: [
|
...visibilityFiltersWhereInput,
|
||||||
...(Array.isArray(visibilityFiltersWhereInput.AND)
|
...searchFilter,
|
||||||
? visibilityFiltersWhereInput.AND
|
|
||||||
: visibilityFiltersWhereInput.AND
|
|
||||||
? [visibilityFiltersWhereInput.AND]
|
|
||||||
: []),
|
|
||||||
searchFilter,
|
|
||||||
rootPageFilter,
|
|
||||||
folderId ? { folderId } : {},
|
|
||||||
],
|
|
||||||
};
|
};
|
||||||
|
|
||||||
if (teamEmail) {
|
if (teamEmail) {
|
||||||
@ -292,7 +285,6 @@ const getTeamCounts = async (options: GetTeamCountsOption) => {
|
|||||||
},
|
},
|
||||||
],
|
],
|
||||||
deletedAt: null,
|
deletedAt: null,
|
||||||
AND: [searchFilter, rootPageFilter, folderId ? { folderId } : {}],
|
|
||||||
};
|
};
|
||||||
|
|
||||||
notSignedCountsGroupByArgs = {
|
notSignedCountsGroupByArgs = {
|
||||||
@ -304,6 +296,7 @@ const getTeamCounts = async (options: GetTeamCountsOption) => {
|
|||||||
type: EnvelopeType.DOCUMENT,
|
type: EnvelopeType.DOCUMENT,
|
||||||
userId: userIdWhereClause,
|
userId: userIdWhereClause,
|
||||||
createdAt,
|
createdAt,
|
||||||
|
folderId,
|
||||||
status: ExtendedDocumentStatus.PENDING,
|
status: ExtendedDocumentStatus.PENDING,
|
||||||
recipients: {
|
recipients: {
|
||||||
some: {
|
some: {
|
||||||
@ -313,7 +306,6 @@ const getTeamCounts = async (options: GetTeamCountsOption) => {
|
|||||||
},
|
},
|
||||||
},
|
},
|
||||||
deletedAt: null,
|
deletedAt: null,
|
||||||
AND: [searchFilter, rootPageFilter, folderId ? { folderId } : {}],
|
|
||||||
},
|
},
|
||||||
} satisfies Prisma.EnvelopeGroupByArgs;
|
} satisfies Prisma.EnvelopeGroupByArgs;
|
||||||
|
|
||||||
@ -326,6 +318,7 @@ const getTeamCounts = async (options: GetTeamCountsOption) => {
|
|||||||
type: EnvelopeType.DOCUMENT,
|
type: EnvelopeType.DOCUMENT,
|
||||||
userId: userIdWhereClause,
|
userId: userIdWhereClause,
|
||||||
createdAt,
|
createdAt,
|
||||||
|
folderId,
|
||||||
OR: [
|
OR: [
|
||||||
{
|
{
|
||||||
status: ExtendedDocumentStatus.PENDING,
|
status: ExtendedDocumentStatus.PENDING,
|
||||||
@ -349,7 +342,6 @@ const getTeamCounts = async (options: GetTeamCountsOption) => {
|
|||||||
},
|
},
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
AND: [searchFilter, rootPageFilter, folderId ? { folderId } : {}],
|
|
||||||
},
|
},
|
||||||
} satisfies Prisma.EnvelopeGroupByArgs;
|
} satisfies Prisma.EnvelopeGroupByArgs;
|
||||||
}
|
}
|
||||||
|
|||||||
@ -0,0 +1,84 @@
|
|||||||
|
import { deletedAccountServiceAccount } from '@documenso/lib/server-only/user/service-accounts/deleted-account';
|
||||||
|
import { prisma } from '@documenso/prisma';
|
||||||
|
import { DocumentStatus } from '@documenso/prisma/client';
|
||||||
|
|
||||||
|
type HandleDocumentOwnershipOnDeletionOptions = {
|
||||||
|
documentIds: number[];
|
||||||
|
organisationOwnerId: number;
|
||||||
|
};
|
||||||
|
|
||||||
|
export const handleDocumentOwnershipOnDeletion = async ({
|
||||||
|
documentIds,
|
||||||
|
organisationOwnerId,
|
||||||
|
}: HandleDocumentOwnershipOnDeletionOptions) => {
|
||||||
|
if (documentIds.length === 0) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const serviceAccount = await deletedAccountServiceAccount();
|
||||||
|
const serviceAccountTeam = serviceAccount.ownedOrganisations[0].teams[0];
|
||||||
|
|
||||||
|
await prisma.document.deleteMany({
|
||||||
|
where: {
|
||||||
|
id: {
|
||||||
|
in: documentIds,
|
||||||
|
},
|
||||||
|
status: DocumentStatus.DRAFT,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
const organisationOwner = await prisma.user.findUnique({
|
||||||
|
where: {
|
||||||
|
id: organisationOwnerId,
|
||||||
|
},
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
ownedOrganisations: {
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
teams: {
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
if (organisationOwner && organisationOwner.ownedOrganisations.length > 0) {
|
||||||
|
const ownerPersonalTeam = organisationOwner.ownedOrganisations[0].teams[0];
|
||||||
|
|
||||||
|
await prisma.document.updateMany({
|
||||||
|
where: {
|
||||||
|
id: {
|
||||||
|
in: documentIds,
|
||||||
|
},
|
||||||
|
status: {
|
||||||
|
in: [DocumentStatus.PENDING, DocumentStatus.REJECTED, DocumentStatus.COMPLETED],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
data: {
|
||||||
|
userId: organisationOwner.id,
|
||||||
|
teamId: ownerPersonalTeam.id,
|
||||||
|
deletedAt: new Date(),
|
||||||
|
},
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
await prisma.document.updateMany({
|
||||||
|
where: {
|
||||||
|
id: {
|
||||||
|
in: documentIds,
|
||||||
|
},
|
||||||
|
status: {
|
||||||
|
in: [DocumentStatus.PENDING, DocumentStatus.REJECTED, DocumentStatus.COMPLETED],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
data: {
|
||||||
|
userId: serviceAccount.id,
|
||||||
|
teamId: serviceAccountTeam.id,
|
||||||
|
deletedAt: new Date(),
|
||||||
|
},
|
||||||
|
});
|
||||||
|
}
|
||||||
|
};
|
||||||
@ -10,7 +10,6 @@ import {
|
|||||||
} from '@prisma/client';
|
} from '@prisma/client';
|
||||||
|
|
||||||
import { AppError, AppErrorCode } from '@documenso/lib/errors/app-error';
|
import { AppError, AppErrorCode } from '@documenso/lib/errors/app-error';
|
||||||
import { insertFieldsFromPlaceholdersInPDF } from '@documenso/lib/server-only/pdf/auto-place-fields';
|
|
||||||
import { normalizePdf as makeNormalizedPdf } from '@documenso/lib/server-only/pdf/normalize-pdf';
|
import { normalizePdf as makeNormalizedPdf } from '@documenso/lib/server-only/pdf/normalize-pdf';
|
||||||
import { DOCUMENT_AUDIT_LOG_TYPE } from '@documenso/lib/types/document-audit-logs';
|
import { DOCUMENT_AUDIT_LOG_TYPE } from '@documenso/lib/types/document-audit-logs';
|
||||||
import type { ApiRequestMetadata } from '@documenso/lib/universal/extract-request-metadata';
|
import type { ApiRequestMetadata } from '@documenso/lib/universal/extract-request-metadata';
|
||||||
@ -234,7 +233,7 @@ export const createEnvelope = async ({
|
|||||||
? await incrementDocumentId().then((v) => v.formattedDocumentId)
|
? await incrementDocumentId().then((v) => v.formattedDocumentId)
|
||||||
: await incrementTemplateId().then((v) => v.formattedTemplateId);
|
: await incrementTemplateId().then((v) => v.formattedTemplateId);
|
||||||
|
|
||||||
const createdEnvelope = await prisma.$transaction(async (tx) => {
|
return await prisma.$transaction(async (tx) => {
|
||||||
const envelope = await tx.envelope.create({
|
const envelope = await tx.envelope.create({
|
||||||
data: {
|
data: {
|
||||||
id: prefixedId('envelope'),
|
id: prefixedId('envelope'),
|
||||||
@ -354,12 +353,8 @@ export const createEnvelope = async ({
|
|||||||
recipients: true,
|
recipients: true,
|
||||||
fields: true,
|
fields: true,
|
||||||
folder: true,
|
folder: true,
|
||||||
|
envelopeItems: true,
|
||||||
envelopeAttachments: true,
|
envelopeAttachments: true,
|
||||||
envelopeItems: {
|
|
||||||
include: {
|
|
||||||
documentData: true,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
@ -395,51 +390,4 @@ export const createEnvelope = async ({
|
|||||||
|
|
||||||
return createdEnvelope;
|
return createdEnvelope;
|
||||||
});
|
});
|
||||||
|
|
||||||
for (const envelopeItem of createdEnvelope.envelopeItems) {
|
|
||||||
const buffer = await getFileServerSide(envelopeItem.documentData);
|
|
||||||
|
|
||||||
// Use normalized PDF if normalizePdf was true, otherwise use original
|
|
||||||
const pdfToProcess = normalizePdf
|
|
||||||
? await makeNormalizedPdf(Buffer.from(buffer))
|
|
||||||
: Buffer.from(buffer);
|
|
||||||
|
|
||||||
await insertFieldsFromPlaceholdersInPDF(
|
|
||||||
pdfToProcess,
|
|
||||||
userId,
|
|
||||||
teamId,
|
|
||||||
{
|
|
||||||
type: 'envelopeId',
|
|
||||||
id: createdEnvelope.id,
|
|
||||||
},
|
|
||||||
requestMetadata,
|
|
||||||
envelopeItem.id,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
const finalEnvelope = await prisma.envelope.findFirst({
|
|
||||||
where: {
|
|
||||||
id: createdEnvelope.id,
|
|
||||||
},
|
|
||||||
include: {
|
|
||||||
documentMeta: true,
|
|
||||||
recipients: true,
|
|
||||||
fields: true,
|
|
||||||
folder: true,
|
|
||||||
envelopeAttachments: true,
|
|
||||||
envelopeItems: {
|
|
||||||
include: {
|
|
||||||
documentData: true,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
if (!finalEnvelope) {
|
|
||||||
throw new AppError(AppErrorCode.NOT_FOUND, {
|
|
||||||
message: 'Envelope not found',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
return finalEnvelope;
|
|
||||||
};
|
};
|
||||||
|
|||||||
@ -1,11 +1,10 @@
|
|||||||
import { DocumentStatus, EnvelopeType } from '@prisma/client';
|
import { DocumentStatus, EnvelopeType } from '@prisma/client';
|
||||||
import { match } from 'ts-pattern';
|
|
||||||
|
|
||||||
import { prisma } from '@documenso/prisma';
|
import { prisma } from '@documenso/prisma';
|
||||||
|
|
||||||
import { AppError, AppErrorCode } from '../../errors/app-error';
|
import { AppError, AppErrorCode } from '../../errors/app-error';
|
||||||
import { DocumentAccessAuth, type TDocumentAuthMethods } from '../../types/document-auth';
|
import type { TDocumentAuthMethods } from '../../types/document-auth';
|
||||||
import { extractDocumentAuthMethods } from '../../utils/document-auth';
|
import { isRecipientAuthorized } from '../document/is-recipient-authorized';
|
||||||
import { getTeamSettings } from '../team/get-team-settings';
|
import { getTeamSettings } from '../team/get-team-settings';
|
||||||
import type { EnvelopeForSigningResponse } from './get-envelope-for-recipient-signing';
|
import type { EnvelopeForSigningResponse } from './get-envelope-for-recipient-signing';
|
||||||
import { ZEnvelopeForSigningResponse } from './get-envelope-for-recipient-signing';
|
import { ZEnvelopeForSigningResponse } from './get-envelope-for-recipient-signing';
|
||||||
@ -99,28 +98,14 @@ export const getEnvelopeForDirectTemplateSigning = async ({
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
// Currently not using this since for direct templates "User" access means they just need to be
|
const documentAccessValid = await isRecipientAuthorized({
|
||||||
// logged in.
|
type: 'ACCESS',
|
||||||
// const documentAccessValid = await isRecipientAuthorized({
|
documentAuthOptions: envelope.authOptions,
|
||||||
// type: 'ACCESS',
|
recipient,
|
||||||
// documentAuthOptions: envelope.authOptions,
|
userId,
|
||||||
// recipient,
|
authOptions: accessAuth,
|
||||||
// userId,
|
|
||||||
// authOptions: accessAuth,
|
|
||||||
// });
|
|
||||||
|
|
||||||
const { derivedRecipientAccessAuth } = extractDocumentAuthMethods({
|
|
||||||
documentAuth: envelope.authOptions,
|
|
||||||
});
|
});
|
||||||
|
|
||||||
// Ensure typesafety when we add more options.
|
|
||||||
const documentAccessValid = derivedRecipientAccessAuth.every((auth) =>
|
|
||||||
match(auth)
|
|
||||||
.with(DocumentAccessAuth.ACCOUNT, () => Boolean(userId))
|
|
||||||
.with(DocumentAccessAuth.TWO_FACTOR_AUTH, () => true)
|
|
||||||
.exhaustive(),
|
|
||||||
);
|
|
||||||
|
|
||||||
if (!documentAccessValid) {
|
if (!documentAccessValid) {
|
||||||
throw new AppError(AppErrorCode.UNAUTHORIZED, {
|
throw new AppError(AppErrorCode.UNAUTHORIZED, {
|
||||||
message: 'Invalid access values',
|
message: 'Invalid access values',
|
||||||
|
|||||||
@ -54,3 +54,54 @@ export const getEnvelopeRequiredAccessData = async ({ token }: { token: string }
|
|||||||
recipientHasAccount: Boolean(recipientUserAccount),
|
recipientHasAccount: Boolean(recipientUserAccount),
|
||||||
} as const;
|
} as const;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export const getEnvelopeDirectTemplateRequiredAccessData = async ({ token }: { token: string }) => {
|
||||||
|
const envelope = await prisma.envelope.findFirst({
|
||||||
|
where: {
|
||||||
|
type: EnvelopeType.TEMPLATE,
|
||||||
|
directLink: {
|
||||||
|
enabled: true,
|
||||||
|
token,
|
||||||
|
},
|
||||||
|
status: DocumentStatus.DRAFT,
|
||||||
|
},
|
||||||
|
include: {
|
||||||
|
recipients: {
|
||||||
|
where: {
|
||||||
|
token,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
directLink: true,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
if (!envelope) {
|
||||||
|
throw new AppError(AppErrorCode.NOT_FOUND, {
|
||||||
|
message: 'Envelope not found',
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
const recipient = envelope.recipients.find(
|
||||||
|
(r) => r.id === envelope.directLink?.directTemplateRecipientId,
|
||||||
|
);
|
||||||
|
|
||||||
|
if (!recipient) {
|
||||||
|
throw new AppError(AppErrorCode.NOT_FOUND, {
|
||||||
|
message: 'Recipient not found',
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
const recipientUserAccount = await prisma.user.findFirst({
|
||||||
|
where: {
|
||||||
|
email: recipient.email.toLowerCase(),
|
||||||
|
},
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
return {
|
||||||
|
recipientEmail: recipient.email,
|
||||||
|
recipientHasAccount: Boolean(recipientUserAccount),
|
||||||
|
} as const;
|
||||||
|
};
|
||||||
|
|||||||
@ -1,517 +0,0 @@
|
|||||||
import { PDFDocument, rgb } from '@cantoo/pdf-lib';
|
|
||||||
import type { Recipient } from '@prisma/client';
|
|
||||||
import { EnvelopeType, FieldType, RecipientRole } from '@prisma/client';
|
|
||||||
import PDFParser from 'pdf2json';
|
|
||||||
import { match } from 'ts-pattern';
|
|
||||||
|
|
||||||
import { AppError, AppErrorCode } from '@documenso/lib/errors/app-error';
|
|
||||||
import { getEnvelopeWhereInput } from '@documenso/lib/server-only/envelope/get-envelope-by-id';
|
|
||||||
import { createEnvelopeFields } from '@documenso/lib/server-only/field/create-envelope-fields';
|
|
||||||
import { createDocumentRecipients } from '@documenso/lib/server-only/recipient/create-document-recipients';
|
|
||||||
import { createTemplateRecipients } from '@documenso/lib/server-only/recipient/create-template-recipients';
|
|
||||||
import { type TFieldAndMeta, ZFieldAndMetaSchema } from '@documenso/lib/types/field-meta';
|
|
||||||
import type { ApiRequestMetadata } from '@documenso/lib/universal/extract-request-metadata';
|
|
||||||
import type { EnvelopeIdOptions } from '@documenso/lib/utils/envelope';
|
|
||||||
import { mapSecondaryIdToTemplateId } from '@documenso/lib/utils/envelope';
|
|
||||||
import { prisma } from '@documenso/prisma';
|
|
||||||
|
|
||||||
import { getPageSize } from './get-page-size';
|
|
||||||
|
|
||||||
type TextPosition = {
|
|
||||||
text: string;
|
|
||||||
x: number;
|
|
||||||
y: number;
|
|
||||||
w: number;
|
|
||||||
};
|
|
||||||
|
|
||||||
type CharIndexMapping = {
|
|
||||||
textPositionIndex: number;
|
|
||||||
};
|
|
||||||
|
|
||||||
type PlaceholderInfo = {
|
|
||||||
placeholder: string;
|
|
||||||
recipient: string;
|
|
||||||
fieldAndMeta: TFieldAndMeta;
|
|
||||||
page: number;
|
|
||||||
x: number;
|
|
||||||
y: number;
|
|
||||||
width: number;
|
|
||||||
height: number;
|
|
||||||
pageWidth: number;
|
|
||||||
pageHeight: number;
|
|
||||||
};
|
|
||||||
|
|
||||||
type FieldToCreate = TFieldAndMeta & {
|
|
||||||
envelopeItemId?: string;
|
|
||||||
recipientId: number;
|
|
||||||
pageNumber: number;
|
|
||||||
pageX: number;
|
|
||||||
pageY: number;
|
|
||||||
width: number;
|
|
||||||
height: number;
|
|
||||||
};
|
|
||||||
|
|
||||||
type RecipientPlaceholderInfo = {
|
|
||||||
email: string;
|
|
||||||
name: string;
|
|
||||||
recipientIndex: number;
|
|
||||||
};
|
|
||||||
|
|
||||||
/*
|
|
||||||
Questions for later:
|
|
||||||
- Does it handle multi-page PDFs? ✅ YES! ✅
|
|
||||||
- Does it handle multiple recipients on the same page? ✅ YES! ✅
|
|
||||||
- Does it handle multiple recipients on multiple pages? ✅ YES! ✅
|
|
||||||
- What happens with incorrect placeholders? E.g. those containing non-accepted properties.
|
|
||||||
- The placeholder data is dynamic. How to handle this parsing? Perhaps we need to do it similar to the fieldMeta parsing. ✅
|
|
||||||
- Need to handle envelopes with multiple items. ✅
|
|
||||||
*/
|
|
||||||
|
|
||||||
/*
|
|
||||||
Parse field type string to FieldType enum.
|
|
||||||
Normalizes the input (uppercase, trim) and validates it's a valid field type.
|
|
||||||
This ensures we handle case variations and whitespace, and provides clear error messages.
|
|
||||||
*/
|
|
||||||
const parseFieldType = (fieldTypeString: string): FieldType => {
|
|
||||||
const normalizedType = fieldTypeString.toUpperCase().trim();
|
|
||||||
|
|
||||||
return match(normalizedType)
|
|
||||||
.with('SIGNATURE', () => FieldType.SIGNATURE)
|
|
||||||
.with('FREE_SIGNATURE', () => FieldType.FREE_SIGNATURE)
|
|
||||||
.with('INITIALS', () => FieldType.INITIALS)
|
|
||||||
.with('NAME', () => FieldType.NAME)
|
|
||||||
.with('EMAIL', () => FieldType.EMAIL)
|
|
||||||
.with('DATE', () => FieldType.DATE)
|
|
||||||
.with('TEXT', () => FieldType.TEXT)
|
|
||||||
.with('NUMBER', () => FieldType.NUMBER)
|
|
||||||
.with('RADIO', () => FieldType.RADIO)
|
|
||||||
.with('CHECKBOX', () => FieldType.CHECKBOX)
|
|
||||||
.with('DROPDOWN', () => FieldType.DROPDOWN)
|
|
||||||
.otherwise(() => {
|
|
||||||
throw new AppError(AppErrorCode.INVALID_BODY, {
|
|
||||||
message: `Invalid field type: ${fieldTypeString}`,
|
|
||||||
});
|
|
||||||
});
|
|
||||||
};
|
|
||||||
|
|
||||||
/*
|
|
||||||
Transform raw field metadata from placeholder format to schema format.
|
|
||||||
Users should provide properly capitalized property names (e.g., readOnly, fontSize, textAlign).
|
|
||||||
Converts string values to proper types (booleans, numbers).
|
|
||||||
*/
|
|
||||||
const parseFieldMeta = (
|
|
||||||
rawFieldMeta: Record<string, string>,
|
|
||||||
fieldType: FieldType,
|
|
||||||
): Record<string, unknown> | undefined => {
|
|
||||||
if (fieldType === FieldType.SIGNATURE || fieldType === FieldType.FREE_SIGNATURE) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (Object.keys(rawFieldMeta).length === 0) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const fieldTypeString = String(fieldType).toLowerCase();
|
|
||||||
|
|
||||||
const parsedFieldMeta: Record<string, boolean | number | string> = {
|
|
||||||
type: fieldTypeString,
|
|
||||||
};
|
|
||||||
|
|
||||||
/*
|
|
||||||
rawFieldMeta is an object with string keys and string values.
|
|
||||||
It contains string values because the PDF parser returns the values as strings.
|
|
||||||
|
|
||||||
E.g. { 'required': 'true', 'fontSize': '12', 'maxValue': '100', 'minValue': '0', 'characterLimit': '100' }
|
|
||||||
*/
|
|
||||||
const rawFieldMetaEntries = Object.entries(rawFieldMeta);
|
|
||||||
|
|
||||||
for (const [property, value] of rawFieldMetaEntries) {
|
|
||||||
if (property === 'readOnly' || property === 'required') {
|
|
||||||
parsedFieldMeta[property] = value === 'true';
|
|
||||||
} else if (
|
|
||||||
property === 'fontSize' ||
|
|
||||||
property === 'maxValue' ||
|
|
||||||
property === 'minValue' ||
|
|
||||||
property === 'characterLimit'
|
|
||||||
) {
|
|
||||||
const numValue = Number(value);
|
|
||||||
|
|
||||||
if (!Number.isNaN(numValue)) {
|
|
||||||
parsedFieldMeta[property] = numValue;
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
parsedFieldMeta[property] = value;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
return parsedFieldMeta;
|
|
||||||
};
|
|
||||||
|
|
||||||
export const extractPlaceholdersFromPDF = async (pdf: Buffer): Promise<PlaceholderInfo[]> => {
|
|
||||||
return new Promise((resolve, reject) => {
|
|
||||||
const parser = new PDFParser(null, true);
|
|
||||||
|
|
||||||
parser.on('pdfParser_dataError', (errData) => {
|
|
||||||
reject(errData);
|
|
||||||
});
|
|
||||||
|
|
||||||
parser.on('pdfParser_dataReady', (pdfData) => {
|
|
||||||
const placeholders: PlaceholderInfo[] = [];
|
|
||||||
|
|
||||||
pdfData.Pages.forEach((page, pageIndex) => {
|
|
||||||
/*
|
|
||||||
pdf2json returns the PDF page content as an array of characters.
|
|
||||||
We need to concatenate the characters to get the full text.
|
|
||||||
We also need to get the position of the text so we can place the placeholders in the correct position.
|
|
||||||
|
|
||||||
Page dimensions from PDF2JSON are in "page units" (relative coordinates)
|
|
||||||
*/
|
|
||||||
let pageText = '';
|
|
||||||
const textPositions: TextPosition[] = [];
|
|
||||||
const charIndexMappings: CharIndexMapping[] = [];
|
|
||||||
|
|
||||||
page.Texts.forEach((text) => {
|
|
||||||
/*
|
|
||||||
R is an array of objects containing each character, its position and styling information.
|
|
||||||
The decodedText stores the characters, without any other information.
|
|
||||||
|
|
||||||
textPositions stores each character and its position on the page.
|
|
||||||
*/
|
|
||||||
const decodedText = text.R.map((run) => decodeURIComponent(run.T)).join('');
|
|
||||||
|
|
||||||
/*
|
|
||||||
For each character in the decodedText, we store its position in the textPositions array.
|
|
||||||
This allows us to quickly find the position of a character in the textPositions array by its index.
|
|
||||||
*/
|
|
||||||
for (let i = 0; i < decodedText.length; i++) {
|
|
||||||
charIndexMappings.push({
|
|
||||||
textPositionIndex: textPositions.length,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
pageText += decodedText;
|
|
||||||
|
|
||||||
textPositions.push({
|
|
||||||
text: decodedText,
|
|
||||||
x: text.x,
|
|
||||||
y: text.y,
|
|
||||||
w: text.w || 0,
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
const placeholderMatches = pageText.matchAll(/{{([^}]+)}}/g);
|
|
||||||
|
|
||||||
/*
|
|
||||||
A placeholder match has the following format:
|
|
||||||
|
|
||||||
[
|
|
||||||
'{{fieldType,recipient,fieldMeta}}',
|
|
||||||
'fieldType,recipient,fieldMeta',
|
|
||||||
'index: <number>',
|
|
||||||
'input: <pdf-text>'
|
|
||||||
]
|
|
||||||
*/
|
|
||||||
for (const placeholderMatch of placeholderMatches) {
|
|
||||||
const placeholder = placeholderMatch[0];
|
|
||||||
const placeholderData = placeholderMatch[1].split(',').map((property) => property.trim());
|
|
||||||
|
|
||||||
const [fieldTypeString, recipient, ...fieldMetaData] = placeholderData;
|
|
||||||
|
|
||||||
const rawFieldMeta = Object.fromEntries(
|
|
||||||
fieldMetaData.map((property) => property.split('=')),
|
|
||||||
);
|
|
||||||
|
|
||||||
const fieldType = parseFieldType(fieldTypeString);
|
|
||||||
const parsedFieldMeta = parseFieldMeta(rawFieldMeta, fieldType);
|
|
||||||
|
|
||||||
const fieldAndMeta: TFieldAndMeta = ZFieldAndMetaSchema.parse({
|
|
||||||
type: fieldType,
|
|
||||||
fieldMeta: parsedFieldMeta,
|
|
||||||
});
|
|
||||||
|
|
||||||
/*
|
|
||||||
Find the position of where the placeholder starts and ends in the text.
|
|
||||||
|
|
||||||
Then find the position of the characters in the textPositions array.
|
|
||||||
This allows us to quickly find the position of a character in the textPositions array by its index.
|
|
||||||
*/
|
|
||||||
if (placeholderMatch.index === undefined) {
|
|
||||||
console.error('Placeholder match index is undefined for placeholder', placeholder);
|
|
||||||
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
const placeholderEndCharIndex = placeholderMatch.index + placeholder.length;
|
|
||||||
|
|
||||||
/*
|
|
||||||
Get the index of the placeholder's first and last character in the textPositions array.
|
|
||||||
Used to retrieve the character information from the textPositions array.
|
|
||||||
|
|
||||||
Example:
|
|
||||||
startTextPosIndex - 1
|
|
||||||
endTextPosIndex - 40
|
|
||||||
*/
|
|
||||||
const startTextPosIndex = charIndexMappings[placeholderMatch.index].textPositionIndex;
|
|
||||||
const endTextPosIndex = charIndexMappings[placeholderEndCharIndex - 1].textPositionIndex;
|
|
||||||
|
|
||||||
/*
|
|
||||||
Get the placeholder's first and last character information from the textPositions array.
|
|
||||||
|
|
||||||
Example:
|
|
||||||
placeholderStart = { text: '{', x: 100, y: 100, w: 100 }
|
|
||||||
placeholderEnd = { text: '}', x: 200, y: 100, w: 100 }
|
|
||||||
*/
|
|
||||||
const placeholderStart = textPositions[startTextPosIndex];
|
|
||||||
const placeholderEnd = textPositions[endTextPosIndex];
|
|
||||||
|
|
||||||
const width = placeholderEnd.x + placeholderEnd.w * 0.1 - placeholderStart.x;
|
|
||||||
|
|
||||||
placeholders.push({
|
|
||||||
placeholder,
|
|
||||||
recipient,
|
|
||||||
fieldAndMeta,
|
|
||||||
page: pageIndex + 1,
|
|
||||||
x: placeholderStart.x,
|
|
||||||
y: placeholderStart.y,
|
|
||||||
width,
|
|
||||||
height: 1,
|
|
||||||
pageWidth: page.Width,
|
|
||||||
pageHeight: page.Height,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
resolve(placeholders);
|
|
||||||
});
|
|
||||||
|
|
||||||
parser.parseBuffer(pdf);
|
|
||||||
});
|
|
||||||
};
|
|
||||||
|
|
||||||
export const replacePlaceholdersInPDF = async (pdf: Buffer): Promise<Buffer> => {
|
|
||||||
const placeholders = await extractPlaceholdersFromPDF(pdf);
|
|
||||||
|
|
||||||
const pdfDoc = await PDFDocument.load(new Uint8Array(pdf));
|
|
||||||
const pages = pdfDoc.getPages();
|
|
||||||
|
|
||||||
for (const placeholder of placeholders) {
|
|
||||||
const pageIndex = placeholder.page - 1;
|
|
||||||
const page = pages[pageIndex];
|
|
||||||
|
|
||||||
const { width: pdfLibPageWidth, height: pdfLibPageHeight } = getPageSize(page);
|
|
||||||
|
|
||||||
/*
|
|
||||||
Convert PDF2JSON coordinates to pdf-lib coordinates:
|
|
||||||
|
|
||||||
PDF2JSON uses relative "page units":
|
|
||||||
- x, y, width, height are in page units
|
|
||||||
- Page dimensions (Width, Height) are also in page units
|
|
||||||
|
|
||||||
pdf-lib uses absolute points (1 point = 1/72 inch):
|
|
||||||
- Need to convert from page units to points
|
|
||||||
- Y-axis in pdf-lib is bottom-up (origin at bottom-left)
|
|
||||||
- Y-axis in PDF2JSON is top-down (origin at top-left)
|
|
||||||
*/
|
|
||||||
|
|
||||||
const xPoints = (placeholder.x / placeholder.pageWidth) * pdfLibPageWidth;
|
|
||||||
const yPoints = pdfLibPageHeight - (placeholder.y / placeholder.pageHeight) * pdfLibPageHeight;
|
|
||||||
const widthPoints = (placeholder.width / placeholder.pageWidth) * pdfLibPageWidth;
|
|
||||||
const heightPoints = (placeholder.height / placeholder.pageHeight) * pdfLibPageHeight;
|
|
||||||
|
|
||||||
page.drawRectangle({
|
|
||||||
x: xPoints,
|
|
||||||
y: yPoints - heightPoints, // Adjust for height since y is at baseline
|
|
||||||
width: widthPoints,
|
|
||||||
height: heightPoints,
|
|
||||||
color: rgb(1, 1, 1),
|
|
||||||
borderColor: rgb(1, 1, 1),
|
|
||||||
borderWidth: 2,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const modifiedPdfBytes = await pdfDoc.save();
|
|
||||||
|
|
||||||
return Buffer.from(modifiedPdfBytes);
|
|
||||||
};
|
|
||||||
|
|
||||||
const extractRecipientPlaceholder = (placeholder: string): RecipientPlaceholderInfo => {
|
|
||||||
const indexMatch = placeholder.match(/^r(\d+)$/i);
|
|
||||||
|
|
||||||
if (!indexMatch) {
|
|
||||||
throw new AppError(AppErrorCode.INVALID_BODY, {
|
|
||||||
message: `Invalid recipient placeholder format: ${placeholder}. Expected format: r1, r2, r3, etc.`,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const recipientIndex = Number(indexMatch[1]);
|
|
||||||
|
|
||||||
return {
|
|
||||||
email: `recipient.${recipientIndex}@documenso.com`,
|
|
||||||
name: `Recipient ${recipientIndex}`,
|
|
||||||
recipientIndex,
|
|
||||||
};
|
|
||||||
};
|
|
||||||
|
|
||||||
export const insertFieldsFromPlaceholdersInPDF = async (
|
|
||||||
pdf: Buffer,
|
|
||||||
userId: number,
|
|
||||||
teamId: number,
|
|
||||||
envelopeId: EnvelopeIdOptions,
|
|
||||||
requestMetadata: ApiRequestMetadata,
|
|
||||||
envelopeItemId?: string,
|
|
||||||
): Promise<Buffer> => {
|
|
||||||
const placeholders = await extractPlaceholdersFromPDF(pdf);
|
|
||||||
|
|
||||||
if (placeholders.length === 0) {
|
|
||||||
return pdf;
|
|
||||||
}
|
|
||||||
|
|
||||||
/*
|
|
||||||
A structure that maps the recipient index to the recipient name.
|
|
||||||
Example: 1 => 'Recipient 1'
|
|
||||||
*/
|
|
||||||
const recipientPlaceholders = new Map<number, string>();
|
|
||||||
|
|
||||||
for (const placeholder of placeholders) {
|
|
||||||
const { name, recipientIndex } = extractRecipientPlaceholder(placeholder.recipient);
|
|
||||||
|
|
||||||
recipientPlaceholders.set(recipientIndex, name);
|
|
||||||
}
|
|
||||||
|
|
||||||
/*
|
|
||||||
Create a list of recipients to create.
|
|
||||||
Example: [{ email: 'recipient.1@documenso.com', name: 'Recipient 1', role: 'SIGNER', signingOrder: 1 }]
|
|
||||||
*/
|
|
||||||
const recipientsToCreate = Array.from(
|
|
||||||
recipientPlaceholders.entries(),
|
|
||||||
([recipientIndex, name]) => {
|
|
||||||
return {
|
|
||||||
email: `recipient.${recipientIndex}@documenso.com`,
|
|
||||||
name,
|
|
||||||
role: RecipientRole.SIGNER,
|
|
||||||
signingOrder: recipientIndex,
|
|
||||||
};
|
|
||||||
},
|
|
||||||
);
|
|
||||||
|
|
||||||
const { envelopeWhereInput } = await getEnvelopeWhereInput({
|
|
||||||
id: envelopeId,
|
|
||||||
userId,
|
|
||||||
teamId,
|
|
||||||
type: null,
|
|
||||||
});
|
|
||||||
|
|
||||||
const envelope = await prisma.envelope.findFirst({
|
|
||||||
where: envelopeWhereInput,
|
|
||||||
select: {
|
|
||||||
id: true,
|
|
||||||
type: true,
|
|
||||||
secondaryId: true,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
if (!envelope) {
|
|
||||||
throw new AppError(AppErrorCode.NOT_FOUND, {
|
|
||||||
message: 'Envelope not found',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const existingRecipients = await prisma.recipient.findMany({
|
|
||||||
where: {
|
|
||||||
envelopeId: envelope.id,
|
|
||||||
},
|
|
||||||
select: {
|
|
||||||
id: true,
|
|
||||||
email: true,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
const existingEmails = new Set(existingRecipients.map((r) => r.email));
|
|
||||||
const recipientsToCreateFiltered = recipientsToCreate.filter(
|
|
||||||
(recipient) => !existingEmails.has(recipient.email),
|
|
||||||
);
|
|
||||||
|
|
||||||
let createdRecipients: Pick<Recipient, 'id' | 'email'>[] = existingRecipients;
|
|
||||||
|
|
||||||
if (recipientsToCreateFiltered.length > 0) {
|
|
||||||
if (envelope.type === EnvelopeType.DOCUMENT) {
|
|
||||||
const { recipients } = await createDocumentRecipients({
|
|
||||||
userId,
|
|
||||||
teamId,
|
|
||||||
id: envelopeId,
|
|
||||||
recipients: recipientsToCreateFiltered,
|
|
||||||
requestMetadata,
|
|
||||||
});
|
|
||||||
|
|
||||||
createdRecipients = [...existingRecipients, ...recipients];
|
|
||||||
} else if (envelope.type === EnvelopeType.TEMPLATE) {
|
|
||||||
const templateId =
|
|
||||||
envelopeId.type === 'templateId'
|
|
||||||
? envelopeId.id
|
|
||||||
: mapSecondaryIdToTemplateId(envelope.secondaryId);
|
|
||||||
|
|
||||||
const { recipients } = await createTemplateRecipients({
|
|
||||||
userId,
|
|
||||||
teamId,
|
|
||||||
templateId,
|
|
||||||
recipients: recipientsToCreateFiltered,
|
|
||||||
});
|
|
||||||
|
|
||||||
createdRecipients = [...existingRecipients, ...recipients];
|
|
||||||
} else {
|
|
||||||
throw new AppError(AppErrorCode.INVALID_BODY, {
|
|
||||||
message: `Invalid envelope type: ${envelope.type}`,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
const fieldsToCreate: FieldToCreate[] = [];
|
|
||||||
|
|
||||||
for (const placeholder of placeholders) {
|
|
||||||
/*
|
|
||||||
Convert PDF2JSON coordinates to percentage-based coordinates (0-100)
|
|
||||||
The UI expects positionX and positionY as percentages, not absolute points
|
|
||||||
PDF2JSON uses relative coordinates: x/pageWidth and y/pageHeight give us the percentage
|
|
||||||
*/
|
|
||||||
const xPercent = (placeholder.x / placeholder.pageWidth) * 100;
|
|
||||||
const yPercent = (placeholder.y / placeholder.pageHeight) * 100;
|
|
||||||
|
|
||||||
const widthPercent = (placeholder.width / placeholder.pageWidth) * 100;
|
|
||||||
const heightPercent = (placeholder.height / placeholder.pageHeight) * 100;
|
|
||||||
|
|
||||||
const { email } = extractRecipientPlaceholder(placeholder.recipient);
|
|
||||||
const recipient = createdRecipients.find((r) => r.email === email);
|
|
||||||
|
|
||||||
if (!recipient) {
|
|
||||||
throw new AppError(AppErrorCode.INVALID_BODY, {
|
|
||||||
message: `Could not find recipient ID for placeholder: ${placeholder.placeholder}`,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const recipientId = recipient.id;
|
|
||||||
|
|
||||||
// Default height percentage if too small (use 2% as a reasonable default)
|
|
||||||
const finalHeightPercent = heightPercent > 0.01 ? heightPercent : 2;
|
|
||||||
|
|
||||||
fieldsToCreate.push({
|
|
||||||
...placeholder.fieldAndMeta,
|
|
||||||
envelopeItemId,
|
|
||||||
recipientId,
|
|
||||||
pageNumber: placeholder.page,
|
|
||||||
pageX: xPercent,
|
|
||||||
pageY: yPercent,
|
|
||||||
width: widthPercent,
|
|
||||||
height: finalHeightPercent,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
await createEnvelopeFields({
|
|
||||||
userId,
|
|
||||||
teamId,
|
|
||||||
id: envelopeId,
|
|
||||||
fields: fieldsToCreate,
|
|
||||||
requestMetadata,
|
|
||||||
});
|
|
||||||
|
|
||||||
return pdf;
|
|
||||||
};
|
|
||||||
@ -1,6 +1,5 @@
|
|||||||
import { PDFDocument } from '@cantoo/pdf-lib';
|
import { PDFDocument } from '@cantoo/pdf-lib';
|
||||||
|
|
||||||
import { replacePlaceholdersInPDF } from './auto-place-fields';
|
|
||||||
import { flattenAnnotations } from './flatten-annotations';
|
import { flattenAnnotations } from './flatten-annotations';
|
||||||
import { flattenForm, removeOptionalContentGroups } from './flatten-form';
|
import { flattenForm, removeOptionalContentGroups } from './flatten-form';
|
||||||
|
|
||||||
@ -14,7 +13,6 @@ export const normalizePdf = async (pdf: Buffer) => {
|
|||||||
removeOptionalContentGroups(pdfDoc);
|
removeOptionalContentGroups(pdfDoc);
|
||||||
await flattenForm(pdfDoc);
|
await flattenForm(pdfDoc);
|
||||||
flattenAnnotations(pdfDoc);
|
flattenAnnotations(pdfDoc);
|
||||||
const pdfWithoutPlaceholders = await replacePlaceholdersInPDF(pdf);
|
|
||||||
|
|
||||||
return pdfWithoutPlaceholders;
|
return Buffer.from(await pdfDoc.save());
|
||||||
};
|
};
|
||||||
|
|||||||
@ -3,7 +3,6 @@ import { createElement } from 'react';
|
|||||||
import { msg } from '@lingui/core/macro';
|
import { msg } from '@lingui/core/macro';
|
||||||
import type { Field, Signature } from '@prisma/client';
|
import type { Field, Signature } from '@prisma/client';
|
||||||
import {
|
import {
|
||||||
DocumentSigningOrder,
|
|
||||||
DocumentSource,
|
DocumentSource,
|
||||||
DocumentStatus,
|
DocumentStatus,
|
||||||
EnvelopeType,
|
EnvelopeType,
|
||||||
@ -27,7 +26,7 @@ import type { TSignFieldWithTokenMutationSchema } from '@documenso/trpc/server/f
|
|||||||
import { getI18nInstance } from '../../client-only/providers/i18n-server';
|
import { getI18nInstance } from '../../client-only/providers/i18n-server';
|
||||||
import { NEXT_PUBLIC_WEBAPP_URL } from '../../constants/app';
|
import { NEXT_PUBLIC_WEBAPP_URL } from '../../constants/app';
|
||||||
import { AppError, AppErrorCode } from '../../errors/app-error';
|
import { AppError, AppErrorCode } from '../../errors/app-error';
|
||||||
import { DOCUMENT_AUDIT_LOG_TYPE, RECIPIENT_DIFF_TYPE } from '../../types/document-audit-logs';
|
import { DOCUMENT_AUDIT_LOG_TYPE } from '../../types/document-audit-logs';
|
||||||
import type { TRecipientActionAuthTypes } from '../../types/document-auth';
|
import type { TRecipientActionAuthTypes } from '../../types/document-auth';
|
||||||
import { DocumentAccessAuth, ZRecipientAuthOptionsSchema } from '../../types/document-auth';
|
import { DocumentAccessAuth, ZRecipientAuthOptionsSchema } from '../../types/document-auth';
|
||||||
import { ZFieldMetaSchema } from '../../types/field-meta';
|
import { ZFieldMetaSchema } from '../../types/field-meta';
|
||||||
@ -69,10 +68,6 @@ export type CreateDocumentFromDirectTemplateOptions = {
|
|||||||
name?: string;
|
name?: string;
|
||||||
email: string;
|
email: string;
|
||||||
};
|
};
|
||||||
nextSigner?: {
|
|
||||||
email: string;
|
|
||||||
name: string;
|
|
||||||
};
|
|
||||||
};
|
};
|
||||||
|
|
||||||
type CreatedDirectRecipientField = {
|
type CreatedDirectRecipientField = {
|
||||||
@ -97,7 +92,6 @@ export const createDocumentFromDirectTemplate = async ({
|
|||||||
directTemplateExternalId,
|
directTemplateExternalId,
|
||||||
signedFieldValues,
|
signedFieldValues,
|
||||||
templateUpdatedAt,
|
templateUpdatedAt,
|
||||||
nextSigner,
|
|
||||||
requestMetadata,
|
requestMetadata,
|
||||||
user,
|
user,
|
||||||
}: CreateDocumentFromDirectTemplateOptions): Promise<TCreateDocumentFromDirectTemplateResponse> => {
|
}: CreateDocumentFromDirectTemplateOptions): Promise<TCreateDocumentFromDirectTemplateResponse> => {
|
||||||
@ -134,17 +128,6 @@ export const createDocumentFromDirectTemplate = async ({
|
|||||||
throw new AppError(AppErrorCode.INVALID_REQUEST, { message: 'Invalid or missing template' });
|
throw new AppError(AppErrorCode.INVALID_REQUEST, { message: 'Invalid or missing template' });
|
||||||
}
|
}
|
||||||
|
|
||||||
if (
|
|
||||||
nextSigner &&
|
|
||||||
(!directTemplateEnvelope.documentMeta?.allowDictateNextSigner ||
|
|
||||||
directTemplateEnvelope.documentMeta?.signingOrder !== DocumentSigningOrder.SEQUENTIAL)
|
|
||||||
) {
|
|
||||||
throw new AppError(AppErrorCode.INVALID_REQUEST, {
|
|
||||||
message:
|
|
||||||
'You need to enable allowDictateNextSigner and sequential signing to dictate the next signer',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const directTemplateEnvelopeLegacyId = mapSecondaryIdToTemplateId(
|
const directTemplateEnvelopeLegacyId = mapSecondaryIdToTemplateId(
|
||||||
directTemplateEnvelope.secondaryId,
|
directTemplateEnvelope.secondaryId,
|
||||||
);
|
);
|
||||||
@ -647,77 +630,6 @@ export const createDocumentFromDirectTemplate = async ({
|
|||||||
}),
|
}),
|
||||||
];
|
];
|
||||||
|
|
||||||
if (nextSigner) {
|
|
||||||
const pendingRecipients = await tx.recipient.findMany({
|
|
||||||
select: {
|
|
||||||
id: true,
|
|
||||||
signingOrder: true,
|
|
||||||
name: true,
|
|
||||||
email: true,
|
|
||||||
role: true,
|
|
||||||
},
|
|
||||||
where: {
|
|
||||||
envelopeId: createdEnvelope.id,
|
|
||||||
signingStatus: {
|
|
||||||
not: SigningStatus.SIGNED,
|
|
||||||
},
|
|
||||||
role: {
|
|
||||||
not: RecipientRole.CC,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
// Composite sort so our next recipient is always the one with the lowest signing order or id
|
|
||||||
// if there is a tie.
|
|
||||||
orderBy: [{ signingOrder: { sort: 'asc', nulls: 'last' } }, { id: 'asc' }],
|
|
||||||
});
|
|
||||||
|
|
||||||
const nextRecipient = pendingRecipients[0];
|
|
||||||
|
|
||||||
if (nextRecipient) {
|
|
||||||
auditLogsToCreate.push(
|
|
||||||
createDocumentAuditLogData({
|
|
||||||
type: DOCUMENT_AUDIT_LOG_TYPE.RECIPIENT_UPDATED,
|
|
||||||
envelopeId: createdEnvelope.id,
|
|
||||||
user: {
|
|
||||||
name: user?.name || directRecipientName || '',
|
|
||||||
email: user?.email || directRecipientEmail,
|
|
||||||
},
|
|
||||||
metadata: requestMetadata,
|
|
||||||
data: {
|
|
||||||
recipientEmail: nextRecipient.email,
|
|
||||||
recipientName: nextRecipient.name,
|
|
||||||
recipientId: nextRecipient.id,
|
|
||||||
recipientRole: nextRecipient.role,
|
|
||||||
changes: [
|
|
||||||
{
|
|
||||||
type: RECIPIENT_DIFF_TYPE.NAME,
|
|
||||||
from: nextRecipient.name,
|
|
||||||
to: nextSigner.name,
|
|
||||||
},
|
|
||||||
{
|
|
||||||
type: RECIPIENT_DIFF_TYPE.EMAIL,
|
|
||||||
from: nextRecipient.email,
|
|
||||||
to: nextSigner.email,
|
|
||||||
},
|
|
||||||
],
|
|
||||||
},
|
|
||||||
}),
|
|
||||||
);
|
|
||||||
|
|
||||||
await tx.recipient.update({
|
|
||||||
where: { id: nextRecipient.id },
|
|
||||||
data: {
|
|
||||||
sendStatus: SendStatus.SENT,
|
|
||||||
...(nextSigner && documentMeta?.allowDictateNextSigner
|
|
||||||
? {
|
|
||||||
name: nextSigner.name,
|
|
||||||
email: nextSigner.email,
|
|
||||||
}
|
|
||||||
: {}),
|
|
||||||
},
|
|
||||||
});
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
await tx.documentAuditLog.createMany({
|
await tx.documentAuditLog.createMany({
|
||||||
data: auditLogsToCreate,
|
data: auditLogsToCreate,
|
||||||
});
|
});
|
||||||
|
|||||||
@ -5,6 +5,20 @@ export const deletedAccountServiceAccount = async () => {
|
|||||||
where: {
|
where: {
|
||||||
email: 'deleted-account@documenso.com',
|
email: 'deleted-account@documenso.com',
|
||||||
},
|
},
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
email: true,
|
||||||
|
ownedOrganisations: {
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
teams: {
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
if (!serviceAccount) {
|
if (!serviceAccount) {
|
||||||
|
|||||||
@ -28,7 +28,6 @@ type SeedTemplateOptions = {
|
|||||||
title?: string;
|
title?: string;
|
||||||
userId: number;
|
userId: number;
|
||||||
teamId: number;
|
teamId: number;
|
||||||
internalVersion?: 1 | 2;
|
|
||||||
createTemplateOptions?: Partial<Prisma.EnvelopeUncheckedCreateInput>;
|
createTemplateOptions?: Partial<Prisma.EnvelopeUncheckedCreateInput>;
|
||||||
};
|
};
|
||||||
|
|
||||||
@ -168,7 +167,7 @@ export const seedDirectTemplate = async (options: SeedTemplateOptions) => {
|
|||||||
data: {
|
data: {
|
||||||
id: prefixedId('envelope'),
|
id: prefixedId('envelope'),
|
||||||
secondaryId: templateId.formattedTemplateId,
|
secondaryId: templateId.formattedTemplateId,
|
||||||
internalVersion: options.internalVersion ?? 1,
|
internalVersion: 1,
|
||||||
type: EnvelopeType.TEMPLATE,
|
type: EnvelopeType.TEMPLATE,
|
||||||
title,
|
title,
|
||||||
envelopeItems: {
|
envelopeItems: {
|
||||||
@ -185,7 +184,6 @@ export const seedDirectTemplate = async (options: SeedTemplateOptions) => {
|
|||||||
teamId,
|
teamId,
|
||||||
recipients: {
|
recipients: {
|
||||||
create: {
|
create: {
|
||||||
signingOrder: 1,
|
|
||||||
email: DIRECT_TEMPLATE_RECIPIENT_EMAIL,
|
email: DIRECT_TEMPLATE_RECIPIENT_EMAIL,
|
||||||
name: DIRECT_TEMPLATE_RECIPIENT_NAME,
|
name: DIRECT_TEMPLATE_RECIPIENT_NAME,
|
||||||
token: Math.random().toString().slice(2, 7),
|
token: Math.random().toString().slice(2, 7),
|
||||||
|
|||||||
@ -39,11 +39,6 @@ export const getAdminOrganisation = async ({ organisationId }: GetOrganisationOp
|
|||||||
teams: true,
|
teams: true,
|
||||||
members: {
|
members: {
|
||||||
include: {
|
include: {
|
||||||
organisationGroupMembers: {
|
|
||||||
include: {
|
|
||||||
group: true,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
user: {
|
user: {
|
||||||
select: {
|
select: {
|
||||||
id: true,
|
id: true,
|
||||||
|
|||||||
@ -3,8 +3,6 @@ import { z } from 'zod';
|
|||||||
import { ZOrganisationSchema } from '@documenso/lib/types/organisation';
|
import { ZOrganisationSchema } from '@documenso/lib/types/organisation';
|
||||||
import OrganisationClaimSchema from '@documenso/prisma/generated/zod/modelSchema/OrganisationClaimSchema';
|
import OrganisationClaimSchema from '@documenso/prisma/generated/zod/modelSchema/OrganisationClaimSchema';
|
||||||
import OrganisationGlobalSettingsSchema from '@documenso/prisma/generated/zod/modelSchema/OrganisationGlobalSettingsSchema';
|
import OrganisationGlobalSettingsSchema from '@documenso/prisma/generated/zod/modelSchema/OrganisationGlobalSettingsSchema';
|
||||||
import OrganisationGroupMemberSchema from '@documenso/prisma/generated/zod/modelSchema/OrganisationGroupMemberSchema';
|
|
||||||
import OrganisationGroupSchema from '@documenso/prisma/generated/zod/modelSchema/OrganisationGroupSchema';
|
|
||||||
import OrganisationMemberSchema from '@documenso/prisma/generated/zod/modelSchema/OrganisationMemberSchema';
|
import OrganisationMemberSchema from '@documenso/prisma/generated/zod/modelSchema/OrganisationMemberSchema';
|
||||||
import SubscriptionSchema from '@documenso/prisma/generated/zod/modelSchema/SubscriptionSchema';
|
import SubscriptionSchema from '@documenso/prisma/generated/zod/modelSchema/SubscriptionSchema';
|
||||||
import TeamSchema from '@documenso/prisma/generated/zod/modelSchema/TeamSchema';
|
import TeamSchema from '@documenso/prisma/generated/zod/modelSchema/TeamSchema';
|
||||||
@ -32,18 +30,6 @@ export const ZGetAdminOrganisationResponseSchema = ZOrganisationSchema.extend({
|
|||||||
email: true,
|
email: true,
|
||||||
name: true,
|
name: true,
|
||||||
}),
|
}),
|
||||||
organisationGroupMembers: z.array(
|
|
||||||
OrganisationGroupMemberSchema.pick({
|
|
||||||
id: true,
|
|
||||||
groupId: true,
|
|
||||||
}).extend({
|
|
||||||
group: OrganisationGroupSchema.pick({
|
|
||||||
id: true,
|
|
||||||
type: true,
|
|
||||||
organisationRole: true,
|
|
||||||
}),
|
|
||||||
}),
|
|
||||||
),
|
|
||||||
}).array(),
|
}).array(),
|
||||||
subscription: SubscriptionSchema.nullable(),
|
subscription: SubscriptionSchema.nullable(),
|
||||||
organisationClaim: OrganisationClaimSchema,
|
organisationClaim: OrganisationClaimSchema,
|
||||||
|
|||||||
@ -17,7 +17,6 @@ import { promoteMemberToOwnerRoute } from './promote-member-to-owner';
|
|||||||
import { resealDocumentRoute } from './reseal-document';
|
import { resealDocumentRoute } from './reseal-document';
|
||||||
import { resetTwoFactorRoute } from './reset-two-factor-authentication';
|
import { resetTwoFactorRoute } from './reset-two-factor-authentication';
|
||||||
import { updateAdminOrganisationRoute } from './update-admin-organisation';
|
import { updateAdminOrganisationRoute } from './update-admin-organisation';
|
||||||
import { updateOrganisationMemberRoleRoute } from './update-organisation-member-role';
|
|
||||||
import { updateRecipientRoute } from './update-recipient';
|
import { updateRecipientRoute } from './update-recipient';
|
||||||
import { updateSiteSettingRoute } from './update-site-setting';
|
import { updateSiteSettingRoute } from './update-site-setting';
|
||||||
import { updateSubscriptionClaimRoute } from './update-subscription-claim';
|
import { updateSubscriptionClaimRoute } from './update-subscription-claim';
|
||||||
@ -32,7 +31,6 @@ export const adminRouter = router({
|
|||||||
},
|
},
|
||||||
organisationMember: {
|
organisationMember: {
|
||||||
promoteToOwner: promoteMemberToOwnerRoute,
|
promoteToOwner: promoteMemberToOwnerRoute,
|
||||||
updateRole: updateOrganisationMemberRoleRoute,
|
|
||||||
},
|
},
|
||||||
claims: {
|
claims: {
|
||||||
find: findSubscriptionClaimsRoute,
|
find: findSubscriptionClaimsRoute,
|
||||||
|
|||||||
@ -1,220 +0,0 @@
|
|||||||
import { OrganisationGroupType, OrganisationMemberRole } from '@prisma/client';
|
|
||||||
|
|
||||||
import { AppError, AppErrorCode } from '@documenso/lib/errors/app-error';
|
|
||||||
import { generateDatabaseId } from '@documenso/lib/universal/id';
|
|
||||||
import { getHighestOrganisationRoleInGroup } from '@documenso/lib/utils/organisations';
|
|
||||||
import { prisma } from '@documenso/prisma';
|
|
||||||
|
|
||||||
import { adminProcedure } from '../trpc';
|
|
||||||
import {
|
|
||||||
ZUpdateOrganisationMemberRoleRequestSchema,
|
|
||||||
ZUpdateOrganisationMemberRoleResponseSchema,
|
|
||||||
} from './update-organisation-member-role.types';
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Admin mutation to update organisation member role or transfer ownership.
|
|
||||||
*
|
|
||||||
* This mutation handles two scenarios:
|
|
||||||
* 1. When role='OWNER': Transfers organisation ownership and promotes to ADMIN
|
|
||||||
* 2. When role=ADMIN/MANAGER/MEMBER: Updates group membership
|
|
||||||
*
|
|
||||||
* Admin privileges bypass normal hierarchy restrictions.
|
|
||||||
*/
|
|
||||||
export const updateOrganisationMemberRoleRoute = adminProcedure
|
|
||||||
.input(ZUpdateOrganisationMemberRoleRequestSchema)
|
|
||||||
.output(ZUpdateOrganisationMemberRoleResponseSchema)
|
|
||||||
.mutation(async ({ input, ctx }) => {
|
|
||||||
const { organisationId, userId, role } = input;
|
|
||||||
|
|
||||||
ctx.logger.info({
|
|
||||||
input: {
|
|
||||||
organisationId,
|
|
||||||
userId,
|
|
||||||
role,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
const organisation = await prisma.organisation.findUnique({
|
|
||||||
where: {
|
|
||||||
id: organisationId,
|
|
||||||
},
|
|
||||||
include: {
|
|
||||||
groups: {
|
|
||||||
where: {
|
|
||||||
type: OrganisationGroupType.INTERNAL_ORGANISATION,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
members: {
|
|
||||||
where: {
|
|
||||||
userId,
|
|
||||||
},
|
|
||||||
include: {
|
|
||||||
organisationGroupMembers: {
|
|
||||||
include: {
|
|
||||||
group: true,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
if (!organisation) {
|
|
||||||
throw new AppError(AppErrorCode.NOT_FOUND, {
|
|
||||||
message: 'Organisation not found',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const [member] = organisation.members;
|
|
||||||
|
|
||||||
if (!member) {
|
|
||||||
throw new AppError(AppErrorCode.NOT_FOUND, {
|
|
||||||
message: 'User is not a member of this organisation',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const currentOrganisationRole = getHighestOrganisationRoleInGroup(
|
|
||||||
member.organisationGroupMembers.flatMap((member) => member.group),
|
|
||||||
);
|
|
||||||
|
|
||||||
if (role === 'OWNER') {
|
|
||||||
if (organisation.ownerUserId === userId) {
|
|
||||||
throw new AppError(AppErrorCode.INVALID_REQUEST, {
|
|
||||||
message: 'User is already the owner of this organisation',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const currentMemberGroup = organisation.groups.find(
|
|
||||||
(group) => group.organisationRole === currentOrganisationRole,
|
|
||||||
);
|
|
||||||
|
|
||||||
const adminGroup = organisation.groups.find(
|
|
||||||
(group) => group.organisationRole === OrganisationMemberRole.ADMIN,
|
|
||||||
);
|
|
||||||
|
|
||||||
if (!currentMemberGroup) {
|
|
||||||
ctx.logger.error({
|
|
||||||
message: '[CRITICAL]: Missing internal group',
|
|
||||||
organisationId,
|
|
||||||
userId,
|
|
||||||
role: currentOrganisationRole,
|
|
||||||
});
|
|
||||||
|
|
||||||
throw new AppError(AppErrorCode.UNKNOWN_ERROR, {
|
|
||||||
message: 'Current member group not found',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!adminGroup) {
|
|
||||||
ctx.logger.error({
|
|
||||||
message: '[CRITICAL]: Missing internal group',
|
|
||||||
organisationId,
|
|
||||||
userId,
|
|
||||||
targetRole: 'ADMIN',
|
|
||||||
});
|
|
||||||
|
|
||||||
throw new AppError(AppErrorCode.UNKNOWN_ERROR, {
|
|
||||||
message: 'Admin group not found',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
await prisma.$transaction(async (tx) => {
|
|
||||||
await tx.organisation.update({
|
|
||||||
where: {
|
|
||||||
id: organisationId,
|
|
||||||
},
|
|
||||||
data: {
|
|
||||||
ownerUserId: userId,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
if (currentOrganisationRole !== OrganisationMemberRole.ADMIN) {
|
|
||||||
await tx.organisationGroupMember.delete({
|
|
||||||
where: {
|
|
||||||
organisationMemberId_groupId: {
|
|
||||||
organisationMemberId: member.id,
|
|
||||||
groupId: currentMemberGroup.id,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
await tx.organisationGroupMember.create({
|
|
||||||
data: {
|
|
||||||
id: generateDatabaseId('group_member'),
|
|
||||||
organisationMemberId: member.id,
|
|
||||||
groupId: adminGroup.id,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const targetRole = role as OrganisationMemberRole;
|
|
||||||
|
|
||||||
if (currentOrganisationRole === targetRole) {
|
|
||||||
throw new AppError(AppErrorCode.INVALID_REQUEST, {
|
|
||||||
message: 'User already has this role',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
if (userId === organisation.ownerUserId && targetRole !== OrganisationMemberRole.ADMIN) {
|
|
||||||
throw new AppError(AppErrorCode.INVALID_REQUEST, {
|
|
||||||
message: 'Organisation owner must be an admin. Transfer ownership first.',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
const currentMemberGroup = organisation.groups.find(
|
|
||||||
(group) => group.organisationRole === currentOrganisationRole,
|
|
||||||
);
|
|
||||||
|
|
||||||
const newMemberGroup = organisation.groups.find(
|
|
||||||
(group) => group.organisationRole === targetRole,
|
|
||||||
);
|
|
||||||
|
|
||||||
if (!currentMemberGroup) {
|
|
||||||
ctx.logger.error({
|
|
||||||
message: '[CRITICAL]: Missing internal group',
|
|
||||||
organisationId,
|
|
||||||
userId,
|
|
||||||
role: currentOrganisationRole,
|
|
||||||
});
|
|
||||||
|
|
||||||
throw new AppError(AppErrorCode.UNKNOWN_ERROR, {
|
|
||||||
message: 'Current member group not found',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!newMemberGroup) {
|
|
||||||
ctx.logger.error({
|
|
||||||
message: '[CRITICAL]: Missing internal group',
|
|
||||||
organisationId,
|
|
||||||
userId,
|
|
||||||
targetRole,
|
|
||||||
});
|
|
||||||
|
|
||||||
throw new AppError(AppErrorCode.UNKNOWN_ERROR, {
|
|
||||||
message: 'New member group not found',
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
await prisma.$transaction(async (tx) => {
|
|
||||||
await tx.organisationGroupMember.delete({
|
|
||||||
where: {
|
|
||||||
organisationMemberId_groupId: {
|
|
||||||
organisationMemberId: member.id,
|
|
||||||
groupId: currentMemberGroup.id,
|
|
||||||
},
|
|
||||||
},
|
|
||||||
});
|
|
||||||
|
|
||||||
await tx.organisationGroupMember.create({
|
|
||||||
data: {
|
|
||||||
id: generateDatabaseId('group_member'),
|
|
||||||
organisationMemberId: member.id,
|
|
||||||
groupId: newMemberGroup.id,
|
|
||||||
},
|
|
||||||
});
|
|
||||||
});
|
|
||||||
});
|
|
||||||
@ -1,30 +0,0 @@
|
|||||||
import { OrganisationMemberRole } from '@prisma/client';
|
|
||||||
import { z } from 'zod';
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Admin-only role selection that includes OWNER as a special case.
|
|
||||||
* OWNER is not a database role but triggers ownership transfer.
|
|
||||||
*/
|
|
||||||
export const ZAdminRoleSelection = z.enum([
|
|
||||||
'OWNER',
|
|
||||||
OrganisationMemberRole.ADMIN,
|
|
||||||
OrganisationMemberRole.MANAGER,
|
|
||||||
OrganisationMemberRole.MEMBER,
|
|
||||||
]);
|
|
||||||
|
|
||||||
export type TAdminRoleSelection = z.infer<typeof ZAdminRoleSelection>;
|
|
||||||
|
|
||||||
export const ZUpdateOrganisationMemberRoleRequestSchema = z.object({
|
|
||||||
organisationId: z.string().min(1),
|
|
||||||
userId: z.number().min(1),
|
|
||||||
role: ZAdminRoleSelection,
|
|
||||||
});
|
|
||||||
|
|
||||||
export const ZUpdateOrganisationMemberRoleResponseSchema = z.void();
|
|
||||||
|
|
||||||
export type TUpdateOrganisationMemberRoleRequest = z.infer<
|
|
||||||
typeof ZUpdateOrganisationMemberRoleRequestSchema
|
|
||||||
>;
|
|
||||||
export type TUpdateOrganisationMemberRoleResponse = z.infer<
|
|
||||||
typeof ZUpdateOrganisationMemberRoleResponseSchema
|
|
||||||
>;
|
|
||||||
@ -3,6 +3,7 @@ import {
|
|||||||
ORGANISATION_USER_ACCOUNT_TYPE,
|
ORGANISATION_USER_ACCOUNT_TYPE,
|
||||||
} from '@documenso/lib/constants/organisations';
|
} from '@documenso/lib/constants/organisations';
|
||||||
import { AppError, AppErrorCode } from '@documenso/lib/errors/app-error';
|
import { AppError, AppErrorCode } from '@documenso/lib/errors/app-error';
|
||||||
|
import { handleDocumentOwnershipOnDeletion } from '@documenso/lib/server-only/document/handle-document-ownership-on-deletion';
|
||||||
import { buildOrganisationWhereQuery } from '@documenso/lib/utils/organisations';
|
import { buildOrganisationWhereQuery } from '@documenso/lib/utils/organisations';
|
||||||
import { prisma } from '@documenso/prisma';
|
import { prisma } from '@documenso/prisma';
|
||||||
|
|
||||||
@ -32,6 +33,24 @@ export const deleteOrganisationRoute = authenticatedProcedure
|
|||||||
userId: user.id,
|
userId: user.id,
|
||||||
roles: ORGANISATION_MEMBER_ROLE_PERMISSIONS_MAP['DELETE_ORGANISATION'],
|
roles: ORGANISATION_MEMBER_ROLE_PERMISSIONS_MAP['DELETE_ORGANISATION'],
|
||||||
}),
|
}),
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
owner: {
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
teams: {
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
documents: {
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
if (!organisation) {
|
if (!organisation) {
|
||||||
@ -40,6 +59,15 @@ export const deleteOrganisationRoute = authenticatedProcedure
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const documentIds = organisation.teams.flatMap((team) => team.documents.map((doc) => doc.id));
|
||||||
|
|
||||||
|
if (documentIds && documentIds.length > 0) {
|
||||||
|
await handleDocumentOwnershipOnDeletion({
|
||||||
|
documentIds,
|
||||||
|
organisationOwnerId: organisation.owner.id,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
await prisma.$transaction(async (tx) => {
|
await prisma.$transaction(async (tx) => {
|
||||||
await tx.account.deleteMany({
|
await tx.account.deleteMany({
|
||||||
where: {
|
where: {
|
||||||
|
|||||||
@ -1,4 +1,8 @@
|
|||||||
|
import { ORGANISATION_MEMBER_ROLE_PERMISSIONS_MAP } from '@documenso/lib/constants/organisations';
|
||||||
|
import { handleDocumentOwnershipOnDeletion } from '@documenso/lib/server-only/document/handle-document-ownership-on-deletion';
|
||||||
import { deleteTeam } from '@documenso/lib/server-only/team/delete-team';
|
import { deleteTeam } from '@documenso/lib/server-only/team/delete-team';
|
||||||
|
import { buildOrganisationWhereQuery } from '@documenso/lib/utils/organisations';
|
||||||
|
import { prisma } from '@documenso/prisma';
|
||||||
|
|
||||||
import { authenticatedProcedure } from '../trpc';
|
import { authenticatedProcedure } from '../trpc';
|
||||||
import { ZDeleteTeamRequestSchema, ZDeleteTeamResponseSchema } from './delete-team.types';
|
import { ZDeleteTeamRequestSchema, ZDeleteTeamResponseSchema } from './delete-team.types';
|
||||||
@ -11,12 +15,53 @@ export const deleteTeamRoute = authenticatedProcedure
|
|||||||
const { teamId } = input;
|
const { teamId } = input;
|
||||||
const { user } = ctx;
|
const { user } = ctx;
|
||||||
|
|
||||||
|
const team = await prisma.team.findUnique({
|
||||||
|
where: {
|
||||||
|
id: teamId,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
const organisation = await prisma.organisation.findFirst({
|
||||||
|
where: buildOrganisationWhereQuery({
|
||||||
|
organisationId: team?.organisationId,
|
||||||
|
userId: user.id,
|
||||||
|
roles: ORGANISATION_MEMBER_ROLE_PERMISSIONS_MAP['DELETE_ORGANISATION'],
|
||||||
|
}),
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
owner: {
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
teams: {
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
documents: {
|
||||||
|
select: {
|
||||||
|
id: true,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
ctx.logger.info({
|
ctx.logger.info({
|
||||||
input: {
|
input: {
|
||||||
teamId,
|
teamId,
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const documentIds = organisation?.teams.flatMap((team) => team.documents.map((doc) => doc.id));
|
||||||
|
|
||||||
|
if (documentIds && documentIds.length > 0 && organisation) {
|
||||||
|
await handleDocumentOwnershipOnDeletion({
|
||||||
|
documentIds,
|
||||||
|
organisationOwnerId: organisation.owner.id,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
await deleteTeam({
|
await deleteTeam({
|
||||||
userId: user.id,
|
userId: user.id,
|
||||||
teamId,
|
teamId,
|
||||||
|
|||||||
@ -519,7 +519,6 @@ export const templateRouter = router({
|
|||||||
directTemplateExternalId,
|
directTemplateExternalId,
|
||||||
signedFieldValues,
|
signedFieldValues,
|
||||||
templateUpdatedAt,
|
templateUpdatedAt,
|
||||||
nextSigner,
|
|
||||||
} = input;
|
} = input;
|
||||||
|
|
||||||
ctx.logger.info({
|
ctx.logger.info({
|
||||||
@ -542,7 +541,6 @@ export const templateRouter = router({
|
|||||||
email: ctx.user.email,
|
email: ctx.user.email,
|
||||||
}
|
}
|
||||||
: undefined,
|
: undefined,
|
||||||
nextSigner,
|
|
||||||
requestMetadata: ctx.metadata,
|
requestMetadata: ctx.metadata,
|
||||||
});
|
});
|
||||||
}),
|
}),
|
||||||
|
|||||||
@ -90,12 +90,6 @@ export const ZCreateDocumentFromDirectTemplateRequestSchema = z.object({
|
|||||||
directTemplateExternalId: z.string().optional(),
|
directTemplateExternalId: z.string().optional(),
|
||||||
signedFieldValues: z.array(ZSignFieldWithTokenMutationSchema),
|
signedFieldValues: z.array(ZSignFieldWithTokenMutationSchema),
|
||||||
templateUpdatedAt: z.date(),
|
templateUpdatedAt: z.date(),
|
||||||
nextSigner: z
|
|
||||||
.object({
|
|
||||||
email: z.string().email().max(254),
|
|
||||||
name: z.string().min(1).max(255),
|
|
||||||
})
|
|
||||||
.optional(),
|
|
||||||
});
|
});
|
||||||
|
|
||||||
export const ZCreateDocumentFromTemplateRequestSchema = z.object({
|
export const ZCreateDocumentFromTemplateRequestSchema = z.object({
|
||||||
|
|||||||
Reference in New Issue
Block a user