chore: More cleanup after cargo clippy

Also added some type efficiency improvements (using references where possible and added SliceDeque crate)

Signed-off-by: quexeky <git@quexeky.dev>

src-tauri/src/games/downloads/download_agent.rs

@@ -14,7 +14,7 @@ use crate::remote::RemoteAccessError;
 use crate::DB;
 use log::{debug, error, info};
 use rayon::ThreadPoolBuilder;
-use std::collections::VecDeque;
+use slice_deque::SliceDeque;
 use std::fs::{create_dir_all, File};
 use std::path::Path;
 use std::sync::mpsc::Sender;
@@ -34,7 +34,7 @@ pub struct GameDownloadAgent {
     pub version: String,
     pub control_flag: DownloadThreadControl,
     contexts: Mutex<Vec<DropDownloadContext>>,
-    completed_contexts: Mutex<VecDeque<usize>>,
+    completed_contexts: Mutex<SliceDeque<usize>>,
     pub manifest: Mutex<Option<DropManifest>>,
     pub progress: Arc<ProgressObject>,
     sender: Sender<DownloadManagerSignal>,
@@ -68,7 +68,7 @@ impl GameDownloadAgent {
             control_flag,
             manifest: Mutex::new(None),
             contexts: Mutex::new(Vec::new()),
-            completed_contexts: Mutex::new(VecDeque::new()),
+            completed_contexts: Mutex::new(SliceDeque::new()),
             progress: Arc::new(ProgressObject::new(0, 0, sender.clone())),
             sender,
             stored_manifest,
@@ -312,7 +312,7 @@ impl GameDownloadAgent {
         if completed_lock_len != contexts.len() {
             info!("da for {} exited without completing", self.id.clone());
             self.stored_manifest
-                .set_completed_contexts(&self.completed_contexts.lock().unwrap().clone().into());
+                .set_completed_contexts(self.completed_contexts.lock().unwrap().as_slice());
             info!("Setting completed contexts");
             self.stored_manifest.write();
             info!("Wrote completed contexts");

src-tauri/src/games/downloads/download_commands.rs

@@ -56,19 +56,3 @@ pub fn move_game_in_queue(
 pub fn cancel_game(state: tauri::State<'_, Mutex<AppState>>, meta: DownloadableMetadata) {
     state.lock().unwrap().download_manager.cancel(meta)
 }
-
-/*
-#[tauri::command]
-pub fn get_current_write_speed(state: tauri::State<'_, Mutex<AppState>>) {}
-*/
-
-/*
-fn use_download_agent(
-    state: tauri::State<'_, Mutex<AppState>>,
-    game_id: String,
-) -> Result<Arc<GameDownloadAgent>, String> {
-    let lock = state.lock().unwrap();
-    let download_agent = lock.download_manager.get(&game_id).ok_or("Invalid game ID")?;
-    Ok(download_agent.clone()) // Clones the Arc, not the underlying data structure
-}
-*/

src-tauri/src/games/downloads/stored_manifest.rs

@@ -70,8 +70,8 @@ impl StoredManifest {
             Err(e) => error!("{}", e),
         };
     }
-    pub fn set_completed_contexts(&self, completed_contexts: &Vec<usize>) {
-        *self.completed_contexts.lock().unwrap() = completed_contexts.clone();
+    pub fn set_completed_contexts(&self, completed_contexts: &[usize]) {
+        *self.completed_contexts.lock().unwrap() = completed_contexts.to_owned();
     }
     pub fn get_completed_contexts(&self) -> Vec<usize> {
         self.completed_contexts.lock().unwrap().clone()

src-tauri/src/games/library.rs

@@ -200,7 +200,7 @@ pub fn fetch_game_status(id: String) -> Result<GameStatusWithTransient, String>
     Ok(status)
 }
 
-fn fetch_game_verion_options_logic<'a>(
+fn fetch_game_verion_options_logic(
     game_id: String,
     state: tauri::State<'_, Mutex<AppState>>,
 ) -> Result<Vec<GameVersionOption>, RemoteAccessError> {
@@ -239,7 +239,6 @@ fn fetch_game_verion_options_logic<'a>(
 #[tauri::command]
 pub fn uninstall_game(
     game_id: String,
-    state: tauri::State<'_, Mutex<AppState>>,
     app_handle: AppHandle,
 ) -> Result<(), String> {
     let meta = get_current_meta(&game_id)?;
@@ -270,7 +269,7 @@ fn uninstall_game_logic(meta: DownloadableMetadata, app_handle: &AppHandle) {
         return;
     }
     let previous_state = previous_state.unwrap();
-    if let Some((version_name, install_dir)) = match previous_state {
+    if let Some((_, install_dir)) = match previous_state {
         GameDownloadStatus::Installed {
             version_name,
             install_dir,
@@ -330,7 +329,7 @@ pub fn get_current_meta(game_id: &String) -> Result<DownloadableMetadata, String
 }
 
 #[tauri::command]
-pub fn fetch_game_verion_options<'a>(
+pub fn fetch_game_verion_options(
     game_id: String,
     state: tauri::State<'_, Mutex<AppState>>,
 ) -> Result<Vec<GameVersionOption>, String> {