Rearchitecture for v0.4.0 (#197)

* feat: database redist support

* feat: rearchitecture of database schemas, migration reset, and #180

* feat: import redists

* fix: giantbomb logging bug

* feat: partial user platform support + statusMessage -> message

* feat: add user platform filters to store view

* fix: sanitize svg uploads

... copilot suggested this

I feel dirty.

* feat: beginnings of platform & redist management

* feat: add server side redist patching

* fix: update drop-base commit

* feat: import of custom platforms & file extensions

* fix: redelete platform

* fix: remove platform

* feat: uninstall commands, new R UI

* checkpoint: before migrating to nuxt v4

* update to nuxt 4

* fix: fixes for Nuxt v4 update

* fix: remaining type issues

* feat: initial feedback to import other kinds of versions

* working commit

* fix: lint

* feat: redist import

server/api/v1/admin/game/[id]/index.delete.ts

@@ -1,5 +1,5 @@
-import aclManager from "~/server/internal/acls";
-import libraryManager from "~/server/internal/library";
+import aclManager from "~~/server/internal/acls";
+import libraryManager from "~~/server/internal/library";
 
 export default defineEventHandler(async (h3) => {
   const allowed = await aclManager.allowSystemACL(h3, ["game:delete"]);
@@ -7,7 +7,7 @@ export default defineEventHandler(async (h3) => {
 
   const gameId = getRouterParam(h3, "id")!;
 
-  libraryManager.deleteGame(gameId);
+  await libraryManager.deleteGame(gameId);
 
   return {};
 });

server/api/v1/admin/game/[id]/index.get.ts

@@ -1,7 +1,6 @@
-import type { GameVersion } from "~/prisma/client/client";
-import aclManager from "~/server/internal/acls";
-import prisma from "~/server/internal/db/database";
-import libraryManager from "~/server/internal/library";
+import aclManager from "~~/server/internal/acls";
+import prisma from "~~/server/internal/db/database";
+import libraryManager from "~~/server/internal/library";
 
 export default defineEventHandler(async (h3) => {
   const allowed = await aclManager.allowSystemACL(h3, ["game:read"]);
@@ -15,24 +14,32 @@ export default defineEventHandler(async (h3) => {
     },
     include: {
       versions: {
-        orderBy: {
-          versionIndex: "asc",
-        },
         omit: {
           dropletManifest: true,
         },
+        include: {
+          gameVersions: {
+            include: {
+              install: true,
+              uninstall: true,
+              launches: true,
+            },
+          },
+        },
       },
       tags: true,
     },
   });
 
   if (!game || !game.libraryId)
-    throw createError({ statusCode: 404, statusMessage: "Game ID not found" });
+    throw createError({ statusCode: 404, message: "Game ID not found" });
 
-  const getGameVersionSize = async (version: GameVersion) => {
+  const getGameVersionSize = async (
+    version: Omit<(typeof game)["versions"][number], "dropletManifest">,
+  ) => {
     const size = await libraryManager.getGameVersionSize(
       gameId,
-      version.versionName,
+      version.versionId,
     );
     return { ...version, size };
   };

server/api/v1/admin/game/[id]/index.patch.ts

@@ -1,5 +1,5 @@
-import aclManager from "~/server/internal/acls";
-import prisma from "~/server/internal/db/database";
+import aclManager from "~~/server/internal/acls";
+import prisma from "~~/server/internal/db/database";
 
 export default defineEventHandler(async (h3) => {
   const allowed = await aclManager.allowSystemACL(h3, ["game:update"]);

server/api/v1/admin/game/[id]/metadata.post.ts

@@ -1,7 +1,13 @@
-import type { Prisma } from "~/prisma/client/client";
-import aclManager from "~/server/internal/acls";
-import prisma from "~/server/internal/db/database";
-import { handleFileUpload } from "~/server/internal/utils/handlefileupload";
+import { ArkErrors, type } from "arktype";
+import type { Prisma } from "~~/prisma/client/client";
+import aclManager from "~~/server/internal/acls";
+import prisma from "~~/server/internal/db/database";
+import { handleFileUpload } from "~~/server/internal/utils/handlefileupload";
+
+const UpdateMetadata = type({
+  name: "string?",
+  description: "string?",
+});
 
 export default defineEventHandler(async (h3) => {
   const allowed = await aclManager.allowSystemACL(h3, ["game:update"]);
@@ -11,7 +17,7 @@ export default defineEventHandler(async (h3) => {
   if (!form)
     throw createError({
       statusCode: 400,
-      statusMessage: "This endpoint requires multipart form data.",
+      message: "This endpoint requires multipart form data.",
     });
 
   const gameId = getRouterParam(h3, "id")!;
@@ -20,20 +26,20 @@ export default defineEventHandler(async (h3) => {
   if (!uploadResult)
     throw createError({
       statusCode: 400,
-      statusMessage: "Failed to upload file",
+      message: "Failed to upload file",
     });
 
   const [ids, options, pull, dump] = uploadResult;
 
   const id = ids.at(0);
 
-  // handleFileUpload reads the rest of the options for us.
-  const name = options.name;
-  const description = options.description;
+  const body = UpdateMetadata(options);
+  if (body instanceof ArkErrors)
+    throw createError({ statusCode: 400, message: body.summary });
 
   const updateModel: Prisma.GameUpdateInput = {
-    mName: name,
-    mShortDescription: description,
+    ...(body.name ? { mName: body.name } : undefined),
+    ...(body.description ? { mShortDescription: body.description } : undefined),
   };
 
   // handle if user uploaded new icon

server/api/v1/admin/game/[id]/tags.patch.ts

@@ -1,7 +1,7 @@
 import { type } from "arktype";
-import { readDropValidatedBody, throwingArktype } from "~/server/arktype";
-import aclManager from "~/server/internal/acls";
-import prisma from "~/server/internal/db/database";
+import { readDropValidatedBody, throwingArktype } from "~~/server/arktype";
+import aclManager from "~~/server/internal/acls";
+import prisma from "~~/server/internal/db/database";
 
 const PatchTags = type({
   tags: "string[]",

server/api/v1/admin/game/image/index.delete.ts

@@ -1,8 +1,8 @@
-import aclManager from "~/server/internal/acls";
-import prisma from "~/server/internal/db/database";
-import objectHandler from "~/server/internal/objects";
+import aclManager from "~~/server/internal/acls";
+import prisma from "~~/server/internal/db/database";
+import objectHandler from "~~/server/internal/objects";
 import { type } from "arktype";
-import { readDropValidatedBody, throwingArktype } from "~/server/arktype";
+import { readDropValidatedBody, throwingArktype } from "~~/server/arktype";
 
 const DeleteGameImage = type({
   gameId: "string",
@@ -32,20 +32,20 @@ export default defineEventHandler<{
   });
 
   if (!game)
-    throw createError({ statusCode: 400, statusMessage: "Invalid game ID" });
+    throw createError({ statusCode: 400, message: "Invalid game ID" });
 
   const imageIndex = game.mImageLibraryObjectIds.findIndex((e) => e == imageId);
   if (imageIndex == -1)
-    throw createError({ statusCode: 400, statusMessage: "Image not found" });
+    throw createError({ statusCode: 400, message: "Image not found" });
 
   game.mImageLibraryObjectIds.splice(imageIndex, 1);
   await objectHandler.deleteAsSystem(imageId);
 
   if (game.mBannerObjectId === imageId) {
-    game.mBannerObjectId = game.mImageLibraryObjectIds[0];
+    game.mBannerObjectId = game.mImageLibraryObjectIds[0] ?? "";
   }
   if (game.mCoverObjectId === imageId) {
-    game.mCoverObjectId = game.mImageLibraryObjectIds[0];
+    game.mCoverObjectId = game.mImageLibraryObjectIds[0] ?? "";
   }
 
   const result = await prisma.game.update({

server/api/v1/admin/game/image/index.post.ts

@@ -1,6 +1,6 @@
-import aclManager from "~/server/internal/acls";
-import prisma from "~/server/internal/db/database";
-import { handleFileUpload } from "~/server/internal/utils/handlefileupload";
+import aclManager from "~~/server/internal/acls";
+import prisma from "~~/server/internal/db/database";
+import { handleFileUpload } from "~~/server/internal/utils/handlefileupload";
 
 export default defineEventHandler(async (h3) => {
   const allowed = await aclManager.allowSystemACL(h3, ["game:image:new"]);
@@ -10,14 +10,14 @@ export default defineEventHandler(async (h3) => {
   if (!form)
     throw createError({
       statusCode: 400,
-      statusMessage: "This endpoint requires multipart form data.",
+      message: "This endpoint requires multipart form data.",
     });
 
   const uploadResult = await handleFileUpload(h3, {}, ["internal:read"]);
   if (!uploadResult)
     throw createError({
       statusCode: 400,
-      statusMessage: "Failed to upload file",
+      message: "Failed to upload file",
     });
 
   const [ids, options, pull, dump] = uploadResult;
@@ -25,21 +25,21 @@ export default defineEventHandler(async (h3) => {
     dump();
     throw createError({
       statusCode: 400,
-      statusMessage: "Did not upload a file",
+      message: "Did not upload a file",
     });
   }
 
-  const gameId = options.id;
+  const gameId = options.id as string;
   if (!gameId)
     throw createError({
       statusCode: 400,
-      statusMessage: "No game ID attached",
+      message: "No game ID attached",
     });
 
   const hasGame = (await prisma.game.count({ where: { id: gameId } })) != 0;
   if (!hasGame) {
     dump();
-    throw createError({ statusCode: 400, statusMessage: "Invalid game ID" });
+    throw createError({ statusCode: 400, message: "Invalid game ID" });
   }
 
   const result = await prisma.game.update({

server/api/v1/admin/game/index.get.ts

@@ -1,5 +1,5 @@
-import aclManager from "~/server/internal/acls";
-import prisma from "~/server/internal/db/database";
+import aclManager from "~~/server/internal/acls";
+import prisma from "~~/server/internal/db/database";
 
 export default defineEventHandler(async (h3) => {
   const allowed = await aclManager.allowSystemACL(h3, ["game:read"]);

server/api/v1/admin/game/version/index.delete.ts

@@ -1,11 +1,10 @@
 import { type } from "arktype";
-import { readDropValidatedBody, throwingArktype } from "~/server/arktype";
-import aclManager from "~/server/internal/acls";
-import libraryManager from "~/server/internal/library";
+import { readDropValidatedBody, throwingArktype } from "~~/server/arktype";
+import aclManager from "~~/server/internal/acls";
+import libraryManager from "~~/server/internal/library";
 
 const DeleteVersion = type({
   id: "string",
-  versionName: "string",
 }).configure(throwingArktype);
 
 export default defineEventHandler<{ body: typeof DeleteVersion }>(
@@ -17,10 +16,8 @@ export default defineEventHandler<{ body: typeof DeleteVersion }>(
 
     const body = await readDropValidatedBody(h3, DeleteVersion);
 
-    const gameId = body.id.toString();
-    const version = body.versionName.toString();
+    await libraryManager.deleteGameVersion(body.id);
 
-    await libraryManager.deleteGameVersion(gameId, version);
     return {};
   },
 );

server/api/v1/admin/game/version/index.patch.ts

@@ -1,7 +1,7 @@
 import { type } from "arktype";
-import { readDropValidatedBody, throwingArktype } from "~/server/arktype";
-import aclManager from "~/server/internal/acls";
-import prisma from "~/server/internal/db/database";
+import { readDropValidatedBody, throwingArktype } from "~~/server/arktype";
+import aclManager from "~~/server/internal/acls";
+import prisma from "~~/server/internal/db/database";
 
 const UpdateVersionOrder = type({
   id: "string",
@@ -16,57 +16,24 @@ export default defineEventHandler<{ body: typeof UpdateVersionOrder }>(
     if (!allowed) throw createError({ statusCode: 403 });
 
     const body = await readDropValidatedBody(h3, UpdateVersionOrder);
-    const gameId = body.id;
     // We expect an array of the version names for this game
-    const unsortedVersions = await prisma.gameVersion.findMany({
-      where: {
-        versionName: { in: body.versions },
-      },
-      select: {
-        versionName: true,
-        versionIndex: true,
-        delta: true,
-        platform: true,
-      },
-    });
-
-    const versions = body.versions
-      .map((e) => unsortedVersions.find((v) => v.versionName === e))
-      .filter((e) => e !== undefined);
-
-    if (versions.length !== unsortedVersions.length)
-      throw createError({
-        statusCode: 500,
-        statusMessage: "Sorting versions yielded less results, somehow.",
-      });
-
-    // Validate the new order
-    const has: { [key: string]: boolean } = {};
-    for (const version of versions) {
-      if (version.delta && !has[version.platform])
-        throw createError({
-          statusCode: 400,
-          statusMessage: `"${version.versionName}" requires a base version to apply the delta to.`,
-        });
-      has[version.platform] = true;
-    }
+    const versions = body.versions;
 
     await prisma.$transaction(
-      versions.map((version, versionIndex) =>
-        prisma.gameVersion.update({
+      versions.map((versionId, versionIndex) =>
+        prisma.version.update({
           where: {
-            gameId_versionName: {
-              gameId: gameId,
-              versionName: version.versionName,
-            },
+            versionId,
           },
           data: {
             versionIndex: versionIndex,
           },
+          select: {},
         }),
       ),
     );
 
-    return versions;
+    setResponseStatus(h3, 201);
+    return;
   },
 );