Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-10-03 02:04:31 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix(sharing): use neutral social preview image (#3410)

Browse Source 
* fix(sharing): use neutral social preview image

* fix(sharing): use neutral server social preview
This commit is contained in:
Amruth Pillai
2026-09-05 08:51:19 -07:00
committed by GitHub
parent bf27792ca0
commit 0878b256a9
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/server/src/static/web.test.ts
+2 -2
View File
@@ -151,9 +151,9 @@ describe("web app fallback classification", () => {
expect(html).toContain('<link rel="canonical" href="https://rxresu.me/jane/resume">');
expect(html).toContain('<meta property="og:type" content="profile">');
expect(html).toContain('<meta property="og:title" content="Jane Doe — Staff Engineer">');
expect(html).toContain('<meta property="og:image" content="https://rxresu.me/templates/jpg/azurill.jpg">');
expect(html).toContain('<meta property="og:image" content="https://rxresu.me/opengraph/banner.jpg">');
expect(html).toContain('<meta name="twitter:card" content="summary_large_image">');
expect(html).toContain('<meta name="twitter:image" content="https://rxresu.me/templates/jpg/azurill.jpg">');
expect(html).toContain('<meta name="twitter:image" content="https://rxresu.me/opengraph/banner.jpg">');
});
it("escapes user-authored values so resume content cannot break out of the attribute", async () => {
apps/server/src/static/web.ts
+1 -1
View File
@@ -224,7 +224,7 @@ async function createPublicResumeSeoMarkup(pathname: string, origin: string) {
if (!meta) return null;
const canonicalUrl = `${origin}/${username}/${slug}`;
const imageUrl = `${origin}/templates/jpg/${meta.template}.jpg`;
const imageUrl = `${origin}/opengraph/banner.jpg`;
const pageTitle = escapeAttribute(`${meta.name} - Reactive Resume`);
const title = escapeAttribute(meta.title);
const description = escapeAttribute(meta.description);
apps/web/src/routes/$username/$slug.tsx
+1 -1
View File
@@ -30,7 +30,7 @@ export const Route = createFileRoute("/$username/$slug")({
const base = getCanonicalRootUrl(typeof window === "undefined" ? undefined : window.location.origin);
const canonicalUrl = `${base}${params.username}/${params.slug}`;
const imageUrl = `${base}templates/jpg/${social.template}.jpg`;
const imageUrl = `${base}opengraph/banner.jpg`;
return {
meta: [