mirror of
https://github.com/AmruthPillai/Reactive-Resume.git
synced 2026-10-04 02:33:47 +10:00
docs: queue plan 20A independent review
This commit is contained in:
@@ -47,12 +47,12 @@ state changes are outside scope.
|
||||
| 12 preview/export failures | #3323, #3290, #3033, #3007, #2609 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer ownership; share observation harness with 18 | zero drift; staged-preview/error-boundary baselines remain; reports cross persistence/font/PDF/viewer/deployment boundaries | audit focused web/PDF suites, affected typechecks, boundaries, build passed | — | isolate PT Sans, browser/config, and template-selection boundaries; no shared fix | exact JSON/output/browser/config/current reproduction missing |
|
||||
| 13 font/glyph/spacing | #3249, #3159, #3147, #3093, #3089, #2988 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize font sources with 14/27 | merged metrics/cache/Unicode fixes present and passing; residuals require per-font/per-symptom fixtures | audit focused PDF/font suites, affected typechecks, boundaries, build passed | — | retain regressions; create residual unit only from exact failing font fixture | missing Ropa Sans/source strings/font hashes/before-after artifacts |
|
||||
| 14 RTL export layout | #3275 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize renderer/fonts with 13/27 | merged canvas-direction fix remains; broader shaping/bidi cause unproved | audit RTL/preview suites, affected typechecks, boundaries, build passed | — | run controlled same-bytes export matrix against approved shaping oracle | exact JSON/font/version and known-good reference absent |
|
||||
| 15 picture fitting/style | #3168, #3088, #2794, #2782 | 15A published; hosted changes requested; other causes blocked | queued `task_06bedd03c57a` | `codex/issue-2782-picture-fit` | `7a98f6662` → `6145d5a59` | coordinate 06/25; schema/PDF owner exclusion | clean local rereview; hosted feedback now includes same-file retry, metadata stripping under disabled processing, input-schema optionality, and two Codacy observations | all exact-head hosted checks green; CodeRabbit requests changes; five unresolved threads await independent adjudication | [#3461](https://github.com/amruthpillai/reactive-resume/pull/3461) | dispatch independent hosted review on next worker slot, then fix only proven findings and rereview | delivery/centering issues still lack source revisions/assets/expected crop |
|
||||
| 15 picture fitting/style | #3168, #3088, #2794, #2782 | 15A published; hosted review active; other causes blocked | `task_06bedd03c57a` / `ctx_f3a9297b252e` | `codex/issue-2782-picture-fit` | `7a98f6662` → `6145d5a59` | coordinate 06/25; schema/PDF owner exclusion | clean local rereview; hosted feedback includes same-file retry, metadata stripping under disabled processing, input-schema optionality, and two Codacy observations | all exact-head hosted checks green; CodeRabbit requests changes; five unresolved threads under independent adjudication | [#3461](https://github.com/amruthpillai/reactive-resume/pull/3461) | fix only independently proven findings, rereview, reply and resolve | delivery/centering issues still lack source revisions/assets/expected crop |
|
||||
| 16 imported table borders | #3196 | review fixes implementing | fix `task_7b7368639ff8` / `ctx_ba9ed045764f` | `codex/issue-3196-editable-tables` | `7a98f6662` → `83aca184e`, fix active | rich-text owner; must precede 19/31 | review found P1 unsupported-descendant preservation bypass plus P2 out-of-scope conversion UI and unrelated-save proof gaps; pinned plan resolves conversion by removal, not new semantics | implementation focused/full tests, typechecks, boundaries, build, and E2E green; fix TDD running | — | fix fail-closed detection, remove conversion action, prove unrelated persistence, rerun gates, independently rereview | historical visual equivalence lacks reporter HTML/JSON but feature contract is approved |
|
||||
| 17 list/skill pagination | #2751, #3040 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer owner shared with 13/14/18 | merged ordered-marker/wrap/level-gap fixes present; current residual not reproduced | audit focused PDF suites, typecheck, boundaries, build passed | — | retain controls; add fix only from exact failing list/skill fixture | #2751 source absent; #3040 current fixture no longer proves residual clipping |
|
||||
| 18 preview/export geometry | #2683 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | share output-boundary harness with 12; viewer owner exclusion | current viewport/page-size/margin baselines pass; video alone cannot locate cause | audit page/preview tests, affected typechecks, boundaries, build passed | — | compare identical preview/download bytes, MediaBoxes, ink bounds, viewport, DPR | exact JSON/PDF/browser/DPR/zoom/page settings absent |
|
||||
| 19 literal rich-text whitespace | #3397 | pending after 16 | unassigned | planned `codex/issue-3397-literal-whitespace` | `7a98f6662` → — | stack/rebase after 16; coordinate DOCX/PDF/editor with 31 | verified current marked-policy gap; approved marker contract and four-space tabs remain implementation-ready | audit whitespace/indentation suites, affected typechecks, boundaries, build passed | — | implement web/PDF/DOCX atomically after table seam stabilizes | no product blocker; serialized file ownership only |
|
||||
| 20 section restoration | #3378, #3265, #2921 | 20A implementing for #2921; residuals split | `task_4237c974827a` / `ctx_00770ded7b0d` | `codex/issue-2921-hidden-section-recovery` | `7a98f6662` → work active | 20A before 21/31; placement semantics before 29 | compact hidden-section recovery for verified #2921 executing; 20B defensive unplaced recovery waits for helper contract; #3378/#3265 causes remain unproved | audit focused web/resume tests, affected typechecks, boundaries passed; implementation tests running | — | complete and independently review #2921-only 20A; then separately assess 20B | #3378/#3265 need version/action/sanitized JSON; defensive fix cannot close them |
|
||||
| 20 section restoration | #3378, #3265, #2921 | 20A implemented for #2921; review queued; residuals split | queued `task_be0db32b205d` | `codex/issue-2921-hidden-section-recovery` | `7a98f6662` → `0ec054df7` | 20A before 21/31; placement semantics before 29 | compact hidden-section recovery implemented for verified #2921; no placement/deleted-content claims; #3378/#3265 causes remain unproved | focused resume/web tests, affected typechecks, boundaries, build, narrow Biome, and isolated authenticated PDF E2E green | — | dispatch independent full-diff review on next slot; fix or publish exact reviewed head | #3378/#3265 need version/action/sanitized JSON; defensive fix cannot close them |
|
||||
| 21 section heading visibility | #3060 | pending after 20A | audit `task_47ed7eb02d48` | `codex-audit-builder-20-34` | `7a98f6662` → no source change | 20A → 21 → 31 | runtime PDF seam exists; persisted schema/menu/DOCX/accessibility contract absent; Q1–Q3 make unit ready | audit schema/web/PDF/DOCX/resume suites and typechecks/boundaries passed | — | add migration-safe flag, menu, PDF/DOCX visual behavior, retained semantic label | serialize shared section/schema files |
|
||||
| 22 skill keyword presentation | #2785 | pending implementation | audit `task_47ed7eb02d48` | `codex-audit-builder-20-34` | `7a98f6662` → no source change | must precede/serialize 34 | array currently comma-joined; inline/list contract ready for built-in and custom Skills | audit schema/web/PDF/DOCX suites and typechecks/boundaries passed | — | select explicit Skills-specific schema trait; implement inline compatibility and semantic list mode | exact schema owner chosen during implementation; no product gate |
|
||||
| 23 pagination controls | #3350, #3090 | pending 23A/23B; 23C blocked | audit `task_47ed7eb02d48` | `codex-audit-builder-20-34` | `7a98f6662` → no source change | 23B → possible 23C | 23A authored-vs-physical page guidance ready; renderer clips oversized `wrap=false` section; item policy unproved | audit focused PDF/web suites and typechecks/boundaries passed | — | publish 23A; build short/boundary/oversized matrix in 23B before item control | safe oversized-item fallback and widow/orphan UI remain unresolved |
|
||||
@@ -113,14 +113,15 @@ state changes are outside scope.
|
||||
| Plan 15A independent review | `task_d4f4841355e2` / `ctx_467f293cf443` | same Plan 15A worktree | complete; changes required; worker released | medium: raster checks did not pin fit geometry; low: class coupling and duplicate props type |
|
||||
| Plan 15A review fix | `task_5a4afecb7d0d` / `ctx_43faac4f25eb` | same Plan 15A worktree | complete; worker released | commit `6145d5a59`; all three findings fixed; full tests/build and authenticated raster E2E green |
|
||||
| Plan 15A final rereview | `task_2b45ae3b4e98` / `ctx_695a139cd0b9` | same Plan 15A worktree | complete; no findings; worker released | exact head `6145d5a59`; full 70-file behavior, mutation-sensitive geometry, computed CSS, compatibility, scope, full suites, build, and E2E approved before PR #3461 |
|
||||
| Plan 15A hosted review | `task_06bedd03c57a` / not dispatched | same Plan 15A worktree | ready; awaiting worker slot | independently adjudicate five current threads, including three CodeRabbit change requests, on exact PR head; no GitHub mutation |
|
||||
| Plan 15A hosted review | `task_06bedd03c57a` / `ctx_f3a9297b252e` | same Plan 15A worktree | reviewing | independently adjudicate five current threads, including three CodeRabbit change requests, on exact PR head; no GitHub mutation |
|
||||
| Plan 07 hosted review follow-up | `task_6e9bc84ca2d4` / `ctx_e31d0e345240` | `codex/issue-2722-postgres-docs` | no findings; pushed; worker released | commit `a7b8c4c`; five valid comments fixed, `--no-deps` removal rejected; six replies and zero unresolved threads |
|
||||
| Plan 07 late hosted fix | `task_6d0545ee43b1` / `ctx_1d6a1e36def3` | same Plan 07 worktree | complete; worker released | commit `171637526`; separate image/repository build and log paths; Compose/docs gates green |
|
||||
| Plan 07 late fix rereview | `task_8ff818f3e95a` / `ctx_b73be2273e01` | same Plan 07 worktree | complete; no findings; pushed; worker released | exact head `171637526`; full-diff/Compose review and fresh coordinator gates green; hosted checks rerunning |
|
||||
| Plan 16 implementation | `task_f3d05a6ebb86` / `ctx_686ba93fc8af` | `codex/issue-3196-editable-tables` | complete; worker released | commit `83aca184e`; atomic editable supported tables, lossless unsupported fallback, PDF border geometry, persistence/E2E |
|
||||
| Plan 16 independent review | `task_e52d01cff964` / `ctx_63c00e7abb56` | same Plan 16 worktree | complete; changes required; worker released | P1 unsupported descendant markup can normalize destructively; P2 conversion is still HTML and E2E does not prove unrelated save persistence; orchestration report accepted by brief |
|
||||
| Plan 16 review fix | `task_7b7368639ff8` / `ctx_ba9ed045764f` | same Plan 16 worktree | implementing | fail-closed unsupported grammar, removal of out-of-scope conversion UX, and persisted unrelated-edit E2E proof via TDD |
|
||||
| Plan 20A implementation | `task_4237c974827a` / `ctx_00770ded7b0d` | `codex/issue-2921-hidden-section-recovery` in worktree `issue-3378-hidden-section-recovery` | implementing | #2921-only hidden-section recovery unit from current `origin/main`; test, commit, and report without publication |
|
||||
| Plan 20A implementation | `task_4237c974827a` / `ctx_00770ded7b0d` | `codex/issue-2921-hidden-section-recovery` in worktree `issue-3378-hidden-section-recovery` | complete; worker released | commit `0ec054df7`; #2921-only inventory/recovery UI, navigation, unit coverage, and authenticated PDF E2E |
|
||||
| Plan 20A independent review | `task_be0db32b205d` / not dispatched | same Plan 20A worktree | ready; awaiting worker slot | verify pure inventory, compact UI, exact layout preservation, accessibility, Lingui, E2E, and #2921-only scope |
|
||||
| Plan 10 implementation | `task_fd191afc86ba` / `ctx_5100e7419c11` | `codex/issue-2836-retired-link-notices` | implementing | prospective 90-day owner-only retired-link attempt notices with migration, privacy limits, and E2E |
|
||||
|
||||
## Existing PR and residual accounting
|
||||
|
||||
@@ -0,0 +1,28 @@
|
||||
# Independent review: Plan 20A hidden-section recovery
|
||||
|
||||
Review only in `/Users/amruth/orca/workspaces/reactive-resume/issue-3378-hidden-section-recovery` on branch
|
||||
`codex/issue-2921-hidden-section-recovery`. Exact target head:
|
||||
`0ec054df70e6f445557bd3a54a0d62686586b3de`. Do not edit tracked files, commit, push, publish, merge, or mutate issues.
|
||||
|
||||
Read current repository instructions, pinned approved Plan 20, implementation report, full `origin/main...HEAD` diff,
|
||||
live issues #2921/#3378/#3265, open PR overlap, and builder/resume-domain guidance. Refresh base and verify exact head.
|
||||
Run root Intent inventory and load matching review skill if any; no subagents.
|
||||
|
||||
Review Standards and Spec independently. Verify especially:
|
||||
|
||||
- pure `getSectionAvailability` inventory covers all printable built-ins, Summary, and real custom sections while excluding
|
||||
Picture, Basics, UI-only custom container, and unknown IDs; placement and hidden state remain independent; duplicate,
|
||||
later-page, and sidebar locations work without mutating data;
|
||||
- compact recovery UI replaces full editor panels only for hidden printable sections; effective localized titles, custom
|
||||
child behavior, navigation/focus, keyboard access, locked disablement, and undo/redo are correct;
|
||||
- Show changes only the existing hidden flag, preserving content, item order, and byte-equivalent layout arrays; an
|
||||
unplaced hidden section remains unplaced and no 20B placement behavior appears;
|
||||
- custom-section editor container stays usable when only some custom children are hidden;
|
||||
- package export, ownership, named props, SSR, Lingui catalog/source handling, and accessibility follow repository rules;
|
||||
- tests are mutation-sensitive and authenticated E2E proves save/reload, compact entries, PDF absence/restoration, exact
|
||||
authored layout preservation, undo/redo, locked state, and cleanup without accepting stale Saved state;
|
||||
- PR scope must reference #2921 only and must not claim recovery for #3378/#3265 or deleted content.
|
||||
|
||||
Run focused resume/web tests plus relevant existing visibility/menu/navigation regressions, affected typechecks, boundaries,
|
||||
production build, narrow non-writing Biome, Lingui/diff/scope gates, and isolated authenticated E2E if practical. Report
|
||||
findings first with severity/anchors and publication verdict in `.orchestration/plan-20a-review.md`; send `worker_done`.
|
||||
Reference in New Issue
Block a user