fix: use non-empty placeholder for redacted resume name (#3138)

* fix: use non-empty placeholder for redacted resume name

* fix: update stale test title to match new placeholder behavior

---------

Co-authored-by: Albano <alumno26.fazzito.albano@ipm.edu.ar>
This commit is contained in:
albanofazzito
2026-06-17 08:27:39 -03:00
committed by GitHub
parent 7275da7303
commit 1be75240dd
3 changed files with 4 additions and 4 deletions
+1 -1
View File
@@ -28,7 +28,7 @@ describe("resume DTO output validation", () => {
hasPassword: dbResume.hasPassword,
};
expect(publicResume.name).toBe("");
expect(publicResume.name).toBe("Resume");
expect(publicResume.data.metadata.notes).toBe("");
expect(resumeDto.getBySlug.output.safeParse(publicResume).success).toBe(true);
});
@@ -53,13 +53,13 @@ describe("redactResumeForViewer", () => {
expect(redactResumeForViewer(resume, true)).toBe(resume);
});
it("strips name to empty for non-owner", () => {
it("replaces name with placeholder for non-owner", () => {
const resume = {
name: "Senior Eng @ Foo — final draft",
data: defaultResumeData,
};
const result = redactResumeForViewer(resume, false);
expect(result.name).toBe("");
expect(result.name).toBe("Resume");
});
it("strips metadata.notes for non-owner", () => {
@@ -56,7 +56,7 @@ export function redactResumeForViewer<T extends { name: string; data: ResumeData
return {
...resume,
name: "",
name: "Resume",
data: {
...resume.data,
metadata: {