Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-10-04 18:53:52 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix(web): list custom section types directly once every section is in use

Browse Source
This commit is contained in:
Amruth Pillai
2026-09-29 11:10:49 +02:00
parent ab2e263a2c
commit 3c71b4e7c3
1 changed files with 33 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/src/features/resume/editor/write/add-section.tsx
+33 -21
View File
@@ -72,8 +72,9 @@ function addCustom(type: CustomSectionType) {
}
/**
* Add section: every section not in use, in two columns, plus Custom section, which asks for a type. The
* new section starts with one draft entry, open and focused.
* Add section: every section not in use, in two columns, plus Custom section, which asks for a type. Once every
* section is in use, the custom types are listed directly. The new section starts with one draft entry, open and
* focused.
*/
export function AddSectionMenu() {
const added = useEditorStore((state) => state.addedSections);
@@ -83,6 +84,12 @@ export function AddSectionMenu() {
.join(","),
);
const unused = unusedKey ? (unusedKey.split(",") as ("summary" | SectionType)[]) : [];
const customItems = CUSTOM_SECTION_TYPES.map((type) => (
<DropdownMenuItem key={type} onClick={() => addCustom(type)}>
<Icon name={SECTION_ICONS[type]} />
{getSectionTitle(type)}
</DropdownMenuItem>
));
return (
<DropdownMenu>
@@ -109,25 +116,30 @@ export function AddSectionMenu() {
</DropdownMenuGroup>
)}
{unused.length > 0 && <DropdownMenuSeparator />}
<DropdownMenuSub>
<DropdownMenuSubTrigger>
<Icon name="add" />
<Trans>Custom section</Trans>
</DropdownMenuSubTrigger>
<DropdownMenuSubContent className="w-56">
<DropdownMenuGroup>
<DropdownMenuLabel>
<Trans>What goes in it?</Trans>
</DropdownMenuLabel>
{CUSTOM_SECTION_TYPES.map((type) => (
<DropdownMenuItem key={type} onClick={() => addCustom(type)}>
<Icon name={SECTION_ICONS[type]} />
{getSectionTitle(type)}
</DropdownMenuItem>
))}
</DropdownMenuGroup>
</DropdownMenuSubContent>
</DropdownMenuSub>
{unused.length > 0 ? (
<DropdownMenuSub>
<DropdownMenuSubTrigger>
<Icon name="add" />
<Trans>Custom section</Trans>
</DropdownMenuSubTrigger>
<DropdownMenuSubContent className="w-56">
<DropdownMenuGroup>
<DropdownMenuLabel>
<Trans>What goes in it?</Trans>
</DropdownMenuLabel>
{customItems}
</DropdownMenuGroup>
</DropdownMenuSubContent>
</DropdownMenuSub>
) : (
// Every built-in section is in use, so the custom types are the only choice: list them here.
<DropdownMenuGroup className="grid grid-cols-2">
<DropdownMenuLabel className="col-span-2">
<Trans>Custom section</Trans>
</DropdownMenuLabel>
{customItems}
</DropdownMenuGroup>
)}
</DropdownMenuContent>
</DropdownMenu>
);