Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-10-04 02:33:47 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix(web): start a resume cover letter from a library letter again

Browse Source 
The entry dialogs removed with the Write panel carried "Import from
library", which copied a saved letter's recipient and text into a new
cover-letter entry. A new, empty cover-letter entry now offers the same
picker inline. The copy stays independent of the library letter.

The cover-letter-library spec drives the inline picker and waits for the
renamed JSON copy before checking the original, which removes a race with
the list refetch.
This commit is contained in:
Amruth Pillai
2026-09-28 19:07:03 +02:00
parent 49464bb7ff
commit 4da00ddce1
2 changed files with 46 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/specs/cover-letter-library.spec.ts
+11 -12
View File
@@ -1,7 +1,7 @@
import { randomUUID } from "node:crypto";
import { readFile } from "node:fs/promises";
import { Pool } from "pg";
import { createSampleResumeFromDashboard } from "../fixtures/resume";
import { createSampleResumeFromDashboard, openSidebarSection } from "../fixtures/resume";
import { expect, test } from "../fixtures/test";
test("imports a library letter into the builder as an independent copy", async ({ authPage: page }, testInfo) => {
@@ -45,21 +45,19 @@ test("imports a library letter into the builder as an independent copy", async (
await editor.getByRole("button", { name: "Close", exact: true }).click();
await page.goto(builderUrl);
await page.getByRole("button", { name: "Cover Letter", exact: true }).click();
await page.getByRole("button", { name: "Add a new item", exact: true }).last().click();
const createItem = page.getByRole("dialog", { name: "Create a new cover letter", exact: true });
await createItem.getByLabel("Import from library", { exact: true }).click();
await openSidebarSection(page, "Cover Letter");
await page.getByRole("button", { name: "Add cover letter", exact: true }).click();
await page.getByLabel("Import from library", { exact: true }).click();
await page.getByRole("option", { name: "Platform engineer letter", exact: true }).click();
const createEditors = createItem.locator('[data-editor="true"]');
await expect(createEditors.nth(0)).toContainText("Dear hiring team");
await expect(createEditors.nth(1)).toContainText("reliable platforms");
await createEditors.nth(1).fill("Updated independent resume copy.");
const letter = page.getByRole("textbox", { name: "Letter", exact: true });
await expect(page.getByRole("textbox", { name: "Recipient", exact: true })).toContainText("Dear hiring team");
await expect(letter).toContainText("reliable platforms");
const resumeSaved = page.waitForResponse(
(response) => new URL(response.url()).pathname === "/api/rpc/resume/update" && response.ok(),
);
await createItem.getByRole("button", { name: "Create", exact: true }).click();
await letter.fill("Updated independent resume copy.");
await resumeSaved;
await expect(page.getByRole("button", { name: /^Dear hiring team, Updated independent resume copy/ })).toBeVisible();
await expect(page.getByRole("button", { name: /^Updated independent resume copy\./ })).toBeVisible();
await page.goto("/dashboard/cover-letters");
await page.getByRole("button", { name: "Edit Platform engineer letter", exact: true }).click();
@@ -72,8 +70,9 @@ test("imports a library letter into the builder as an independent copy", async (
await editor.getByRole("button", { name: "Save Changes", exact: true }).click();
await expect(editor.getByRole("button", { name: "Save Changes", exact: true })).toBeDisabled();
await editor.getByRole("button", { name: "Close", exact: true }).click();
await expect(page.getByRole("button", { name: "Edit Platform engineer letter", exact: true })).toBeVisible();
// The renamed copy shows once the list has refetched; until then both rows carry the original name.
await expect(page.getByRole("button", { name: "Edit Imported independent copy", exact: true })).toBeVisible();
await expect(page.getByRole("button", { name: "Edit Platform engineer letter", exact: true })).toBeVisible();
});
test("keeps the application PDF snapshot after the library letter is deleted", async ({ authPage: page, account }) => {