Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-10-04 02:33:47 +10:00
Code Issues Packages Projects Releases Wiki Activity

docs: queue plan 15 hosted review

Browse Source
This commit is contained in:
Amruth Pillai
2026-09-06 01:44:41 +02:00
parent 02b53ee3d2
commit f2893fd677
2 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/execution/approved-issue-plans-ledger.md
+3 -2
View File
@@ -47,7 +47,7 @@ state changes are outside scope.
| 12 preview/export failures | #3323, #3290, #3033, #3007, #2609 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer ownership; share observation harness with 18 | zero drift; staged-preview/error-boundary baselines remain; reports cross persistence/font/PDF/viewer/deployment boundaries | audit focused web/PDF suites, affected typechecks, boundaries, build passed | — | isolate PT Sans, browser/config, and template-selection boundaries; no shared fix | exact JSON/output/browser/config/current reproduction missing |
| 13 font/glyph/spacing | #3249, #3159, #3147, #3093, #3089, #2988 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize font sources with 14/27 | merged metrics/cache/Unicode fixes present and passing; residuals require per-font/per-symptom fixtures | audit focused PDF/font suites, affected typechecks, boundaries, build passed | — | retain regressions; create residual unit only from exact failing font fixture | missing Ropa Sans/source strings/font hashes/before-after artifacts |
| 14 RTL export layout | #3275 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | serialize renderer/fonts with 13/27 | merged canvas-direction fix remains; broader shaping/bidi cause unproved | audit RTL/preview suites, affected typechecks, boundaries, build passed | — | run controlled same-bytes export matrix against approved shaping oracle | exact JSON/font/version and known-good reference absent |
| 15 picture fitting/style | #3168, #3088, #2794, #2782 | 15A published; other causes blocked | coordinator after clean independent review | `codex/issue-2782-picture-fit` | `7a98f6662` → `6145d5a59` | coordinate 06/25; schema/PDF owner exclusion | Cover/Contain geometry, computed CSS behavior, and shared props review findings fixed via mutation-tested TDD; final rereview found no issues | fresh coordinator 130 focused tests, four affected typechecks, boundaries, and production build green; full suite and 2 authenticated raster E2E green in independent review | [#3461](https://github.com/amruthpillai/reactive-resume/pull/3461) | monitor exact-head hosted checks and review; keep unmerged | delivery/centering issues still lack source revisions/assets/expected crop |
| 15 picture fitting/style | #3168, #3088, #2794, #2782 | 15A published; hosted review queued; other causes blocked | queued `task_06bedd03c57a` | `codex/issue-2782-picture-fit` | `7a98f6662` → `6145d5a59` | coordinate 06/25; schema/PDF owner exclusion | Cover/Contain geometry, computed CSS behavior, and shared props review findings fixed via mutation-tested TDD; final rereview found no issues; two low-risk Codacy threads await independent disposition | fresh coordinator 130 focused tests, four affected typechecks, boundaries, and production build green; full suite and 2 authenticated raster E2E green in independent review; autofix/Codacy/Greptile/Mintlify green | [#3461](https://github.com/amruthpillai/reactive-resume/pull/3461) | after E2E/CodeRabbit settle and slot frees, independently adjudicate all hosted feedback; keep unmerged | delivery/centering issues still lack source revisions/assets/expected crop |
| 16 imported table borders | #3196 | independently reviewing | review `task_e52d01cff964` / `ctx_63c00e7abb56` | `codex/issue-3196-editable-tables` | `7a98f6662` → `83aca184e` | rich-text owner; must precede 19/31 | supported tables are editable; unsupported table markup has lossless read-only fallback; explicit plain-text conversion and shared PDF border geometry included | implementation focused/full tests, typechecks, boundaries, build, and E2E green; independent review active | — | adjudicate independent findings, fix or publish exact reviewed head | historical visual equivalence lacks reporter HTML/JSON but feature contract is approved |
| 17 list/skill pagination | #2751, #3040 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | renderer owner shared with 13/14/18 | merged ordered-marker/wrap/level-gap fixes present; current residual not reproduced | audit focused PDF suites, typecheck, boundaries, build passed | — | retain controls; add fix only from exact failing list/skill fixture | #2751 source absent; #3040 current fixture no longer proves residual clipping |
| 18 preview/export geometry | #2683 | blocked corrective work; diagnostic-ready | audit `task_1c6582ccdeae` | `codex-audit-rendering-12-19` | `7a98f6662` → no source change | share output-boundary harness with 12; viewer owner exclusion | current viewport/page-size/margin baselines pass; video alone cannot locate cause | audit page/preview tests, affected typechecks, boundaries, build passed | — | compare identical preview/download bytes, MediaBoxes, ink bounds, viewport, DPR | exact JSON/PDF/browser/DPR/zoom/page settings absent |
@@ -112,6 +112,7 @@ state changes are outside scope.
| Plan 15A independent review | `task_d4f4841355e2` / `ctx_467f293cf443` | same Plan 15A worktree | complete; changes required; worker released | medium: raster checks did not pin fit geometry; low: class coupling and duplicate props type |
| Plan 15A review fix | `task_5a4afecb7d0d` / `ctx_43faac4f25eb` | same Plan 15A worktree | complete; worker released | commit `6145d5a59`; all three findings fixed; full tests/build and authenticated raster E2E green |
| Plan 15A final rereview | `task_2b45ae3b4e98` / `ctx_695a139cd0b9` | same Plan 15A worktree | complete; no findings; worker released | exact head `6145d5a59`; full 70-file behavior, mutation-sensitive geometry, computed CSS, compatibility, scope, full suites, build, and E2E approved before PR #3461 |
| Plan 15A hosted review | `task_06bedd03c57a` / not dispatched | same Plan 15A worktree | ready; awaiting worker slot and settled checks | adjudicate two low-risk Codacy comments plus any CodeRabbit/later feedback on exact PR head; no GitHub mutation |
| Plan 07 hosted review follow-up | `task_6e9bc84ca2d4` / `ctx_e31d0e345240` | `codex/issue-2722-postgres-docs` | no findings; pushed; worker released | commit `a7b8c4c`; five valid comments fixed, `--no-deps` removal rejected; six replies and zero unresolved threads |
| Plan 07 late hosted fix | `task_6d0545ee43b1` / `ctx_1d6a1e36def3` | same Plan 07 worktree | complete; worker released | commit `171637526`; separate image/repository build and log paths; Compose/docs gates green |
| Plan 07 late fix rereview | `task_8ff818f3e95a` / `ctx_b73be2273e01` | same Plan 07 worktree | complete; no findings; pushed; worker released | exact head `171637526`; full-diff/Compose review and fresh coordinator gates green; hosted checks rerunning |
@@ -125,7 +126,7 @@ state changes are outside scope.
| --- | --- | --- | --- | --- |
| PR #3453 | open, non-draft, mergeable, approved | `ccd111da894cf7d44cc3dee06c937f70d91fef24` | live 2026-09-05: E2E/autofix/Codacy/CodeRabbit/Greptile successful on exact head | monitor only; keep unmerged |
| PR #3454 | open, non-draft, mergeable, approved | `80b0d3ab02cc4292f8a4514db8c2516adc1f9dc3` | live 2026-09-05: E2E/autofix/Codacy/CodeRabbit/Greptile successful on exact head | monitor only; keep unmerged |
| PR #3461 | open, non-draft; hosted checks running | `6145d5a5925373287b87dfaa30ab675ebc84e105` | clean independent rereview; fresh coordinator focused tests, affected typechecks, boundaries, and production build green | monitor exact-head hosted checks/review; keep unmerged |
| PR #3461 | open, non-draft; hosted review active | `6145d5a5925373287b87dfaa30ab675ebc84e105` | clean independent rereview; fresh coordinator gates green; autofix/Codacy/Greptile/Mintlify green; E2E/CodeRabbit pending; two low-risk unresolved Codacy threads | dispatch independent hosted review when checks settle and slot frees; keep unmerged |
| Residual #2828 | pending product direction | — | stale whole-document concurrent-tab overwrite reproduced in Chromium/PostgreSQL; excluded from 63 | account for separately; do not implement conflict UI until product policy selected |
## Rulings and blockers log
docs/execution/briefs/review-plan-15a-hosted.md
+22
View File
@@ -0,0 +1,22 @@
# Independent hosted review: Plan 15A picture fitting
Review only in `/Users/amruth/orca/workspaces/reactive-resume/issue-2782-picture-fit` and live PR #3461.
Exact target head: `6145d5a5925373287b87dfaa30ab675ebc84e105`. Do not edit tracked files, commit, push, reply,
resolve threads, merge, or mutate issues.
Read current repository instructions, pinned approved Plan 15, implementation and review reports, full
`origin/main...HEAD` diff, issue #2782, live PR checks/reviews, and every current review thread. Refresh base and verify
exact head. Run root Intent inventory and load matching review skill if any; no subagents.
Adjudicate hosted feedback independently. Current Codacy threads note:
- Contain uploads intentionally bypass cropping to preserve original image; users can only access crop flow in Cover.
- `PictureFitField` could map over fit-option metadata instead of declaring two buttons.
Determine whether either is a real Standards or approved-Spec defect. Verify selected-mode behavior, accessible labels,
autosave/lock behavior, original-file preservation, warning copy, test mutation sensitivity, and whether refactoring would
improve correctness rather than merely alter style. Inspect any CodeRabbit or later threads that exist at review time.
Run focused web/schema/PDF tests and narrow non-writing formatting/diff gates as needed. Report findings first with
severity and anchors, exact-head/check state, each thread disposition, and publication verdict in
`.orchestration/plan-15a-hosted-review.md`; send `worker_done`.