Compare commits

...

2 Commits

Author SHA1 Message Date
ephraimduncan 9e73e55953 Merge remote-tracking branch 'origin/main' into pr-2848
# Conflicts:
#	packages/lib/constants/app.ts
2026-07-02 06:48:01 +00:00
ephraimduncan beea267910 feat: allow signing reason override 2026-05-21 03:49:00 +00:00
5 changed files with 27 additions and 1 deletions
+2
View File
@@ -80,6 +80,8 @@ NEXT_PRIVATE_SIGNING_CSC_OAUTH_CLIENT_SECRET=
NEXT_PRIVATE_SIGNING_CSC_SIGNATURE_LEVEL=
# OPTIONAL: Comma-separated list of timestamp authority URLs for PDF signing (enables LTV and archival timestamps).
NEXT_PRIVATE_SIGNING_TIMESTAMP_AUTHORITY=
# OPTIONAL: Reason to embed in PDF signatures. Defaults to "Signed by Documenso".
NEXT_PRIVATE_SIGNING_REASON=
# OPTIONAL: Contact info to embed in PDF signatures. Defaults to the webapp URL.
NEXT_PUBLIC_SIGNING_CONTACT_INFO=
# OPTIONAL: Set to "true" to use the legacy adbe.pkcs7.detached subfilter instead of ETSI.CAdES.detached.
+21
View File
@@ -0,0 +1,21 @@
import { afterEach, describe, expect, it, vi } from 'vitest';
import { NEXT_PRIVATE_SIGNING_REASON } from './app';
describe('NEXT_PRIVATE_SIGNING_REASON', () => {
afterEach(() => {
vi.unstubAllEnvs();
});
it('defaults to the Documenso signing reason', () => {
vi.stubEnv('NEXT_PRIVATE_SIGNING_REASON', undefined);
expect(NEXT_PRIVATE_SIGNING_REASON()).toBe('Signed by Documenso');
});
it('uses the configured signing reason verbatim', () => {
vi.stubEnv('NEXT_PRIVATE_SIGNING_REASON', 'Signed by Objective');
expect(NEXT_PRIVATE_SIGNING_REASON()).toBe('Signed by Objective');
});
});
+1
View File
@@ -35,6 +35,7 @@ export const IS_AI_FEATURES_CONFIGURED = () => !!env('GOOGLE_VERTEX_PROJECT_ID')
export const NEXT_PRIVATE_USE_PLAYWRIGHT_PDF = () => env('NEXT_PRIVATE_USE_PLAYWRIGHT_PDF') === 'true';
export const NEXT_PRIVATE_SIGNING_TIMESTAMP_AUTHORITY = () => env('NEXT_PRIVATE_SIGNING_TIMESTAMP_AUTHORITY');
export const NEXT_PRIVATE_SIGNING_REASON = () => env('NEXT_PRIVATE_SIGNING_REASON') ?? 'Signed by Documenso';
/**
* Whether this Documenso instance is running in CSC (Cloud Signature Consortium) mode.
+2 -1
View File
@@ -1,4 +1,5 @@
import {
NEXT_PRIVATE_SIGNING_REASON,
NEXT_PRIVATE_USE_LEGACY_SIGNING_SUBFILTER,
NEXT_PUBLIC_SIGNING_CONTACT_INFO,
NEXT_PUBLIC_WEBAPP_URL,
@@ -42,7 +43,7 @@ export const signPdf = async ({ pdf }: SignOptions) => {
const { bytes } = await pdf.sign({
signer,
reason: 'Signed by Documenso',
reason: NEXT_PRIVATE_SIGNING_REASON(),
location: NEXT_PUBLIC_WEBAPP_URL(),
contactInfo: NEXT_PUBLIC_SIGNING_CONTACT_INFO(),
subFilter: NEXT_PRIVATE_USE_LEGACY_SIGNING_SUBFILTER() ? 'adbe.pkcs7.detached' : 'ETSI.CAdES.detached',
+1
View File
@@ -59,6 +59,7 @@ declare namespace NodeJS {
NEXT_PRIVATE_SIGNING_CSC_OAUTH_CLIENT_SECRET?: string;
NEXT_PRIVATE_SIGNING_CSC_SIGNATURE_LEVEL?: 'AES' | 'QES';
NEXT_PRIVATE_SIGNING_TIMESTAMP_AUTHORITY?: string;
NEXT_PRIVATE_SIGNING_REASON?: string;
NEXT_PUBLIC_SIGNING_CONTACT_INFO?: string;
NEXT_PRIVATE_USE_LEGACY_SIGNING_SUBFILTER?: string;