Ryan/Reactive-Resume
1
0
Fork 0
mirror of https://github.com/AmruthPillai/Reactive-Resume.git synced 2026-06-22 04:11:55 +10:00
Code Issues Packages Projects Releases Wiki Activity

fix(pdf): increase headerNameLineHeight to 1.3 to prevent descender clipping (#3050)

Browse Source 
All Heading elements apply overflow:hidden via safeTextStyle in primitives.tsx.
At 1.5× heading font size with lineHeight 1.2, the line box is too tight to
fully render descenders (g, p, y, etc.) in the resume header name field,
causing them to appear visually cut off.

Raising headerNameLineHeight from 1.2 to 1.3 adds enough vertical room for
descenders across all 13 templates that share this constant.

Fixes #3042
This commit is contained in:
brone1323
2026-05-12 17:02:16 -06:00
committed by GitHub
parent e35ff83911
commit d251d602fb
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/pdf/src/templates/shared/styles.ts
+5 -1
View File
@@ -21,7 +21,11 @@ export const mergeStyles = (...styles: StyleInput[]): Style => Object.assign({},
export const mergeLinkStyles = (...styles: StyleInput[]): Style => mergeStyles(...styles, linkUnderlineStyle);
export const headerNameLineHeight = 1.2;
// Increased from 1.2 to 1.3 to prevent descenders (g, p, y, etc.) from being
// clipped by the overflow:hidden applied in safeTextStyle on all Heading elements.
// At 1.5× heading font size, a lineHeight of 1.2 leaves insufficient room for
// the descender depth of many fonts, causing letters to appear visually cut off.
export const headerNameLineHeight = 1.3;
export type ResolvePlacementColorOptions = {
placement: TemplatePlacement;